categorical type handling fix (#1342)

* fix numeric category conversion bug

* correctly compute categorical summaries

* lint

* remove debugging print
This commit is contained in:
Bruce Martin
2020-04-02 14:44:07 -07:00
committed by GitHub
parent 308ee64f30
commit 7c56041b11
3 changed files with 60 additions and 34 deletions
+9 -2
View File
@@ -7,7 +7,10 @@ import {
callOnceLazy,
memoize
} from "./util";
import { summarizeContinuous, summarizeCategorical } from "./summarize";
import {
summarizeContinuous,
summarizeCategorical as _summarizeCategorical
} from "./summarize";
import {
histogramCategorical,
hashCategorical,
@@ -243,8 +246,11 @@ class Dataframe {
};
/*
Summarize the column data. Lazy eval;
Summarize the column data. Lazy eval, memoized
*/
const summarizeCategorical = callOnceLazy(() =>
_summarizeCategorical(column)
);
const summarize = callOnceLazy(() =>
isTypedArray(column)
? summarizeContinuous(column)
@@ -263,6 +269,7 @@ class Dataframe {
}
get.summarize = summarize;
get.summarizeCategorical = summarizeCategorical;
get.asArray = asArray;
get.has = has;
get.ihas = ihas;