1510-smoke-test (#1548)

* 1510-smoke-test

* config default

* update tests

* update test config

* fix linter errors

* more comments

* address comments

* use npm install in push_tests.yml

* use environment.default.json

* adding docs

* Take care of @mweiden's nits

* Save screenshots in the __tests__/screenshots/ directory

* typo

* docs

* Add chart tests (#1580)

* merge tests

* check if bin creation returned null before rendering charts (#1576)

* check if bin creation returned null before rendering charts

* refactor chart rendering into functions (#1577)

* little fixes from PR

* reintroduce fix to check for null values

* change getAllByClass to return element

* slice instead

* new stackedbar test

* feedback-1573-test (#1579)

* feedback-1573-test

* enable whole test set

* revert tests

Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>

* tweak test to actually render chart

* include snapshot

* remove async

* fix getAllHistograms

* properly grab id

Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>

Co-authored-by: Matt Weiden <538456+mweiden@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

client/__tests__/util/centroid.test.js

@@ -7,11 +7,10 @@ import * as Universe from "../../src/util/stateManager/universe";
 import { matrixFBSToDataframe } from "../../src/util/stateManager/matrix";
 import * as World from "../../src/util/stateManager/world";
 import * as REST from "./stateManager/sampleResponses";
-import { ControlsHelpers as CH } from "../../src/util/stateManager";
 
 describe("centroid", () => {
   let world;
-  let categoricalSelection;
+
   beforeAll(() => {
     // Create world + universe
     let universe = Universe.createUniverseFromResponse(
@@ -32,19 +31,10 @@ describe("centroid", () => {
       ...Universe.addObsLayout(universe, matrixFBSToDataframe(REST.layoutObs)),
     };
     world = World.createWorldFromEntireUniverse(universe);
-
-    // Create categorical selection from world
-    categoricalSelection = CH.createCategoricalSelection(
-      CH.selectableCategoryNames(world.schema)
-    );
   });
 
   test("field4 (categorical obsAnnotation)", () => {
-    const centroidResult = calcCentroid(
-      world,
-      "field4",
-      ["umap_0", "umap_1"]
-    );
+    const centroidResult = calcCentroid(world, "field4", ["umap_0", "umap_1"]);
 
     // Check to see that a centroid has been calculated for every categorical value
     const keysAsArray = Array.from(centroidResult.keys());
@@ -64,11 +54,7 @@ describe("centroid", () => {
   });
 
   test("field3 (boolean obsAnnotation)", () => {
-    const centroidResult = calcCentroid(
-      world,
-      "field3",
-      ["umap_0", "umap_1"]
-    );
+    const centroidResult = calcCentroid(world, "field3", ["umap_0", "umap_1"]);
 
     // Check to see that a centroid has been calculated for every categorical value
     const keysAsArray = Array.from(centroidResult.keys());

client/__tests__/util/dataframe/dataframe.test.js

@@ -918,43 +918,59 @@ describe("dataframe col", () => {
 });
 
 describe("label indexing", () => {
-
   test("IdentityInt32Index", () => {
     const idx = new Dataframe.IdentityInt32Index(12); // [0, 12)
 
     expect(Dataframe.isLabelIndex(idx)).toBeTruthy();
 
-    expect(idx.labels()).toEqual(new Int32Array([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11]));
+    expect(idx.labels()).toEqual(
+      new Int32Array([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11])
+    );
     expect(idx.getLabel(1)).toEqual(1);
     expect(idx.getOffset(1)).toEqual(1);
-    expect(idx.getOffsets([1,3])).toEqual([1,3])
-    expect(idx.getLabels([1, 3])).toEqual([1,3])
+    expect(idx.getOffsets([1, 3])).toEqual([1, 3]);
+    expect(idx.getLabels([1, 3])).toEqual([1, 3]);
     expect(idx.size()).toEqual(12);
 
     expect(idx.subset([2]).labels()).toEqual([2]);
     expect(idx.subset([2, 3, 4]).labels()).toEqual(new Int32Array([2, 3, 4]));
-    expect(idx.subset([0, 1, 2, 3]).labels()).toEqual(new Int32Array([0, 1, 2, 3]));
+    expect(idx.subset([0, 1, 2, 3]).labels()).toEqual(
+      new Int32Array([0, 1, 2, 3])
+    );
 
     expect(idx.isubset([2]).labels()).toEqual([2]);
     expect(idx.isubset([2, 3, 4]).labels()).toEqual(new Int32Array([2, 3, 4]));
-    expect(idx.isubset([0, 1, 2, 3]).labels()).toEqual(new Int32Array([0, 1, 2, 3]));
+    expect(idx.isubset([0, 1, 2, 3]).labels()).toEqual(
+      new Int32Array([0, 1, 2, 3])
+    );
 
-    expect(idx.subset([0, 1, 2, 3, 4])).toBeInstanceOf(Dataframe.IdentityInt32Index);
+    expect(idx.subset([0, 1, 2, 3, 4])).toBeInstanceOf(
+      Dataframe.IdentityInt32Index
+    );
     expect(idx.subset([2, 1, 0])).toBeInstanceOf(Dataframe.IdentityInt32Index);
     expect(idx.subset([1, 2, 3, 4])).toBeInstanceOf(Dataframe.DenseInt32Index);
     expect(idx.subset([0, 1, 3, 4])).toBeInstanceOf(Dataframe.DenseInt32Index);
-    expect(idx.subset([0, 1, 2, 3, 10])).toBeInstanceOf(Dataframe.DenseInt32Index);
+    expect(idx.subset([0, 1, 2, 3, 10])).toBeInstanceOf(
+      Dataframe.DenseInt32Index
+    );
     expect(idx.subset([4, 3, 2, 1])).toBeInstanceOf(Dataframe.DenseInt32Index);
     expect(idx.subset([4])).toBeInstanceOf(Dataframe.KeyIndex);
 
-    expect(idx.withLabel(99).labels()).toEqual(new Int32Array([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 99]));
-    expect(idx.dropLabel(0).labels()).toEqual(new Int32Array([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11]));
-    expect(idx.dropLabel(11).labels()).toEqual(new Int32Array([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]));
-    expect(idx.dropLabel(5).labels()).toEqual(new Int32Array([0, 1, 2, 3, 4, 6, 7, 8, 9, 10, 11]));
+    expect(idx.withLabel(99).labels()).toEqual(
+      new Int32Array([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 99])
+    );
+    expect(idx.dropLabel(0).labels()).toEqual(
+      new Int32Array([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11])
+    );
+    expect(idx.dropLabel(11).labels()).toEqual(
+      new Int32Array([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10])
+    );
+    expect(idx.dropLabel(5).labels()).toEqual(
+      new Int32Array([0, 1, 2, 3, 4, 6, 7, 8, 9, 10, 11])
+    );
   });
 
   test("DenseInt32Index", () => {
-
     const idx = new Dataframe.DenseInt32Index([99, 1002, 48, 0, 22]);
 
     expect(Dataframe.isLabelIndex(idx)).toBeTruthy();
@@ -964,17 +980,29 @@ describe("label indexing", () => {
     expect(idx.getOffset(1002)).toEqual(1);
     expect(idx.getOffset(0)).toEqual(3);
     expect(idx.getLabel(0)).toEqual(99);
-    expect(idx.getLabels(new Int32Array([2, 4]))).toEqual(new Int32Array([48, 22]));
+    expect(idx.getLabels(new Int32Array([2, 4]))).toEqual(
+      new Int32Array([48, 22])
+    );
     expect(idx.getLabels([2, 4])).toEqual([48, 22]);
     expect(idx.getOffsets([0, 48])).toEqual([3, 2]);
 
-    expect(idx.subset([1002, 0, 99]).labels()).toEqual(new Int32Array([1002, 0, 99]))
-    expect(idx.getOffsets(idx.subset([1002, 0, 99]).labels())).toEqual(new Int32Array([1, 3, 0]));
-    expect(idx.isubset([4, 1, 2]).labels()).toEqual(new Int32Array([22, 1002, 48]));
+    expect(idx.subset([1002, 0, 99]).labels()).toEqual(
+      new Int32Array([1002, 0, 99])
+    );
+    expect(idx.getOffsets(idx.subset([1002, 0, 99]).labels())).toEqual(
+      new Int32Array([1, 3, 0])
+    );
+    expect(idx.isubset([4, 1, 2]).labels()).toEqual(
+      new Int32Array([22, 1002, 48])
+    );
 
-    expect(idx.withLabel(88).labels()).toEqual(new Int32Array([99, 1002, 48, 0, 22, 88]));
+    expect(idx.withLabel(88).labels()).toEqual(
+      new Int32Array([99, 1002, 48, 0, 22, 88])
+    );
     expect(idx.withLabel(88).getOffset(88)).toEqual(5);
-    expect(idx.dropLabel(48).labels()).toEqual(new Int32Array([99, 1002, 0, 22]));
+    expect(idx.dropLabel(48).labels()).toEqual(
+      new Int32Array([99, 1002, 0, 22])
+    );
   });
 
   test("KeyIndex", () => {
@@ -991,9 +1019,13 @@ describe("label indexing", () => {
     expect(idx.subset(["green", "red"]).labels()).toEqual(["green", "red"]);
     expect(idx.isubset([2, 1, 0]).labels()).toEqual(["blue", "green", "red"]);
 
-    expect(idx.withLabel("yo").labels()).toEqual(["red", "green", "blue", "yo"]);
+    expect(idx.withLabel("yo").labels()).toEqual([
+      "red",
+      "green",
+      "blue",
+      "yo",
+    ]);
     expect(idx.withLabel("yo").getOffset("yo")).toEqual(3);
     expect(idx.dropLabel("blue").labels()).toEqual(["red", "green"]);
+  });
 });
-
-})

client/__tests__/util/promiseLimit.test.js

@@ -1,7 +1,7 @@
 import PromiseLimit from "../../src/util/promiseLimit";
 import { range } from "../../src/util/range";
 
-const delay = (t) => new Promise((resolve, reject) => setTimeout(resolve, t));
+const delay = (t) => new Promise((resolve) => setTimeout(resolve, t));
 
 describe("PromiseLimit", () => {
   test("simple evaluation, concurrency 1", async () => {
@@ -28,13 +28,14 @@ describe("PromiseLimit", () => {
 
   test("eval in order of insertion", async () => {
     const plimit = new PromiseLimit(100);
-    let counter = 0;
+
     const result = await Promise.all([
-      plimit.add(() => Promise.resolve((counter += 1))),
-      plimit.add(() => Promise.resolve((counter += 1))),
-      plimit.add(() => Promise.resolve((counter += 1))),
-      plimit.add(() => Promise.resolve((counter += 1))),
+      plimit.add(() => Promise.resolve(1)),
+      plimit.add(() => Promise.resolve(2)),
+      plimit.add(() => Promise.resolve(3)),
+      plimit.add(() => Promise.resolve(4)),
     ]);
+
     expect(result).toEqual([1, 2, 3, 4]);
   });
 
@@ -43,16 +44,15 @@ describe("PromiseLimit", () => {
     let running = 0;
     let maxRunning = 0;
 
-    const cbfn = async (i) => {
-      running = running + 1;
+    const callback = async () => {
+      running += 1;
       maxRunning = running > maxRunning ? running : maxRunning;
       await delay(100);
-      running = running - 1;
+      running -= 1;
     };
 
-    const result = await Promise.all(
-      range(10).map((i) => plimit.add(() => cbfn(i)))
-    );
+    await Promise.all(range(10).map((i) => plimit.add(() => callback(i))));
+
     expect(maxRunning).toEqual(2);
   });
 
@@ -60,6 +60,7 @@ describe("PromiseLimit", () => {
     const plimit = new PromiseLimit(2);
     const result = await Promise.all([
       plimit.add(() => Promise.resolve("OK")),
+      // eslint-disable-next-line prefer-promise-reject-errors -- unit test
       plimit.add(() => Promise.reject("not OK")).catch((e) => e),
       plimit.add(() => Promise.resolve("OK")),
       plimit

client/__tests__/util/stateManager/controlsHelpers.test.js

@@ -4,7 +4,6 @@ test controls helpers
 import { subsetAndResetGeneLists } from "../../../src/util/stateManager/controlsHelpers";
 import * as globals from "../../../src/globals";
 
-
 describe("controls helpers", () => {
   test("subsetAndResetGeneLists", () => {
     const geneList = [];
@@ -28,7 +27,7 @@ describe("controls helpers", () => {
     );
     const expectedNewUserDefinedGenes = [
       ...geneList.slice(0, 20),
-      ...geneList.slice(21)
+      ...geneList.slice(21),
     ].slice(0, globals.maxGenes);
     expect(globals.maxUserDefinedGenes).toBeLessThan(globals.maxGenes);
     expect(geneList.length).toBeGreaterThan(globals.maxGenes);

client/__tests__/util/stateManager/sampleResponses.js

@@ -1,4 +1,3 @@
-/* eslint no-bitwise: "off" */
 import _ from "lodash";
 import { flatbuffers } from "flatbuffers";
 import { NetEncoding } from "../../../src/util/stateManager/matrix_generated";
@@ -79,6 +78,7 @@ const anAnnotationsObsJSONResponse = {
       `obs${idx}`,
       2 * idx,
       idx + 0.0133,
+      // eslint-disable-next-line no-bitwise -- idx & 1 to check for odd numbers
       !!(idx & 1),
       field4Categories[idx % field4Categories.length],
     ])
@@ -93,6 +93,7 @@ const anAnnotationsVarJSONResponse = {
       idx,
       10 * idx,
       idx + 2.90143,
+      // eslint-disable-next-line no-bitwise -- idx & 1 to check for odd numbers
       !!(idx & 1),
       fieldDCategories[idx % fieldDCategories.length],
       `var${idx}`,
@@ -112,7 +113,7 @@ function encodeTypedArray(builder, uType, uData) {
 function encodeMatrix(columns, colIndex = undefined) {
   /*
   IMPORTANT: this is not a general purpose encoder.  in particular,
-  it doesn't correctly handle all column index types, nor does it 
+  it doesn't correctly handle all column index types, nor does it
   handle all column typedarray types.
 
   encodeMatrixFBS in matrix.py is more general.  This is used only

client/__tests__/util/typedCrossfilter/sort.test.js

@@ -2,9 +2,6 @@ import {
   sortArray,
   sortIndex,
   lowerBound,
-  upperBound,
-  lowerBoundIndirect,
-  upperBoundIndirect,
 } from "../../../src/util/typedCrossfilter/sort";
 
 /*
@@ -68,7 +65,7 @@ describe("sortArray", () => {
   });
 
   describe("non-finite numbers", () => {
-    test("inifinity", () => {
+    test("infinity", () => {
       expect(sortArray(new Float32Array([pInf, nInf, 0, 1, 2]))).toMatchObject(
         new Float32Array([nInf, 0, 1, 2, pInf])
       );