1510-smoke-test (#1548)

* 1510-smoke-test

* config default

* update tests

* update test config

* fix linter errors

* more comments

* address comments

* use npm install in push_tests.yml

* use environment.default.json

* adding docs

* Take care of @mweiden's nits

* Save screenshots in the __tests__/screenshots/ directory

* typo

* docs

* Add chart tests (#1580)

* merge tests

* check if bin creation returned null before rendering charts (#1576)

* check if bin creation returned null before rendering charts

* refactor chart rendering into functions (#1577)

* little fixes from PR

* reintroduce fix to check for null values

* change getAllByClass to return element

* slice instead

* new stackedbar test

* feedback-1573-test (#1579)

* feedback-1573-test

* enable whole test set

* revert tests

Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>

* tweak test to actually render chart

* include snapshot

* remove async

* fix getAllHistograms

* properly grab id

Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>

Co-authored-by: Matt Weiden <538456+mweiden@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

client/__tests__/util/promiseLimit.test.js

@@ -1,7 +1,7 @@
 import PromiseLimit from "../../src/util/promiseLimit";
 import { range } from "../../src/util/range";
 
-const delay = (t) => new Promise((resolve, reject) => setTimeout(resolve, t));
+const delay = (t) => new Promise((resolve) => setTimeout(resolve, t));
 
 describe("PromiseLimit", () => {
   test("simple evaluation, concurrency 1", async () => {
@@ -28,13 +28,14 @@ describe("PromiseLimit", () => {
 
   test("eval in order of insertion", async () => {
     const plimit = new PromiseLimit(100);
-    let counter = 0;
+
     const result = await Promise.all([
-      plimit.add(() => Promise.resolve((counter += 1))),
-      plimit.add(() => Promise.resolve((counter += 1))),
-      plimit.add(() => Promise.resolve((counter += 1))),
-      plimit.add(() => Promise.resolve((counter += 1))),
+      plimit.add(() => Promise.resolve(1)),
+      plimit.add(() => Promise.resolve(2)),
+      plimit.add(() => Promise.resolve(3)),
+      plimit.add(() => Promise.resolve(4)),
     ]);
+
     expect(result).toEqual([1, 2, 3, 4]);
   });
 
@@ -43,16 +44,15 @@ describe("PromiseLimit", () => {
     let running = 0;
     let maxRunning = 0;
 
-    const cbfn = async (i) => {
-      running = running + 1;
+    const callback = async () => {
+      running += 1;
       maxRunning = running > maxRunning ? running : maxRunning;
       await delay(100);
-      running = running - 1;
+      running -= 1;
     };
 
-    const result = await Promise.all(
-      range(10).map((i) => plimit.add(() => cbfn(i)))
-    );
+    await Promise.all(range(10).map((i) => plimit.add(() => callback(i))));
+
     expect(maxRunning).toEqual(2);
   });
 
@@ -60,6 +60,7 @@ describe("PromiseLimit", () => {
     const plimit = new PromiseLimit(2);
     const result = await Promise.all([
       plimit.add(() => Promise.resolve("OK")),
+      // eslint-disable-next-line prefer-promise-reject-errors -- unit test
       plimit.add(() => Promise.reject("not OK")).catch((e) => e),
       plimit.add(() => Promise.resolve("OK")),
       plimit