1510-smoke-test (#1548)

* 1510-smoke-test

* config default

* update tests

* update test config

* fix linter errors

* more comments

* address comments

* use npm install in push_tests.yml

* use environment.default.json

* adding docs

* Take care of @mweiden's nits

* Save screenshots in the __tests__/screenshots/ directory

* typo

* docs

* Add chart tests (#1580)

* merge tests

* check if bin creation returned null before rendering charts (#1576)

* check if bin creation returned null before rendering charts

* refactor chart rendering into functions (#1577)

* little fixes from PR

* reintroduce fix to check for null values

* change getAllByClass to return element

* slice instead

* new stackedbar test

* feedback-1573-test (#1579)

* feedback-1573-test

* enable whole test set

* revert tests

Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>

* tweak test to actually render chart

* include snapshot

* remove async

* fix getAllHistograms

* properly grab id

Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>

Co-authored-by: Matt Weiden <538456+mweiden@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

client/src/components/autosave/filenameDialog.js

@@ -113,7 +113,7 @@ class FilenameDialog extends React.Component {
             this.handleCreateFilename();
           }}
         >
-          <div className={Classes.DIALOG_BODY}>
+          <div className={Classes.DIALOG_BODY} data-testid="annotation-dialog">
             <div style={{ marginBottom: 20 }}>
               <p>Name your annotations collection:</p>
               <InputGroup
@@ -124,6 +124,7 @@ class FilenameDialog extends React.Component {
                   this.setState({ filenameText: e.target.value })
                 }
                 leftIcon="tag"
+                data-testid="new-annotation-name"
               />
               <p
                 style={{
@@ -159,6 +160,7 @@ class FilenameDialog extends React.Component {
                 onClick={this.handleCreateFilename}
                 intent="primary"
                 type="submit"
+                data-testid="submit-annotation"
               >
                 Create annotations collection
               </Button>

client/src/components/categorical/annoSelect.js

@@ -27,7 +27,14 @@ class DuplicateCategorySelect extends React.PureComponent {
           }
           filterable={false}
           itemRenderer={(d, { handleClick }) => {
-            return <MenuItem onClick={handleClick} key={d} text={d} />;
+            return (
+              <MenuItem
+                data-testclass="duplicate-category-dropdown-option"
+                onClick={handleClick}
+                key={d}
+                text={d}
+              />
+            );
           }}
           noResults={<MenuItem disabled text="No results." />}
           onItemSelect={(d) => {
@@ -36,6 +43,7 @@ class DuplicateCategorySelect extends React.PureComponent {
         >
           {/* children become the popover target; render value here */}
           <Button
+            data-testid="duplicate-category-dropdown"
             text={categoryToDuplicate || "None (all cells 'unassigned')"}
             rightIcon="double-caret-vertical"
           />

client/src/components/categorical/category/index.js

@@ -258,6 +258,7 @@ class Category extends React.Component {
           <span
             role="menuitem"
             tabIndex="0"
+            data-testclass="category-expand"
             data-testid={`${metadataField}:category-expand`}
             onKeyPress={(e) => {
               if (e.key === "Enter") {

client/src/components/graph/drawPointsRegl.js

@@ -1,6 +1,6 @@
 import { glPointFlags, glPointSize } from "../../util/glHelpers";
 
-export default function (regl) {
+export default function drawPointsRegl(regl) {
   return regl({
     vert: `
     precision mediump float;

client/src/components/scatterplot/drawPointsRegl.js

@@ -1,6 +1,6 @@
 import { glPointFlags, glPointSize } from "../../util/glHelpers";
 
-export default function (regl) {
+export default function drawPointsRegl(regl) {
   return regl({
     vert: `
     precision mediump float;