fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-10-02 23:58:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix for issue 1112 - all user annotation category names must be unique across all obs annotatoins (#1114)

Browse Source
This commit is contained in:
Bruce Martin
2020-01-16 09:28:29 -08:00
committed by GitHub
parent 30f3ce49e4
commit 8b329630f8
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/categorical/categorical.js
+6 -2
View File
@@ -71,8 +71,12 @@ class Categories extends React.Component {
/* allow empty string */ /* allow empty string */
if (name === "") return false; if (name === "") return false;
const { categoricalSelection } = this.props; /*
const allCategoryNames = Object.keys(categoricalSelection); test for uniqueness against *all* annotation names, not just the subset
we render as categorical.
*/
const { schema } = this.props;
const allCategoryNames = schema.annotations.obs.columns.map(c => c.name);
/* check category name syntax */ /* check category name syntax */
const error = AnnotationsHelpers.annotationNameIsErroneous(name); const error = AnnotationsHelpers.annotationNameIsErroneous(name);