chore: replace optimize-css-assets-webpack-plugin with css-minimizer-webpack-plugin (#2525)

* Replace optimize-css-assets-webpack-plugin with css-minimizer-webpack-plugin

* Fix lint issues in JS

* remove favicons

* update snapshots

* update annotations snapshots

Co-authored-by: Trent Smith <1429913+Bento007@users.noreply.github.com>
Co-authored-by: Seve Badajoz <sbadajoz@chanzuckerberg.com>

client/src/annoMatrix/viewCreators.js

@@ -58,10 +58,11 @@ function _maskToList(mask) {
   if (!mask) {
     return null;
   }
-  const list = new Int32Array(mask.length);
+  const [...m] = mask;
+  const list = new Int32Array(m.length);
   let elems = 0;
-  for (let i = 0, l = mask.length; i < l; i += 1) {
-    if (mask[i]) {
+  for (let i = 0, l = m.length; i < l; i += 1) {
+    if (m[i]) {
       list[elems] = i;
       elems += 1;
     }

client/src/annoMatrix/whereCache.js

@@ -91,12 +91,9 @@ export function _whereCacheCreate(field, query, columnLabels) {
 	*/
   if (typeof query !== "object") return null;
 
-  if (query.where) {
-    const {
-      field: queryField,
-      column: queryColumn,
-      value: queryValue,
-    } = query.where;
+  const { where, summarize } = query;
+  if (where) {
+    const { field: queryField, column: queryColumn, value: queryValue } = where;
     return {
       where: {
         [field]: {
@@ -107,13 +104,13 @@ export function _whereCacheCreate(field, query, columnLabels) {
       },
     };
   }
-  if (query.summarize) {
+  if (summarize) {
     const {
       method,
       field: queryField,
       column: queryColumn,
       values: queryValues,
-    } = query.summarize;
+    } = summarize;
     const queryValueHash = _hashStringValues(queryValues);
     return {
       summarize: {

client/src/util/stateManager/viewStackHelpers.js

@@ -139,8 +139,9 @@ function _getEmbeddingRowOffsets(baseRowIndex, embeddingDf) {
 
   Currently assumes that there will be onl two dimensions in the embedding.
   */
-  const X = embeddingDf.icol(0).asArray();
-  const Y = embeddingDf.icol(1).asArray();
+  const { icol } = embeddingDf;
+  const X = icol(0).asArray();
+  const Y = icol(1).asArray();
   const offsets = new Int32Array(X.length);
   let numOffsets = 0;