fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-10-05 04:58:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Allow float64 to down-cast to float32 (#472)

Browse Source 
* warn if annotations will down-cast to float32

* correctly handle falsey data values
This commit is contained in:
Bruce Martin
2018-11-27 11:17:30 -08:00
committed by GitHub
parent 0c26f227fe
commit 933fac5fff
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/brushableHistogram/index.js
+1 -1
View File
@@ -34,7 +34,7 @@ class HistogramBrush extends React.Component {
.scaleLinear() .scaleLinear()
.range([this.height - this.marginBottom, 0]); .range([this.height - this.marginBottom, 0]);
if (obsAnnotations[0][field]) { if (obsAnnotations[0][field] !== undefined) {
// recalculate expensive stuff // recalculate expensive stuff
const allValuesForContinuousFieldAsArray = _.map(obsAnnotations, field); const allValuesForContinuousFieldAsArray = _.map(obsAnnotations, field);
server/app/scanpy_engine/scanpy_engine.py
+3 -1
View File
@@ -67,7 +67,9 @@ class ScanpyEngine(CXGDriver):
@staticmethod @staticmethod
def _can_cast_to_float32(ann): def _can_cast_to_float32(ann):
if ann.dtype.kind == "f" and np.can_cast(ann.dtype, np.float32): if ann.dtype.kind == "f":
if not np.can_cast(ann.dtype, np.float32):
warnings.warn(f"Annotation {ann.name} will be converted to 32 bit float and may loose precision.")
return True return True
return False return False