fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-09-27 10:38:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve front-end HTTP error handling (#397)

Browse Source 
* UI for HTTP error handing in diffexp route

* HTTP error handling for other routes

* clean up toasters
This commit is contained in:
Bruce Martin
2018-10-30 19:02:11 -07:00
committed by GitHub
parent b181751493
commit 9d7754e31e
4 changed files with 104 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/geneExpression/index.js
+6 -11
View File
@@ -9,7 +9,7 @@ import { Button, Tooltip } from "@blueprintjs/core";
import HistogramBrush from "../brushableHistogram";
import * as globals from "../../globals";
import actions from "../../actions";
import { ErrorToastTopCenter } from "../framework/toasters";
import { postUserErrorToast } from "../framework/toasters";
import ExpressionButtons from "./expressionButtons";
@connect(state => {
@@ -47,18 +47,13 @@ class GeneExpression extends React.Component {
const { gene } = this.state;
if (userDefinedGenes.indexOf(gene) !== -1) {
ErrorToastTopCenter.show({
message: "That gene already exists"
});
postUserErrorToast("That gene already exists");
} else if (userDefinedGenes.length > 15) {
ErrorToastTopCenter.show({
message:
"That's too many genes, you can have at most 15 user defined genes"
});
postUserErrorToast(
"That's too many genes, you can have at most 15 user defined genes"
);
} else if (!_.find(world.varAnnotations, { name: gene })) {
ErrorToastTopCenter.show({
message: "That doesn't appear to be a valid gene name."
});
postUserErrorToast("That doesn't appear to be a valid gene name.");
} else {
dispatch(actions.requestUserDefinedGene(gene));
dispatch({