feat(geneset): save diff exp result as geneset (#2216)

* update package lock

* allow falsey vals

* remove old diff exp handling

* save diff exp results as geneset

* delete test

* check for undefined or null

* use global geneset description for diffexp

* remove diffexp special code, no longer showing adjpval + logfoldchange

* remove differential map to state

* remove clear from FSM, since we no longer support those actions

* restore controlHelpers test with todo

client/src/util/stateManager/colorHelpers.js

@@ -12,13 +12,7 @@ import { range } from "../range";
 given a color mode & accessor, generate an annoMatrix query that will
 fulfill it
 */
-export function createColorQuery(
-  colorMode,
-  colorByAccessor,
-  schema,
-  genesets,
-  diffExp
-) {
+export function createColorQuery(colorMode, colorByAccessor, schema, genesets) {
   if (!colorMode || !colorByAccessor || !schema || !genesets) return null;
 
   switch (colorMode) {
@@ -46,19 +40,8 @@ export function createColorQuery(
       if (!varIndex) return null;
       if (!genesets) return null;
 
-      let _geneset;
-      let _setGenes;
-
-      if (colorByAccessor === "Temp DiffExp Set") {
-        _geneset = diffExp;
-        _setGenes = _geneset.map((diffexpResultItem) => {
-          const geneName = diffexpResultItem[0];
-          return geneName;
-        });
-      } else {
-        _geneset = genesets.get(colorByAccessor);
-        _setGenes = [..._geneset.genes.keys()];
-      }
+      const _geneset = genesets.get(colorByAccessor);
+      const _setGenes = [..._geneset.genes.keys()];
 
       return [
         "X",

client/src/util/stateManager/controlsHelpers.js

@@ -2,7 +2,6 @@
 Helper functions for the controls reducer
 */
 
-import uniq from "lodash.uniq";
 import difference from "lodash.difference";
 
 import * as globals from "../../globals";
@@ -158,12 +157,3 @@ export function pruneVarDataCache(varData, needed) {
   }
   return varData;
 }
-
-export function subsetAndResetGeneLists(state) {
-  const { userDefinedGenes, diffexpGenes } = state;
-  const newUserDefinedGenes = uniq(
-    [].concat(userDefinedGenes, diffexpGenes)
-  ).slice(0, globals.maxGenes);
-  const newDiffExpGenes = [];
-  return [newUserDefinedGenes, newDiffExpGenes];
-}