From b18f96da77be81239f463fd5e86ee4b47fe463f6 Mon Sep 17 00:00:00 2001
From: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
Date: Wed, 5 Aug 2020 15:20:03 -0700
Subject: [PATCH] check for bins change for canvas draw (#1693)

* check for bins change for canvas draw

* PR feedback
---
 client/src/components/categorical/value/index.js | 4 +++-
 client/src/components/miniHistogram/index.js     | 5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/client/src/components/categorical/value/index.js b/client/src/components/categorical/value/index.js
index f40a9a99..c04af970 100644
--- a/client/src/components/categorical/value/index.js
+++ b/client/src/components/categorical/value/index.js
@@ -453,7 +453,9 @@ class CategoryValue extends React.Component {
         label,
         CHART_WIDTH,
         VALUE_HEIGHT
-      ) ?? {};
+      ) ?? {}; // if createHistogramBins returns empty object assign null to deconstructed
+
+    if (!xScale || !yScale || !bins) return null;
 
     return (
       <MiniHistogram
diff --git a/client/src/components/miniHistogram/index.js b/client/src/components/miniHistogram/index.js
index fb10e6cd..eb57f832 100644
--- a/client/src/components/miniHistogram/index.js
+++ b/client/src/components/miniHistogram/index.js
@@ -40,10 +40,11 @@ export default class MiniHistogram extends React.PureComponent {
   };
 
   componentDidUpdate = (prevProps) => {
-    const { obsOrVarContinuousFieldDisplayName } = this.props;
+    const { obsOrVarContinuousFieldDisplayName, bins } = this.props;
     if (
       prevProps.obsOrVarContinuousFieldDisplayName !==
-      obsOrVarContinuousFieldDisplayName
+        obsOrVarContinuousFieldDisplayName ||
+      prevProps.bins !== bins
     )
       this.drawHistogram();
   };