From b79f09c550c68fac08d1fcbfa14ab825b0f513e9 Mon Sep 17 00:00:00 2001 From: Timmy Huang Date: Fri, 26 Jun 2020 10:02:25 -0700 Subject: [PATCH] FIX-test-target-closed: remove jestPuppeteer.resetBrowser() (#1592) --- client/__tests__/e2e/e2e.test.js | 2 +- client/__tests__/e2e/puppeteer.setup.js | 24 ++++++++++-------------- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/client/__tests__/e2e/e2e.test.js b/client/__tests__/e2e/e2e.test.js index 5627a105..982a076a 100644 --- a/client/__tests__/e2e/e2e.test.js +++ b/client/__tests__/e2e/e2e.test.js @@ -149,7 +149,7 @@ describe("cell selection", () => { describe("gene entry", () => { test("search for single gene", async () => { await goToPage(appUrlBase); - addGeneToSearch(data.genes.search); + await addGeneToSearch(data.genes.search); }); test("bulk add genes", async () => { diff --git a/client/__tests__/e2e/puppeteer.setup.js b/client/__tests__/e2e/puppeteer.setup.js index cddb5efe..5fb28ec5 100644 --- a/client/__tests__/e2e/puppeteer.setup.js +++ b/client/__tests__/e2e/puppeteer.setup.js @@ -17,25 +17,21 @@ setDefaultOptions({ timeout: 20 * 1000 }); jest.retryTimes(ENV_DEFAULT.RETRY_ATTEMPTS); -beforeEach(async () => { - await jestPuppeteer.resetBrowser(); - +(async () => { const userAgent = await browser.userAgent(); await page.setUserAgent(`${userAgent}bot`); await page._client.send("Animation.setPlaybackRate", { playbackRate: 12 }); + page.on("pageerror", (err) => { + throw new Error(`Console error: ${err}`); + }); + + page.on("error", (err) => { + throw new Error(`Console error: ${err}`); + }); + page.on("console", async (msg) => { - page.on("pageerror", (err) => { - console.log(`PAGE LOG: ${msg.text()}`); - throw new Error(`Console error: ${err}`); - }); - - page.on("error", (err) => { - console.log(`PAGE LOG: ${msg.text()}`); - throw new Error(`Console error: ${err}`); - }); - if (isDev || isDebug) { // If there is a console.error but an error is not thrown, this will ensure the test fails console.log(`PAGE LOG: ${msg.text()}`); @@ -57,4 +53,4 @@ beforeEach(async () => { } } }); -}); +})();