Support python3.7 (#645)

* Support python3.7

* add 3.7 env to travis

.travis.yml

@@ -1,8 +1,8 @@
 language: python
-python:
+dist: xenial
-  - "3.6"
+sudo: required
 node_js:
-  - "8"
+  - 8
 cache:
   pip: true
 install:
@@ -15,14 +15,12 @@ install:
 
 jobs:
   include:
-  - name: "Branch Tests"
+  - name: "Branch Tests 3.7"
-    script:
+    python: "3.7"
-      - set -eo pipefail
+    script: ./travis-build.sh
-      - flake8 server
+  - name: "Branch Tests 3.6"
-      - black --check
+    python: "3.6"
-      - npm run --prefix client/ build
+    script: ./travis-build.sh
-      - npm run --prefix client/ unit-test
-      - pytest -s server/test
   - name: "Smoke Tests"
     if: branch = master AND type = cron
     script:

makefile

@@ -123,6 +123,6 @@ install-release : uninstall
 	@echo "Installed cellxgene from pypi.org"
 
 uninstall :
-	yes | pip uninstall cellxgene || true
+	pip uninstall -y cellxgene || :
 
 .PHONY : install install-dev install-release-test install-release uninstall

server/requirements.txt

@@ -12,3 +12,4 @@ pandas>=0.23.1
 scanpy>=1.3.2
 scipy>=1.1.0
 scikit-learn>=0.19.1,!=0.20.0
+tables>=3.5.1

setup.py

@@ -1,13 +1,4 @@
 from setuptools import setup, find_packages
-import sys
-
-if sys.version_info[0:2] != (3, 6):
-    raise ImportError(
-        "cellxgene currently only supports python 3.6. Python 3.7 is known to fail; we will look at supporting "
-        "versions other than 3.6 in the future."
-        "See https://github.com/chanzuckerberg/cellxgene#conda-and-virtual-environments "
-        "for more help with installation."
-    )
 
 with open("README.md", "rb") as fh:
     long_description = fh.read().decode()
@@ -40,6 +31,7 @@ setup(
         "Programming Language :: JavaScript",
         "Programming Language :: Python :: 3",
         "Programming Language :: Python :: 3.6",
+        "Programming Language :: Python :: 3.7",
         "Programming Language :: Python :: 3 :: Only",
         "Topic :: Scientific/Engineering :: Bio-Informatics",
     ],

travis-build.sh

@@ -0,0 +1,5 @@
+set -eo pipefail
+flake8 server
+npm run --prefix client/ build
+npm run --prefix client/ unit-test
+pytest -s server/test