tighten up error reporting (#1269)

* black reformat

* tighten up error reporting

* lint

* fine tuning

* additional improvements in exception handling

* lint

* include exception and traceback in log

* fix typo

server/data_common/data_adaptor.py

@@ -253,8 +253,8 @@ class DataAdaptor(metaclass=ABCMeta):
 
         try:
             obs_selector, var_selector = self._filter_to_mask(filter)
-        except (KeyError, IndexError, TypeError, AttributeError) as e:
-            raise FilterError(f"Error parsing filter: {e}") from e
+        except (KeyError, IndexError, TypeError, AttributeError):
+            raise FilterError("Error parsing filter")
 
         if obs_selector is not None:
             raise FilterError("filtering on obs unsupported")
@@ -281,8 +281,8 @@ class DataAdaptor(metaclass=ABCMeta):
             shape = self.get_shape()
             obs_mask_A = self._axis_filter_to_mask(Axis.OBS, obsFilterA["obs"], shape[0])
             obs_mask_B = self._axis_filter_to_mask(Axis.OBS, obsFilterB["obs"], shape[0])
-        except (KeyError, IndexError) as e:
-            raise FilterError(f"Error parsing filter: {e}") from e
+        except (KeyError, IndexError):
+            raise FilterError("Error parsing filter")
         if top_n is None:
             top_n = DEFAULT_TOP_N
 

server/data_common/matrix_loader.py

@@ -148,8 +148,7 @@ class MatrixDataLoader(object):
             self.matrix_data_type = self.__matrix_data_type()
 
         if not self.__matrix_data_type_allowed(app_config):
-            raise DatasetAccessError(
-                f"{self.location} does not have an allowed type: {str(self.matrix_data_type)}")
+            raise DatasetAccessError(f"{self.location} does not have an allowed type: {str(self.matrix_data_type)}")
 
         if self.matrix_data_type == MatrixDataType.H5AD:
             from server.data_anndata.anndata_adaptor import AnndataAdaptor