Add eslint steps to lint job (#1335)

* add lint-client and lint-diff-client targets

* add lint-diff and lint targets

* prettier

* add lint-diff call to lint task

* temp

* tweak lint-diff

* add lint for PRs and lint for master

* remove temp

* remove incorrect branches syntax, use github_ref

* pull all branches

* format

* proper target and comment

* create separate steps with conditionals

* fix indentation

* refactor lint->lint-server, introduce lint to lint all

* trade diff-index for diff, do check against base instead of master

* remove fetching all branches

* Revert "remove fetching all branches"

This reverts commit 26ce7a0f05.

* tweak comparison

* use local eslint

* add eslint  dep install

* temp

* grab only base

* simplify fetch

* add pull_request type trigger

* specify pushes only to master

* change conditionals to be based on event name

* Revert "temp"

This reverts commit 3d59134cc0.

* "branch" => "branches"

* create separate installation step

* change command based on os

Makefile

@@ -74,9 +74,20 @@ fmt-py:
 	black .
 
 .PHONY: lint
-lint:
+lint: lint-server lint-client
+
+.PHONY: lint-server
+lint-server:
 	flake8 server
 
+.PHONY: lint-client
+lint-client:
+	cd client && $(MAKE) lint
+
+.PHONY: lint-diff-client
+lint-diff-client:
+	cd client && $(MAKE) lint-diff
+
 
 # CREATING DISTRIBUTION RELEASE