Add linting rules around ESLint directive comments (#1551)

* add eslint-plugin-eslint-comments and require descriptive configuration

https://eslint.org/docs/user-guide/configuring#using-configuration-comments

* update ESLint

* audit ESLint disables

* update ESLint and related dependencies

client/src/components/menubar/diffexpButtons.js

@@ -42,7 +42,13 @@ class DiffexpButtons extends React.Component {
 
   render() {
     /* diffexp-related buttons may be disabled */
-    const { differential, diffexpMayBeSlow, diffexpCellcountMax } = this.props;
+    const {
+      differential,
+      diffexpMayBeSlow,
+      diffexpCellcountMax,
+      crossfilter,
+      dispatch,
+    } = this.props;
 
     const haveBothCellSets =
       !!differential.celllist1 && !!differential.celllist2;
@@ -66,14 +72,17 @@ class DiffexpButtons extends React.Component {
 
     return (
       <ButtonGroup className={styles.menubarButton}>
+        {/* eslint-disable react/jsx-props-no-spreading --- disable until eslint-config-airbnb v18.1.1*/}
         <CellSetButton
-          {...this.props} // eslint-disable-line react/jsx-props-no-spreading
+          {...{ differential, crossfilter, dispatch }}
           eitherCellSetOneOrTwo={1}
         />
         <CellSetButton
-          {...this.props} // eslint-disable-line react/jsx-props-no-spreading
+          {...{ differential, crossfilter, dispatch }}
           eitherCellSetOneOrTwo={2}
         />
+        {/* eslint-enable react/jsx-props-no-spreading --- end disable*/}
+
         {!differential.diffExp ? (
           <Tooltip
             content={warnMaxSizeExceeded ? tipMessageWarn : tipMessage}