fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-10-04 13:58:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not save during annotations tests

Browse Source
This commit is contained in:
Matt Weiden
2020-02-12 19:33:18 -08:00
parent ab141f2a7b
commit f0bd970bb2
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/Makefile
+1 -1
View File
@@ -77,7 +77,7 @@ smoke-test:
.PHONY: smoke-test-annotations .PHONY: smoke-test-annotations
smoke-test-annotations: smoke-test-annotations:
start_server_and_test \ start_server_and_test \
'CXG_OPTIONS="--experimental-annotations --experimental-annotations-file $(ANNOTATIONS)" $(MAKE) start-server' \ 'AUTOSAVE_ENABLED=false CXG_OPTIONS="--experimental-annotations --experimental-annotations-file $(ANNOTATIONS)" $(MAKE) start-server' \
$(CXG_SERVER_PORT) \ $(CXG_SERVER_PORT) \
'$(MAKE) e2e-annotations' '$(MAKE) e2e-annotations'
client/src/components/autosave/index.js
+1 -1
View File
@@ -50,7 +50,7 @@ class Autosave extends React.Component {
/* return true if we need to save, false if we don't */ /* return true if we need to save, false if we don't */
const { obsAnnotations, lastSavedObsAnnotations } = this.props; const { obsAnnotations, lastSavedObsAnnotations } = this.props;
return ( return (
lastSavedObsAnnotations && obsAnnotations !== lastSavedObsAnnotations globals.autosaveEnabled && lastSavedObsAnnotations && obsAnnotations !== lastSavedObsAnnotations
); );
}; };
client/src/globals.js
+3
View File
@@ -1,6 +1,9 @@
import { Colors } from "@blueprintjs/core"; import { Colors } from "@blueprintjs/core";
import { dispatchNetworkErrorMessageToUser } from "./util/actionHelpers"; import { dispatchNetworkErrorMessageToUser } from "./util/actionHelpers";
/* flags for testing */
export const autosaveEnabled = process.env.AUTOSAVE_ENABLED ? process.env.AUTOSAVE_ENABLED === "true" : true;
/* if a categorical metadata field has more options than this, truncate */ /* if a categorical metadata field has more options than this, truncate */
export const maxCategoricalOptionsToDisplay = 100; export const maxCategoricalOptionsToDisplay = 100;