app_config, fix bug with list/tuple command line arguments. (#1464)

* app_config, fix bug with list/tuple command line arguments.

There was a error caused by pyyaml using lists, and click using tuples.
Now tuples are automatically converted to lists when the config is
updated.
This commit is contained in:
bmccandless
2020-05-06 12:00:02 -07:00
committed by GitHub
parent 5947306ca0
commit f49507f18a
2 changed files with 23 additions and 6 deletions
+16 -2
View File
@@ -9,6 +9,20 @@ class AppConfigTest(unittest.TestCase):
def test_update(self):
c = AppConfig()
c.update(server__verbose=True, multi_dataset__dataroot="datadir")
v = c.changes_from_default()
self.assertCountEqual(v, [("server__verbose", True, False), ("multi_dataset__dataroot", "datadir", None)]),
self.assertCountEqual(v, [("server__verbose", True, False), ("multi_dataset__dataroot", "datadir", None)])
c = AppConfig()
c.update(server__scripts=(), server__inline_scripts=())
v = c.changes_from_default()
self.assertCountEqual(v, [])
c = AppConfig()
c.update(server__scripts=[], server__inline_scripts=[])
v = c.changes_from_default()
self.assertCountEqual(v, [])
c = AppConfig()
c.update(server__scripts=("a", "b"), server__inline_scripts=["c", "d"])
v = c.changes_from_default()
self.assertCountEqual(v, [("server__scripts", ["a", "b"], []), ("server__inline_scripts", ["c", "d"], [])])