mirror of
https://github.com/chanzuckerberg/cellxgene.git
synced 2026-10-01 01:08:11 +08:00
* refactor categorical controls state * lint * fix race condition in tests * fix typo * add missing update on subset * remove obsolete code * update jest and puppeteer major version; update all minors * update when label changes * remove lint from tests; increase timeouts in e2e tests * changes in response to PR review * lint * more PR comment changes * more PR comment fixes * lint * more PR comment resolutions
220 lines
6.2 KiB
JavaScript
220 lines
6.2 KiB
JavaScript
// jshint esversion: 6
|
|
import React from "react";
|
|
import { Button } from "@blueprintjs/core";
|
|
import { connect } from "react-redux";
|
|
import * as globals from "../../globals";
|
|
import Category from "./category";
|
|
import { AnnotationsHelpers, ControlsHelpers } from "../../util/stateManager";
|
|
import AnnoDialog from "./annoDialog";
|
|
import AnnoSelect from "./annoSelect";
|
|
import LabelInput from "./labelInput";
|
|
import { labelPrompt } from "./labelUtil";
|
|
|
|
@connect((state) => ({
|
|
writableCategoriesEnabled: state.config?.parameters?.annotations ?? false,
|
|
schema: state.world?.schema,
|
|
ontology: state.ontology,
|
|
}))
|
|
class Categories extends React.Component {
|
|
constructor(props) {
|
|
super(props);
|
|
this.state = {
|
|
createAnnoModeActive: false,
|
|
newCategoryText: "",
|
|
categoryToDuplicate: null,
|
|
expandedCats: new Set(),
|
|
};
|
|
}
|
|
|
|
handleCreateUserAnno = (e) => {
|
|
const { dispatch } = this.props;
|
|
const { newCategoryText, categoryToDuplicate } = this.state;
|
|
dispatch({
|
|
type: "annotation: create category",
|
|
data: newCategoryText,
|
|
categoryToDuplicate,
|
|
});
|
|
this.setState({
|
|
createAnnoModeActive: false,
|
|
categoryToDuplicate: null,
|
|
newCategoryText: "",
|
|
});
|
|
e.preventDefault();
|
|
};
|
|
|
|
handleEnableAnnoMode = () => {
|
|
this.setState({ createAnnoModeActive: true });
|
|
};
|
|
|
|
handleDisableAnnoMode = () => {
|
|
this.setState({
|
|
createAnnoModeActive: false,
|
|
categoryToDuplicate: null,
|
|
newCategoryText: "",
|
|
});
|
|
};
|
|
|
|
handleModalDuplicateCategorySelection = (d) => {
|
|
this.setState({ categoryToDuplicate: d });
|
|
};
|
|
|
|
categoryNameError = (name) => {
|
|
/*
|
|
return false if this is a LEGAL/acceptable category name or NULL/empty string,
|
|
or return an error type.
|
|
*/
|
|
|
|
/* allow empty string */
|
|
if (name === "") return false;
|
|
|
|
/*
|
|
test for uniqueness against *all* annotation names, not just the subset
|
|
we render as categorical.
|
|
*/
|
|
const { schema } = this.props;
|
|
const allCategoryNames = schema.annotations.obs.columns.map((c) => c.name);
|
|
|
|
/* check category name syntax */
|
|
const error = AnnotationsHelpers.annotationNameIsErroneous(name);
|
|
if (error) {
|
|
return error;
|
|
}
|
|
|
|
/* disallow duplicates */
|
|
if (allCategoryNames.indexOf(name) !== -1) {
|
|
return "duplicate";
|
|
}
|
|
|
|
/* otherwise, no error */
|
|
return false;
|
|
};
|
|
|
|
handleChange = (name) => {
|
|
this.setState({ newCategoryText: name });
|
|
};
|
|
|
|
handleSelect = (name) => {
|
|
this.setState({ newCategoryText: name });
|
|
};
|
|
|
|
instruction = (name) => {
|
|
return labelPrompt(
|
|
this.categoryNameError(name),
|
|
"New, unique category name",
|
|
":"
|
|
);
|
|
};
|
|
|
|
onExpansionChange = (catName) => {
|
|
const { expandedCats } = this.state;
|
|
if (expandedCats.has(catName)) {
|
|
const _expandedCats = new Set(expandedCats);
|
|
_expandedCats.delete(catName);
|
|
this.setState({ expandedCats: _expandedCats });
|
|
} else {
|
|
const _expandedCats = new Set(expandedCats);
|
|
_expandedCats.add(catName);
|
|
this.setState({ expandedCats: _expandedCats });
|
|
}
|
|
};
|
|
|
|
render() {
|
|
const {
|
|
createAnnoModeActive,
|
|
categoryToDuplicate,
|
|
newCategoryText,
|
|
expandedCats,
|
|
} = this.state;
|
|
const { writableCategoriesEnabled, schema, ontology } = this.props;
|
|
const ontologyEnabled = ontology?.enabled ?? false;
|
|
/* all names, sorted in display order. Will be rendered in this order */
|
|
const allCategoryNames = ControlsHelpers.selectableCategoryNames(
|
|
schema
|
|
).sort();
|
|
|
|
return (
|
|
<div
|
|
style={{
|
|
padding: globals.leftSidebarSectionPadding,
|
|
}}
|
|
>
|
|
<AnnoDialog
|
|
isActive={createAnnoModeActive}
|
|
title="Create new category"
|
|
instruction={this.instruction(newCategoryText)}
|
|
cancelTooltipContent="Close this dialog without creating a category."
|
|
primaryButtonText="Create new category"
|
|
primaryButtonProps={{ "data-testid": "submit-category" }}
|
|
text={newCategoryText}
|
|
validationError={this.categoryNameError(newCategoryText)}
|
|
handleSubmit={this.handleCreateUserAnno}
|
|
handleCancel={this.handleDisableAnnoMode}
|
|
annoInput={
|
|
<LabelInput
|
|
labelSuggestions={ontologyEnabled ? ontology.terms : null}
|
|
onChange={this.handleChange}
|
|
onSelect={this.handleSelect}
|
|
inputProps={{
|
|
"data-testid": "new-category-name",
|
|
leftIcon: "tag",
|
|
intent: "none",
|
|
autoFocus: true,
|
|
}}
|
|
newLabelMessage="New category"
|
|
/>
|
|
}
|
|
annoSelect={
|
|
<AnnoSelect
|
|
handleModalDuplicateCategorySelection={
|
|
this.handleModalDuplicateCategorySelection
|
|
}
|
|
categoryToDuplicate={categoryToDuplicate}
|
|
allCategoryNames={allCategoryNames}
|
|
/>
|
|
}
|
|
/>
|
|
|
|
{/* READ ONLY CATEGORICAL FIELDS */}
|
|
{/* this is duplicative but flat, could be abstracted */}
|
|
{allCategoryNames.map((catName) =>
|
|
!schema.annotations.obsByName[catName].writable ? (
|
|
<Category
|
|
key={catName}
|
|
metadataField={catName}
|
|
onExpansionChange={this.onExpansionChange}
|
|
isExpanded={expandedCats.has(catName)}
|
|
createAnnoModeActive={createAnnoModeActive}
|
|
/>
|
|
) : null
|
|
)}
|
|
{/* WRITEABLE FIELDS */}
|
|
{allCategoryNames.map((catName) =>
|
|
schema.annotations.obsByName[catName].writable ? (
|
|
<Category
|
|
key={catName}
|
|
metadataField={catName}
|
|
onExpansionChange={this.onExpansionChange}
|
|
isExpanded={expandedCats.has(catName)}
|
|
createAnnoModeActive={createAnnoModeActive}
|
|
/>
|
|
) : null
|
|
)}
|
|
|
|
{writableCategoriesEnabled ? (
|
|
<div>
|
|
<Button
|
|
data-testid="open-annotation-dialog"
|
|
onClick={this.handleEnableAnnoMode}
|
|
intent="primary"
|
|
>
|
|
Create new category
|
|
</Button>
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
);
|
|
}
|
|
}
|
|
|
|
export default Categories;
|