Exclude teardown metrics from executors in the gungraun benchmark functions (#4336)

This commit is contained in:
Keavon Chambers
2026-07-15 05:29:48 -07:00
committed by GitHub
parent dc813e35fc
commit e40fe7843d
3 changed files with 12 additions and 3 deletions

View File

@@ -18,9 +18,12 @@ fn setup_run_cached(name: &str) -> DynamicExecutor {
#[library_benchmark]
#[benches::with_setup(args = ["isometric-fountain", "painted-dreams", "parametric-dunescape", "red-dress", "valley-of-spires"], setup = setup_run_cached)]
pub fn run_cached(executor: DynamicExecutor) {
pub fn run_cached(executor: DynamicExecutor) -> DynamicExecutor {
let context = RenderConfig::default();
black_box(futures::executor::block_on(executor.tree().eval_tagged_value(executor.output(), black_box(context))).unwrap());
// Return the executor so its teardown happens outside the measured section
executor
}
library_benchmark_group!(name = run_cached_group; benchmarks = run_cached);

View File

@@ -13,9 +13,12 @@ fn setup_run_once(name: &str) -> DynamicExecutor {
#[library_benchmark]
#[benches::with_setup(args = ["isometric-fountain", "painted-dreams", "procedural-string-lights", "parametric-dunescape", "red-dress", "valley-of-spires"], setup = setup_run_once)]
pub fn run_once(executor: DynamicExecutor) {
pub fn run_once(executor: DynamicExecutor) -> DynamicExecutor {
let context = application_io::RenderConfig::default();
black_box(futures::executor::block_on(executor.tree().eval_tagged_value(executor.output(), black_box(context))).unwrap());
// Return the executor so its teardown happens outside the measured section
executor
}
library_benchmark_group!(name = run_once_group; benchmarks = run_once);

View File

@@ -15,9 +15,12 @@ fn setup_update_executor(name: &str) -> (DynamicExecutor, ProtoNetwork) {
#[library_benchmark]
#[benches::with_setup(args = ["isometric-fountain", "painted-dreams", "procedural-string-lights", "parametric-dunescape", "red-dress", "valley-of-spires"], setup = setup_update_executor)]
pub fn update_executor(setup: (DynamicExecutor, ProtoNetwork)) {
pub fn update_executor(setup: (DynamicExecutor, ProtoNetwork)) -> DynamicExecutor {
let (mut executor, network) = setup;
let _ = black_box(futures::executor::block_on(executor.update(black_box(network))));
// Return the executor so its teardown happens outside the measured section
executor
}
library_benchmark_group!(name = update_group; benchmarks = update_executor);