fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-09-22 04:08:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

do not update GPU buffers if data has not changed (#1967)

Browse Source 
Co-authored-by: maniarathi <mani.arathi@gmail.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
This commit is contained in:
Bruce Martin
2020-11-09 10:41:39 -08:00
committed by GitHub
co-authored by maniarathi Severiano Badajoz
parent 23714bc9f8
commit 06b88cda20
1 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/graph/graph.js
+17 -6
View File
@@ -730,14 +730,25 @@ class Graph extends React.Component {
);
});
updateReglAndRender(asyncProps) {
updateReglAndRender(asyncProps, prevAsyncProps) {
const { positions, colors, flags } = asyncProps;
this.cachedAsyncProps = asyncProps;
const { pointBuffer, colorBuffer, flagBuffer } = this.state;
pointBuffer({ data: positions, dimension: 2 });
colorBuffer({ data: colors, dimension: 3 });
flagBuffer({ data: flags, dimension: 1 });
this.renderCanvas();
let needToRenderCanvas = false;
if (positions !== prevAsyncProps?.positions) {
pointBuffer({ data: positions, dimension: 2 });
needToRenderCanvas = true;
}
if (colors !== prevAsyncProps?.colors) {
colorBuffer({ data: colors, dimension: 3 });
needToRenderCanvas = true;
}
if (flags !== prevAsyncProps?.flags) {
flagBuffer({ data: flags, dimension: 1 });
needToRenderCanvas = true;
}
if (needToRenderCanvas) this.renderCanvas();
}
updateColorTable(colors, colorDf) {
@@ -906,7 +917,7 @@ class Graph extends React.Component {
<Async.Fulfilled>
{(asyncProps) => {
if (regl && !shallowEqual(asyncProps, this.cachedAsyncProps)) {
this.updateReglAndRender(asyncProps);
this.updateReglAndRender(asyncProps, this.cachedAsyncProps);
}
return null;
}}