fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-09-15 20:57:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

protect against reference detach (#1634)

Browse Source
This commit is contained in:
Bruce Martin
2020-07-16 09:53:15 -07:00
committed by GitHub
parent 68cc0ae16c
commit 17c1145ee4
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
client/src/components/scatterplot/scatterplot.js
View File

@@ -59,6 +59,11 @@ class Scatterplot extends React.PureComponent {
/*
Must be created for each canvas
*/
// regl will create a top-level, full-screen canvas if we pass it a null.
// canvas should never be null, so protect against that.
if (!canvas) return {};
// setup canvas, webgl draw function and camera
const regl = _regl(canvas);
const drawPoints = _drawPoints(regl);
@@ -175,9 +180,12 @@ class Scatterplot extends React.PureComponent {
setReglCanvas = (canvas) => {
this.reglCanvas = canvas;
this.setState({
...Scatterplot.createReglState(canvas),
});
if (canvas) {
// no need to update this state if we are detaching.
this.setState({
...Scatterplot.createReglState(canvas),
});
}
};
getViewportDimensions = () => {