Merge pull request #148 from chanzuckerberg/bkmartinjr/getfix2

fix for _.get typo
This commit is contained in:
Colin Megill
2018-08-06 12:29:41 -04:00
committed by GitHub
5 changed files with 12 additions and 13 deletions

View File

@@ -164,7 +164,7 @@ class Category extends React.Component {
}
@connect(state => {
const ranges = _.get("state.cells.cells.data.ranges", null);
const ranges = _.get(state, "cells.cells.data.ranges", null);
return {
ranges

View File

@@ -17,9 +17,9 @@ import HistogramBrush from "./histogramBrush";
import { margin, width, height, createDimensions } from "./util";
@connect(state => {
const ranges = _.get("state.cells.cells.data.ranges", null);
const metadata = _.get("state.cells.cells.data.metadata", null);
const initializeRanges = _.get("state.initialize.data.data.ranges", null);
const ranges = _.get(state, "cells.cells.data.ranges", null);
const metadata = _.get(state, "cells.cells.data.metadata", null);
const initializeRanges = _.get(state, "initialize.data.data.ranges", null);
return {
ranges,

View File

@@ -11,7 +11,7 @@ import FaPaintBrush from "react-icons/lib/fa/paint-brush";
import * as globals from "../../globals";
@connect(state => {
const initializeRanges = _.get("state.initialize.data.data.ranges", null);
const initializeRanges = _.get(state, "initialize.data.data.ranges", null);
return {
initializeRanges,
@@ -89,8 +89,7 @@ class HistogramBrush extends React.Component {
const bins = this.histogramCache.bins;
const numValues = this.histogramCache.numValues;
d3
.select(svgRef)
d3.select(svgRef)
.insert("g", "*")
.attr("fill", "#bbb")
.selectAll("rect")

View File

@@ -15,9 +15,9 @@ import drawLinesCanvas from "./drawLinesCanvas";
import { margin, width, height, createDimensions } from "./util";
@connect(state => {
const ranges = _.get("state.cells.cells.data.ranges", null);
const metadata = _.get("state.cells.cells.data.metadata", null);
const initializeRanges = _.get("state.initialize.data.data.ranges", null);
const ranges = _.get(state, "cells.cells.data.ranges", null);
const metadata = _.get(state, "cells.cells.data.metadata", null);
const initializeRanges = _.get(state, "initialize.data.data.ranges", null);
return {
ranges,

View File

@@ -20,9 +20,9 @@ import { scaleLinear } from "../../util/scaleLinear";
import { margin, width, height, createDimensions } from "./util";
@connect(state => {
const ranges = _.get("state.cells.cells.data.ranges", null);
const metadata = _.get("state.cells.cells.data.metadata", null);
const initializeRanges = _.get("state.initialize.data.data.ranges", null);
const ranges = _.get(state, "cells.cells.data.ranges", null);
const metadata = _.get(state, "cells.cells.data.metadata", null);
const initializeRanges = _.get(state, "initialize.data.data.ranges", null);
return {
ranges,