fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-10-02 07:48:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove hash source from CSP style-src directive (#1717)

Browse Source 
* remove style csp hash generation + lint

* remove references to style_hashes
This commit is contained in:
Severiano Badajoz
2020-08-05 16:43:35 -07:00
committed by GitHub
parent b18f96da77
commit 8d96477fae
2 changed files with 20 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/configuration/webpack/cspHashPlugin.js
+12 -20
View File
@@ -1,7 +1,12 @@
/* eslint-disable import/no-extraneous-dependencies -- this file is a devDependency*/
const cheerio = require("cheerio");
const crypto = require("crypto");
HtmlWebpackPlugin = require("html-webpack-plugin");
const HtmlWebpackPlugin = require("html-webpack-plugin");
const digest = (str) => {
const hash = crypto.createHash("sha256").update(str, "utf8").digest("base64");
return `sha256-${hash}`;
};
class CspHashPlugin {
constructor(opts) {
this.opts = { ...opts };
@@ -19,10 +24,7 @@ class CspHashPlugin {
if (filename) {
const results = {};
results["script-hashes"] = $("script:not([src]):not([no-csp-hash])")
.map((i, elmt) => this.digest($(elmt).html()))
.get();
results["style-hashes"] = $("style:not([href]):not([no-csp-hash])")
.map((i, elmt) => this.digest($(elmt).html()))
.map((i, elmt) => digest($(elmt).html()))
.get();
const json = JSON.stringify(results);
@@ -34,13 +36,10 @@ class CspHashPlugin {
// Remove no-csp-hash attributes. Cheerio does not parse Jinja templates
// correctly, so we brute force this with a regular expression.
data.html = data.html
.replace(/(<script .*)no-csp-hash(.*>)/, (match, p1, p2) =>
[p1, p2].join("")
)
.replace(/(<style .*)no-csp-hash(.*>)/, (match, p1, p2) =>
[p1, p2].join("")
);
data.html = data.html.replace(
/(<script .*)no-csp-hash(.*>)/,
(match, p1, p2) => [p1, p2].join("")
);
// Tell webpack to move on
cb(null, data);
@@ -48,14 +47,7 @@ class CspHashPlugin {
);
});
}
digest(str) {
const hash = crypto
.createHash("sha256")
.update(str, "utf8")
.digest("base64");
return `sha256-${hash}`;
}
}
module.exports = CspHashPlugin;
/* eslint-enable import/no-extraneous-dependencies -- enable*/