fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-09-19 10:58:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

check for bins change for canvas draw (#1693)

Browse Source 
* check for bins change for canvas draw

* PR feedback
This commit is contained in:
Severiano Badajoz
2020-08-05 15:20:03 -07:00
committed by GitHub
parent b5e5ee0168
commit b18f96da77
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/src/components/categorical/value/index.js
View File

@@ -453,7 +453,9 @@ class CategoryValue extends React.Component {
label,
CHART_WIDTH,
VALUE_HEIGHT
) ?? {};
) ?? {}; // if createHistogramBins returns empty object assign null to deconstructed
if (!xScale || !yScale || !bins) return null;
return (
<MiniHistogram

5
client/src/components/miniHistogram/index.js
View File

@@ -40,10 +40,11 @@ export default class MiniHistogram extends React.PureComponent {
};
componentDidUpdate = (prevProps) => {
const { obsOrVarContinuousFieldDisplayName } = this.props;
const { obsOrVarContinuousFieldDisplayName, bins } = this.props;
if (
prevProps.obsOrVarContinuousFieldDisplayName !==
obsOrVarContinuousFieldDisplayName
obsOrVarContinuousFieldDisplayName ||
prevProps.bins !== bins
)
this.drawHistogram();
};