2 Commits

Author	SHA1	Message	Date
Matt Weiden	0fd3d4b8f4	Add default environment override back to common.mk (#1586) ... * As part of https://github.com/chanzuckerberg/cellxgene/pull/1548 we accidentally removed the part of the "get_or_else_dev_env_default" function that allowed users to override the environment variables. This commit adds that back. * When environment.default was changed from a shell script file to json, the shell commands used to parameterize DATASET were not evaluated. This commit fixes this issue as well.	2020-06-25 08:25:29 -07:00
Timmy Huang	83376627e8	1510-smoke-test (#1548) ... * 1510-smoke-test * config default * update tests * update test config * fix linter errors * more comments * address comments * use npm install in push_tests.yml * use environment.default.json * adding docs * Take care of @mweiden's nits * Save screenshots in the __tests__/screenshots/ directory * typo * docs * Add chart tests (#1580) * merge tests * check if bin creation returned null before rendering charts (#1576) * check if bin creation returned null before rendering charts * refactor chart rendering into functions (#1577) * little fixes from PR * reintroduce fix to check for null values * change getAllByClass to return element * slice instead * new stackedbar test * feedback-1573-test (#1579) * feedback-1573-test * enable whole test set * revert tests Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com> * tweak test to actually render chart * include snapshot * remove async * fix getAllHistograms * properly grab id Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com> Co-authored-by: Matt Weiden <538456+mweiden@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>	2020-06-24 11:45:39 -07:00