bump version

They finally fixed their cloud pickle issue

.bumpversion.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.5.0
+current_version = 0.2.4
 
 [bumpversion:file:setup.py]
 search = version="{current_version}"

.dockerignore

@@ -1,5 +0,0 @@
-bin
-client
-dist
-docs
-server

.gitignore

@@ -35,7 +35,3 @@ npm-debug.log
 __pycache__
 *.DS_Store*
 data
-
-# Jekyll
-docs/_site/
-docs/Gemfile.lock

.travis.yml

@@ -11,11 +11,10 @@ install:
   - ./bin/build-client
   - pip install -e .
   - pip install -r server/requirements-dev.txt
-  - docker build .
 script:
   - set -eo pipefail
-  - flake8 server
-  - black --check
+  - flake8 server/app/
+  - flake8 server/cli/
   - npm run --prefix client/ build
   - npm run --prefix client/ test
   - pytest -s server/test

Dockerfile

@@ -1,10 +0,0 @@
-FROM ubuntu:bionic
-
-ENV LC_ALL=C.UTF-8
-ENV LANG=C.UTF-8
-
-RUN apt-get update && \
-    apt-get install -y build-essential libxml2-dev python3-dev python3-pip zlib1g-dev && \
-    pip3 install cellxgene
-
-ENTRYPOINT ["cellxgene"]

README.md

@@ -8,8 +8,7 @@
 
 ## getting started
 
-You'll need **python 3.6** and **Google Chrome**. (_Warning_: Python 3.7 is **not** supported at this time)
-The web UI is tested on OSX and Windows using Chrome, and the python CLI is tested on OSX and Ubuntu (via WSL/Windows). It should work on other platforms, but if you run into trouble let us know (see [help](#help-and-contact) below).
+You'll need **python 3.6** and **Google Chrome**. The web UI is tested on OSX and Windows using Chrome, and the python CLI is tested on OSX and Ubuntu (via WSL/Windows). It should work on other platforms, but if you run into trouble let us know (see [help](#help-and-contact) below).
 
 To install run
 
@@ -28,7 +27,6 @@ If you want an example dataset download [this file](https://github.com/chanzucke
 ```
 cellxgene launch pbmc3k.h5ad --open
 ```
-
 You should see your web browser open with the following
 
 <img width="450" src="https://raw.githubusercontent.com/chanzuckerberg/cellxgene/master/docs/cellxgene-opening-screenshot.png" pad="50px">
@@ -37,7 +35,7 @@ You should see your web browser open with the following
 
 There are several options available, such as:
 
-- `--layout` to specify the layout as `tsne` or `umap`
+- `--layout` to specify the layout as  `tsne` or `umap`
 - `--title` to show a title on the explorer
 - `--open` to automatically open the web browser after launching (OS X only)
 
@@ -58,11 +56,11 @@ The `launch` command assumes that the data is stored in the `.h5ad` format from
 - an `obs` field has a unique identifier for every cell (you can specify which field to use with the `--obs-names` option, by default it will use the value of `data.obs_names`)
 - a `var` field has a unique identifier for every gene (you can specify which field to use with the `--var-names` option, by default it will use the value of `data.var_names`)
 - an `obsm` field contains the two-dimensional coordinates for the layout that you want to render (e.g. `X_tsne` for the `tsne` layout or `X_umap` for the `umap` layout)
-- any additional `obs` fields will be rendered as per-cell continuous or categorical metadata by the app (e.g. `louvain` cluster assignments)
+- any additional  `obs` fields will be rendered as per-cell continuous or categorical metadata by the app (e.g. `louvain` cluster assignments) 
 
 ### prepare
 
-The `prepare` command is included to help you format your data. It uses `scanpy` under the hood. This is especially useful if you are starting with raw unanalyzed data and are unfamiliar with `scanpy`.
+The `prepare` command is included to help you format your data. It uses `scanpy` under the hood. This is especially useful if you are starting with raw unanalyzed data and are unfamiliar with `scanpy`. 
 
 To prepare from an existing `.h5ad` file use
 
@@ -70,7 +68,7 @@ To prepare from an existing `.h5ad` file use
 cellxgene prepare dataset.h5ad --output=dataset-processed.h5ad
 ```
 
-This will load the input data, perform PCA and nearest neighbor calculations, compute `umap` and `tsne` layouts and `louvain` cluster assignments, and save the results in a new file called `dataset-processed.h5ad` that can be loaded using `cellxgene launch`. Data can be loaded from several formats, including `.h5ad` `.loom` and a `10-Genomics-formatted` `mtx` directory. Several options are available, including running one of the preprocessing `recipes` included with `scanpy`, which include steps like cell filtering and gene selection. To learn more about the `recipes` please see the `scanpy` [documentation](https://github.com/theislab/scanpy/blob/master/scanpy/preprocessing/recipes.py).
+This will load the input data, perform PCA and nearest neighbor calculations, compute `umap` and `tsne` layouts and `louvain` cluster assignments, and save the results in a new file called `dataset-processed.h5ad` that can be loaded using `cellxgene launch`. Data can be loaded from several formats, including `.h5ad` `.loom` and a `10-Genomics-formatted` `mtx` directory. Several options are available, including running one of the preprocessing `recipes` included with `scanpy`, which include steps like cell filtering and gene selection. 
 
 Depending on the options chosen, `prepare` can take a long time to run (a few minutes for datasets with 10-100k cells, up to an hour or more for datasets with >100k cells). If you want `prepare` to run faster we recommend using the `sparse` option and only computing the layout for `umap`, using a call like this
 
@@ -90,12 +88,6 @@ cellxgene prepare --help
 pip install cellxgene[louvain]
 ```
 
-If the aforementioned optional package installation fails, you can also install these packages directly:
-
-```
-pip install python-igraph louvain>=0.6
-```
-
 ## conda and virtual environments
 
 If you use conda and want to create a conda environment for `cellxgene` you can use the following commands
@@ -110,27 +102,13 @@ Or you can create a virtual environment by using
 
 ```
 ENV_NAME=cellxgene
-python3.6 -m venv ${ENV_NAME}
+python3 -m venv ${ENV_NAME}
 source ${ENV_NAME}/bin/activate
 pip install cellxgene
 ```
 
-## docker
-
-We have included a dockerfile to conveniently run cellxgene from docker.
-
-1. Build the image `docker build . -t cellxgene`
-2. Run the container and mount data `docker run -v "$PWD/example-dataset/:/data/" -p 5005:5005 cellxgene launch --host 0.0.0.0 data/pbmc3k.h5ad`
-   - You will need to use --host 0.0.0.0 to have the container listen to incoming requests from the browser
-
 ## FAQ
 
-<details>
-
-<summary> questions about data formatting </summary>
-  
-<hr>
-  
 > Someone sent me a directory of `10X-Genomics` data with a `mtx` file and I've never used `scanpy`, can I use `cellxgene`?
 
 Yep! This should only take a couple steps. We'll assume your data is in a folder called `data/` and you've successfully installed `cellxgene` with the `louvain` packages as described above. Just run
@@ -147,18 +125,14 @@ cellxgene launch data-processed.h5ad --layout=umap --open
 
 And your web browser should open with an interactive view of your data.
 
-<hr>
-
 > In my `prepare` command I received the following error `Warning: louvain module is not installed, no clusters will be calculated. To fix this please install cellxgene with the optional feature louvain enabled`
 
-Louvain clustering requires additional dependencies that are somewhat complex, so we don't include them by default. For now, you need to specify that you want these packages by using
+Louvain clustering requires additional dependencies that are somewhat complex, so we don't include them by default. For now, you need to specify that you want these packages by using 
 
 ```
 pip install cellxgene[louvain]
 ```
 
-<hr>
-
 > I ran `prepare` and I'm getting results that look unexpected
 
 You might want to try running one of the preprocessing recipes included with `scanpy` (read more about them [here](https://scanpy.readthedocs.io/en/latest/api/index.html#recipes)). You can specify this with the `--recipe` option, such as
@@ -169,52 +143,22 @@ cellxgene prepare data/ --output=data-processed.h5ad --recipe=zheng17
 
 It should be easy to run `prepare` then call `cellxgene launch` a few times with different settings to explore different behaviors. We may explore adding other preprocessing options in the future.
 
-<hr>
-
 > I have extra metadata that I want to add to my dataset
 
 Currently this is not supported directly, but you should be able to do this manually using `scanpy`. For example, this [notebook](https://github.com/falexwolf/fun-analyses/blob/master/tabula_muris/tabula_muris.ipynb) shows adding the contents of a `csv` file with metadata to an `anndata` object. For now, you could do this manually on your data in the same way and then save out the result before loading into `cellxgene`.
 
-<hr>
-
-> What part of the anndata objects does cellxgene pull in for visualization?
-
-- `.obs` and `.var` annotations are use to extract metadata for filtering
-- `.X` is used to display expression (histograms, scatterplot & colorscale) and to compute differential expression
-- `.obsm` is used for layout
-
-</details>
-
-<details>
-  
-<summary> questions about installing and building </summary>
-
-<hr>
-
 > I tried to `pip install cellxgene` and got a weird error I don't understand
 
 This may happen, especially as we work out bugs in our installation process! Please create a new [Github issue](https://github.com/chanzuckerberg/cellxgene/issues), explain what you did, and include all the error messages you saw. It'd also be super helpful if you call `pip freeze` and include the full output alongside your issue.
 
-<hr>
+> How are you computing and sorting differential expression results?
+
+Currently we use a [Welch's *t*-test](https://en.wikipedia.org/wiki/Welch%27s_t-test) implementation including the same variance overestimation correction as used in `scanpy`. We sort the `tscore` to identify the top N genes, and then filter to remove any that fall below a cutoff log fold change value, which can help remove spurious test results. The default threshold is `0.01` and can be changed using the option `--diffexp-lfc-cutoff`. We can explore adding support for other test types in the future.
 
 > I'm following the developer instructions and get an error about "missing files and directories” when trying to build the client
 
 This is likely because you do not have node and npm installed, we recommend using [nvm](https://github.com/creationix/nvm) if you're new to using these tools.
 
-</details>
-
-<details>
-
-<summary> questions about algorithms </summary>
-
-<hr>
-
-> How are you computing and sorting differential expression results?
-
-Currently we use a [Welch's _t_-test](https://en.wikipedia.org/wiki/Welch%27s_t-test) implementation including the same variance overestimation correction as used in `scanpy`. We sort the `tscore` to identify the top N genes, and then filter to remove any that fall below a cutoff log fold change value, which can help remove spurious test results. The default threshold is `0.01` and can be changed using the option `--diffexp-lfc-cutoff`. We can explore adding support for other test types in the future.
-
-</details>
-
 ## developer guide
 
 This project has made a few key design choices
@@ -250,15 +194,15 @@ pip install -e .
 
 You can start the app while developing either by calling `cellxgene` or by calling `python -m server`. We recommend using the `--debug` flag to see more output, which you can include when reporting bugs.
 
-If you have any questions about developing or contributing, come hang out with us by joining the [CZI Science Slack](https://join-cellxgene-users.herokuapp.com/) and posting in the `#cellxgene-dev` channel.
+If you have any questions about developing or contributing, come hang out with us by joining the [CZI Science Slack](https://cziscience.slack.com/messages/CCTA8DF1T) and posting in the `#cellxgene-dev` channel.
 
 ## development roadmap
 
-`cellxgene` is still very much in development, and we've love to include the community as we plan new features to work on. We are thinking about working on the following features over the next 3-12 months. If you are interested in updates, want to give feedback, want to contribute, or have ideas about other features we should work on, please [contact us](#help-and-contact)
+`cellxgene` is still very much in development, and we've love to include the community as we plan new features to work on. We are thinking about working on the following features over the next 3-12 months. If you are interested in updates, want to give feedback, want to contribute, or have ideas about other features we should work on, please [contact us](#help-and-contact) 
 
 - **Visualizaling spatial metadata** Image-based transcriptomics methods also generate large cell by gene matrices, alongside rich metadata about spatial location; we would like to render this information in `cellxgene`
-- **Visualizing trajectories** Trajectory analyses infer progression along some ordering or pseudotime; we would like `cellxgene` to render the results of these analyses when they have been performed
-- **Deploy to web** Many projects release public data browser websites alongside their publicatons; we would like to make it easy for anyone to deploy `cellxgene` to a custom URL with their own dataset that they own and operate
+- **Visualizing trajectories** Trajectory analyses infer progression along some ordering or pseudotime; we would like `cellxgene ` to render the results of these analyses when they have been performed
+- **Deploy to web**  Many projects release public data browser websites  alongside their publicatons; we would like to make it easy for anyone to deploy `cellxgene` to a custom URL with their own dataset that they own and operate
 - **HCA Integration** The [Human Cell Atlas](https://humancellatlas.org) is generating a large corpus of single-cell expression data and will make it available through the Data Coordination Platform; we would like `cellxgene` to be one of several different portals for browsing these data
 
 ## contributing
@@ -271,13 +215,13 @@ We've been heavily inspired by several other related single-cell visualization p
 
 We were inspired by Mike Bostock and the [crossfilter](https://github.com/crossfilter) team for the design of our filtering implementation.
 
-We have been working closely with the [`scanpy`](https://github.com/theislab/scanpy) team to integrate with their awesome analysis tools. Special thanks to Alex Wolf, Fabian Theis, and the rest of the team for their help during development and for providing an example dataset.
+We have been working closely with the [`scanpy`](https://github.com/theislab/scanpy) team to integrate with their awesome analysis tools. Special thanks to Alex Wolf, Fabian Theis, and the rest of the team for their help during development and for providing an example dataset. 
 
 We are eager to explore integrations with other computational backends such as [`Seurat`](https://github.com/satijalab/seurat) or [`Bioconductor`](https://github.com/Bioconductor)
 
 ## help and contact
 
-Have questions, suggestions, or comments? You can come hang out with us by joining the [CZI Science Slack](https://join-cellxgene-users.herokuapp.com/) and posting in the `#cellxgene-users` channel. As mentioned above, please submit any feature requests or bugs as [Github issues](https://github.com/chanzuckerberg/cellxgene/issues). We'd love to hear from you!
+Have questions, suggestions, or comments? You can come hang out with us by joining the [CZI Science Slack](https://cziscience.slack.com/messages/CCTA8DF1T) and posting in the `#cellxgene-users` channel. As mentioned above, please submit any feature requests or bugs as [Github issues](https://github.com/chanzuckerberg/cellxgene/issues). We'd love to hear from you!
 
 ## reuse
 

client/__tests__/setupMissingGlobals.js

@@ -1,9 +0,0 @@
-/*
-Define globals which are present in the client, but not in node (and therefore not in
-the jest test environment).
-*/
-
-import { TextDecoder, TextEncoder } from "util";
-
-global.TextDecoder = TextDecoder;
-global.TextEncoder = TextEncoder;

client/__tests__/util/stateManager/sampleResponses.js

@@ -1,7 +1,5 @@
 /* eslint no-bitwise: "off" */
 import _ from "lodash";
-import { flatbuffers } from "flatbuffers";
-import { NetEncoding } from "../../../src/util/stateManager/matrix_generated";
 
 /*
 test data mocking REST 0.2 API responses.  Used in several tests.
@@ -60,7 +58,7 @@ const aSchemaResponse = {
   }
 };
 
-const anAnnotationsObsJSONResponse = {
+const anAnnotationsObsResponse = {
   names: ["name", "field1", "field2", "field3", "field4"],
   data: _()
     .range(nObs)
@@ -75,7 +73,7 @@ const anAnnotationsObsJSONResponse = {
     .value()
 };
 
-const anAnnotationsVarJSONResponse = {
+const anAnnotationsVarResponse = {
   names: ["fieldA", "fieldB", "fieldC", "fieldD", "name"],
   data: _()
     .range(nVar)
@@ -90,74 +88,7 @@ const anAnnotationsVarJSONResponse = {
     .value()
 };
 
-function encodeTypedArray(builder, uType, uData) {
-  const uTypeName = NetEncoding.TypedArray[uType];
-  const ArrayType = NetEncoding[uTypeName];
-  const dv = ArrayType.createDataVector(builder, uData);
-  builder.startObject(1);
-  builder.addFieldOffset(0, dv, 0);
-  return builder.endObject();
-}
-
-function encodeMatrix(columns, colIndex = undefined) {
-  const utf8Encoder = new TextEncoder("utf-8");
-  const builder = new flatbuffers.Builder(1024);
-  const cols = _.map(columns, carr => {
-    let uType;
-    let tarr;
-    if (_.every(carr, _.isNumber)) {
-      uType = NetEncoding.TypedArray.Float32Array;
-      tarr = encodeTypedArray(builder, uType, new Float32Array(carr));
-    } else {
-      uType = NetEncoding.TypedArray.JSONEncodedArray;
-      const json = JSON.stringify(carr);
-      const jsonUTF8 = utf8Encoder.encode(json);
-      tarr = encodeTypedArray(builder, uType, jsonUTF8);
-    }
-    NetEncoding.Column.startColumn(builder);
-    NetEncoding.Column.addUType(builder, uType);
-    NetEncoding.Column.addU(builder, tarr);
-    return NetEncoding.Column.endColumn(builder);
-  });
-
-  const encColumns = NetEncoding.Matrix.createColumnsVector(builder, cols);
-
-  let encColIndex;
-  if (colIndex) {
-    encColIndex = encodeTypedArray(
-      builder,
-      NetEncoding.TypedArray.JSONEncodedArray,
-      utf8Encoder.encode(JSON.stringify(colIndex))
-    );
-  }
-
-  NetEncoding.Matrix.startMatrix(builder);
-  NetEncoding.Matrix.addNRows(builder, columns[0].length);
-  NetEncoding.Matrix.addNCols(builder, columns.length);
-  NetEncoding.Matrix.addColumns(builder, encColumns);
-  if (colIndex) {
-    NetEncoding.Matrix.addColIndexType(
-      builder,
-      NetEncoding.TypedArray.JSONEncodedArray
-    );
-    NetEncoding.Matrix.addColIndex(builder, encColIndex);
-  }
-  const root = NetEncoding.Matrix.endMatrix(builder);
-  builder.finish(root);
-  return builder.asUint8Array();
-}
-
-const anAnnotationsObsFBSResponse = (() => {
-  const columns = _.zip(...anAnnotationsObsJSONResponse.data).slice(1);
-  return encodeMatrix(columns, anAnnotationsObsJSONResponse.names);
-})();
-
-const anAnnotationsVarFBSResponse = (() => {
-  const columns = _.zip(...anAnnotationsVarJSONResponse.data).slice(1);
-  return encodeMatrix(columns, anAnnotationsVarJSONResponse.names);
-})();
-
-const aLayoutJSONResponse = {
+const aLayoutResponse = {
   layout: {
     ndims: 2,
     coordinates: _()
@@ -167,36 +98,6 @@ const aLayoutJSONResponse = {
   }
 };
 
-const aLayoutFBSResponse = (() => {
-  const coords = [
-    new Float32Array(nObs).fill(Math.random()),
-    new Float32Array(nObs).fill(Math.random())
-  ];
-  const builder = new flatbuffers.Builder(1024);
-
-  const cols = _.map(coords, carr => {
-    const cdv = NetEncoding.Float32Array.createDataVector(builder, carr);
-    NetEncoding.Float32Array.startFloat32Array(builder);
-    NetEncoding.Float32Array.addData(builder, cdv);
-    const floatArr = NetEncoding.Float32Array.endFloat32Array(builder);
-
-    NetEncoding.Column.startColumn(builder);
-    NetEncoding.Column.addUType(builder, NetEncoding.TypedArray.Float32Array);
-    NetEncoding.Column.addU(builder, floatArr);
-    return NetEncoding.Column.endColumn(builder);
-  });
-
-  const columns = NetEncoding.Matrix.createColumnsVector(builder, cols);
-
-  NetEncoding.Matrix.startMatrix(builder);
-  NetEncoding.Matrix.addNRows(builder, nObs);
-  NetEncoding.Matrix.addNCols(builder, nVar);
-  NetEncoding.Matrix.addColumns(builder, columns);
-  const matrix = NetEncoding.Matrix.endMatrix(builder);
-  builder.finish(matrix);
-  return builder.asUint8Array();
-})();
-
 const aDataObsResponse = {
   var: [2, 4, 29],
   obs: _()
@@ -206,10 +107,10 @@ const aDataObsResponse = {
 };
 
 export {
-  aLayoutFBSResponse as layoutObs,
+  aLayoutResponse as layoutObs,
   aDataObsResponse as dataObs,
-  anAnnotationsVarFBSResponse as annotationsVar,
-  anAnnotationsObsFBSResponse as annotationsObs,
+  anAnnotationsVarResponse as annotationsVar,
+  anAnnotationsObsResponse as annotationsObs,
   aSchemaResponse as schema,
   aConfigResponse as config
 };

client/__tests__/util/stateManager/summarizeAnnotations.test.js

@@ -1,280 +0,0 @@
-import summarizeAnnotations from "../../../src/util/stateManager/summarizeAnnotations";
-
-describe("summarizeAnnotations", () => {
-  const schema = {
-    annotations: {
-      obs: [
-        { name: "name", type: "string" },
-        { name: "nameString", type: "string" },
-        { name: "nameBoolean", type: "boolean" },
-        { name: "nameFloat32", type: "float32" },
-        { name: "nameInt32", type: "int32" },
-        {
-          name: "nameCategorical",
-          type: "categorical",
-          categories: [true, false, 1, 0, 0.00001, 4383.4833, "test", "", "0"]
-        }
-      ],
-      var: [{ name: "name", type: "string" }]
-    }
-  };
-
-  test("empty test", () => {
-    const summary = summarizeAnnotations(schema, [], []);
-    expect(summary).toEqual(
-      expect.objectContaining({
-        obs: {
-          nameString: {
-            categorical: true,
-            categories: [],
-            categoryCounts: new Map(),
-            numCategories: 0
-          },
-          nameBoolean: {
-            categorical: true,
-            categories: [],
-            categoryCounts: new Map(),
-            numCategories: 0
-          },
-          nameFloat32: {
-            categorical: false,
-            range: {
-              max: undefined,
-              min: undefined,
-              nan: 0,
-              ninf: 0,
-              pinf: 0
-            }
-          },
-          nameInt32: {
-            categorical: false,
-            range: {
-              max: undefined,
-              min: undefined,
-              nan: 0,
-              ninf: 0,
-              pinf: 0
-            }
-          },
-          nameCategorical: {
-            categorical: true,
-            categories: [],
-            categoryCounts: new Map(),
-            numCategories: 0
-          }
-        },
-        var: {}
-      })
-    );
-  });
-
-  test("simple test", () => {
-    const obsAnnotations = [
-      {
-        __index__: 0,
-        name: "n1",
-        nameString: "hi",
-        nameBoolean: true,
-        nameFloat32: 39.3,
-        nameInt32: 99,
-        nameCategorical: 1
-      }
-    ];
-    const varAnnotations = [];
-
-    const summary = summarizeAnnotations(
-      schema,
-      obsAnnotations,
-      varAnnotations
-    );
-
-    expect(summary).toEqual(
-      expect.objectContaining({
-        obs: {
-          nameString: {
-            categorical: true,
-            categories: ["hi"],
-            categoryCounts: new Map([["hi", 1]]),
-            numCategories: 1
-          },
-          nameBoolean: {
-            categorical: true,
-            categories: [true],
-            categoryCounts: new Map([[true, 1]]),
-            numCategories: 1
-          },
-          nameFloat32: {
-            categorical: false,
-            range: { min: 39.3, max: 39.3, nan: 0, ninf: 0, pinf: 0 }
-          },
-          nameInt32: {
-            categorical: false,
-            range: { min: 99, max: 99, nan: 0, ninf: 0, pinf: 0 }
-          },
-          nameCategorical: {
-            categorical: true,
-            categories: [1],
-            categoryCounts: new Map([[1, 1]]),
-            numCategories: 1
-          }
-        },
-        var: {}
-      })
-    );
-  });
-
-  test("multi test", () => {
-    const obsAnnotations = [
-      {
-        __index__: 0,
-        name: "n0",
-        nameString: "hi",
-        nameBoolean: false,
-        nameFloat32: 39.3,
-        nameInt32: 99,
-        nameCategorical: 1
-      },
-      {
-        __index__: 1,
-        name: "n1",
-        nameString: "hi",
-        nameBoolean: true,
-        nameFloat32: 39.3,
-        nameInt32: 99,
-        nameCategorical: false
-      },
-      {
-        __index__: 2,
-        name: "n2",
-        nameString: "bye",
-        nameBoolean: true,
-        nameFloat32: 0,
-        nameInt32: 99,
-        nameCategorical: "0"
-      }
-    ];
-    const varAnnotations = [];
-
-    const summary = summarizeAnnotations(
-      schema,
-      obsAnnotations,
-      varAnnotations
-    );
-
-    expect(summary).toMatchObject(
-      expect.objectContaining({
-        obs: {
-          nameString: {
-            categorical: true,
-            categories: expect.arrayContaining(["hi", "bye"]),
-            categoryCounts: new Map([["hi", 2], ["bye", 1]]),
-            numCategories: 2
-          },
-          nameBoolean: {
-            categorical: true,
-            categories: expect.arrayContaining([true, false]),
-            categoryCounts: new Map([[true, 2], [false, 1]]),
-            numCategories: 2
-          },
-          nameFloat32: {
-            categorical: false,
-            range: { min: 0, max: 39.3, nan: 0, ninf: 0, pinf: 0 }
-          },
-          nameInt32: {
-            categorical: false,
-            range: { min: 99, max: 99, nan: 0, ninf: 0, pinf: 0 }
-          },
-          nameCategorical: {
-            categorical: true,
-            categories: expect.arrayContaining([1, false, "0"]),
-            categoryCounts: new Map([[1, 1], [false, 1], ["0", 1]]),
-            numCategories: 3
-          }
-        },
-        var: {}
-      })
-    );
-  });
-
-  test("non-finite numbers", () => {
-    const obsAnnotations = [
-      {
-        __index__: 0,
-        name: "n0",
-        nameString: "hi",
-        nameBoolean: false,
-        nameFloat32: 39.3,
-        nameInt32: 99,
-        nameCategorical: 1
-      },
-      {
-        __index__: 1,
-        name: "n1",
-        nameString: "hi",
-        nameBoolean: true,
-        nameFloat32: Number.NEGATIVE_INFINITY,
-        nameInt32: 99,
-        nameCategorical: false
-      },
-      {
-        __index__: 2,
-        name: "n2",
-        nameString: "bye",
-        nameBoolean: true,
-        nameFloat32: Number.NaN,
-        nameInt32: 99,
-        nameCategorical: "0"
-      },
-      {
-        __index__: 3,
-        name: "n2",
-        nameString: "bye",
-        nameBoolean: true,
-        nameFloat32: Number.POSITIVE_INFINITY,
-        nameInt32: 99,
-        nameCategorical: "0"
-      }
-    ];
-    const varAnnotations = [];
-
-    const summary = summarizeAnnotations(
-      schema,
-      obsAnnotations,
-      varAnnotations
-    );
-
-    expect(summary).toMatchObject(
-      expect.objectContaining({
-        obs: {
-          nameString: {
-            categorical: true,
-            categories: expect.arrayContaining(["hi", "bye"]),
-            categoryCounts: new Map([["hi", 2], ["bye", 1]]),
-            numCategories: 2
-          },
-          nameBoolean: {
-            categorical: true,
-            categories: expect.arrayContaining([true, false]),
-            categoryCounts: new Map([[true, 2], [false, 1]]),
-            numCategories: 2
-          },
-          nameFloat32: {
-            categorical: false,
-            range: { min: 39.3, max: 39.3, nan: 1, ninf: 1, pinf: 1 }
-          },
-          nameInt32: {
-            categorical: false,
-            range: { min: 99, max: 99, nan: 0, ninf: 0, pinf: 0 }
-          },
-          nameCategorical: {
-            categorical: true,
-            categories: expect.arrayContaining([1, false, "0"]),
-            categoryCounts: new Map([[1, 1], [false, 1], ["0", 1]]),
-            numCategories: 3
-          }
-        },
-        var: {}
-      })
-    );
-  });
-});

client/__tests__/util/stateManager/universe.test.js

@@ -30,6 +30,7 @@ describe("createUniverseFromRestV02Response", () => {
     create a universe from sample data nad validate its shape & contents
     */
     const { nObs, nVar } = REST.schema.schema.dataframe;
+
     const universe = Universe.createUniverseFromRestV02Response(
       REST.config,
       REST.schema,
@@ -65,3 +66,56 @@ describe("createUniverseFromRestV02Response", () => {
     expect(_.keys(universe.varNameToIndexMap)).toHaveLength(nVar);
   });
 });
+
+describe("convertExpressionRESTv02ToObject", () => {
+  /*
+  test convertExpressionRESTv02ToObject
+
+  convertExpressionRESTv02ToObject(
+    universe,
+    response) --> { geneName: Float32Array, geneName: Float32Array, ... }
+
+  reponse is a /data/obs response:
+  {
+    var: [ varIndices fetched ],
+    obs: [
+      [ obsIndex, evalue, ... ],
+      ...
+    ]
+  }
+  */
+  test("create from response data", () => {
+    const universe = Universe.createUniverseFromRestV02Response(
+      REST.config,
+      REST.schema,
+      REST.annotationsObs,
+      REST.annotationsVar,
+      REST.layoutObs
+    );
+    const expression = Universe.convertExpressionRESTv02ToObject(
+      universe,
+      REST.dataObs
+    );
+
+    /* Check that the expected keys are present */
+    const expectedGeneNames = _.map(
+      REST.dataObs.var,
+      v => REST.annotationsVar.data[v][5]
+    );
+    expect(Object.keys(expression)).toEqual(
+      expect.arrayContaining(expectedGeneNames)
+    );
+
+    const expectedExpressionValues = _.map(
+      _.unzip(REST.dataObs.obs),
+      a => new Float32Array(a)
+    );
+
+    _.forEach(REST.dataObs.var, (varIdx, idx) => {
+      const varName = universe.varAnnotations[varIdx].name;
+      expect(varName).toBeDefined();
+      expect(varIdx).toBe(universe.varNameToIndexMap[varName]);
+      expect(expression[varName]).toEqual(expectedExpressionValues[idx + 1]);
+    });
+  });
+});

client/__tests__/util/stateManager/world.test.js

@@ -168,13 +168,10 @@ describe("createObsDimensionMap", () => {
     */
 
     const { dimensionMap } = defaultBigBang();
-    const annotationNames = _.map(
-      REST.schema.schema.annotations.obs,
-      c => c.name
-    );
+
     const schemaByObsName = _.keyBy(REST.schema.schema.annotations.obs, "name");
     expect(dimensionMap).toBeDefined();
-    annotationNames.forEach(name => {
+    REST.annotationsObs.names.forEach(name => {
       const dim = dimensionMap[obsAnnoDimensionName(name)];
       if (name === "name") {
         expect(dim).toBeUndefined();

client/__tests__/util/stateManager/worldUtil.test.js

@@ -1,45 +0,0 @@
-import {
-  countCategoryValues2D,
-  clearCaches
-} from "../../../src/util/stateManager/worldUtil";
-
-describe("WorldUtil cache management", () => {
-  test("empty", () => {
-    const count = countCategoryValues2D("a", "b", []);
-    expect(count).toMatchObject(new Map());
-  });
-
-  test("simple couts", () => {
-    const rows = [{ a: 0, b: false }, { a: 0, b: true }, { a: 1, b: false }];
-    const count = countCategoryValues2D("a", "b", rows);
-    expect(count).toMatchObject(
-      new Map([
-        [0, new Map([[true, 1], [false, 1]])],
-        [1, new Map([[false, 1]])]
-      ])
-    );
-  });
-
-  test("memo cache clear", () => {
-    clearCaches();
-    const row1 = [];
-    const row2 = [{ a: 0, b: false }, { a: 0, b: true }, { a: 1, b: false }];
-    const count1 = countCategoryValues2D("a", "b", row1);
-    const count2 = countCategoryValues2D("a", "b", row1);
-    const count3 = countCategoryValues2D("a", "b", []);
-    const count4 = countCategoryValues2D("a", "b", row2);
-
-    clearCaches();
-    const count10 = countCategoryValues2D("a", "b", row1);
-    const count11 = countCategoryValues2D("a", "b", row2);
-
-    expect(count1).toEqual(count2);
-    expect(count1).toEqual(count3);
-    expect(count1).toEqual(count10);
-    expect(count1).not.toBe(count3);
-    expect(count1).not.toBe(count10);
-
-    expect(count4).toEqual(count11);
-    expect(count4).not.toBe(count11);
-  });
-});

client/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "cellxgene",
-  "version": "0.5.0",
+  "version": "0.2.4",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
@@ -2194,7 +2194,7 @@
     },
     "babel-plugin-syntax-object-rest-spread": {
       "version": "6.13.0",
-      "resolved": "https://registry.npmjs.org/babel-plugin-syntax-object-rest-spread/-/babel-plugin-syntax-object-rest-spread-6.13.0.tgz",
+      "resolved": "http://registry.npmjs.org/babel-plugin-syntax-object-rest-spread/-/babel-plugin-syntax-object-rest-spread-6.13.0.tgz",
       "integrity": "sha1-/WU28rzhODb/o6VFjEkDpZe7O/U=",
       "dev": true
     },
@@ -2627,7 +2627,7 @@
     },
     "browserify-aes": {
       "version": "1.2.0",
-      "resolved": "https://registry.npmjs.org/browserify-aes/-/browserify-aes-1.2.0.tgz",
+      "resolved": "http://registry.npmjs.org/browserify-aes/-/browserify-aes-1.2.0.tgz",
       "integrity": "sha512-+7CHXqGuspUn/Sl5aO7Ea0xWGAtETPXNSAjHo48JfLdPWcMng33Xe4znFvQweqc/uzk5zSOI3H52CYnjCfb5hA==",
       "dev": true,
       "requires": {
@@ -2664,7 +2664,7 @@
     },
     "browserify-rsa": {
       "version": "4.0.1",
-      "resolved": "https://registry.npmjs.org/browserify-rsa/-/browserify-rsa-4.0.1.tgz",
+      "resolved": "http://registry.npmjs.org/browserify-rsa/-/browserify-rsa-4.0.1.tgz",
       "integrity": "sha1-IeCr+vbyApzy+vsTNWenAdQTVSQ=",
       "dev": true,
       "requires": {
@@ -2718,7 +2718,7 @@
     },
     "buffer": {
       "version": "4.9.1",
-      "resolved": "https://registry.npmjs.org/buffer/-/buffer-4.9.1.tgz",
+      "resolved": "http://registry.npmjs.org/buffer/-/buffer-4.9.1.tgz",
       "integrity": "sha1-bRu2AbB6TvztlwlBMgkwJ8lbwpg=",
       "dev": true,
       "requires": {
@@ -3394,7 +3394,7 @@
     },
     "create-hash": {
       "version": "1.2.0",
-      "resolved": "https://registry.npmjs.org/create-hash/-/create-hash-1.2.0.tgz",
+      "resolved": "http://registry.npmjs.org/create-hash/-/create-hash-1.2.0.tgz",
       "integrity": "sha512-z00bCGNHDG8mHAkP7CtT1qVu+bFQUPjYq/4Iv3C3kWjTFV10zIjfSoeqXo9Asws8gwSHDGj/hl2u4OGIjapeCg==",
       "dev": true,
       "requires": {
@@ -3407,7 +3407,7 @@
     },
     "create-hmac": {
       "version": "1.1.7",
-      "resolved": "https://registry.npmjs.org/create-hmac/-/create-hmac-1.1.7.tgz",
+      "resolved": "http://registry.npmjs.org/create-hmac/-/create-hmac-1.1.7.tgz",
       "integrity": "sha512-MJG9liiZ+ogc4TzUwuvbER1JRdgvUFSB5+VR/g5h82fGaIRWMWddtKBHi7/sVhfjQZ6SehlyhvQYrcYkaUIpLg==",
       "dev": true,
       "requires": {
@@ -4090,7 +4090,7 @@
     },
     "diffie-hellman": {
       "version": "5.0.3",
-      "resolved": "https://registry.npmjs.org/diffie-hellman/-/diffie-hellman-5.0.3.tgz",
+      "resolved": "http://registry.npmjs.org/diffie-hellman/-/diffie-hellman-5.0.3.tgz",
       "integrity": "sha512-kqag/Nl+f3GwyK25fhUMYj81BUOrZ9IuJsjIcDE5icNM9FJHAVm3VcUDxdLPoQtTuUylWm6ZIknYJwwaPxsUzg==",
       "dev": true,
       "requires": {
@@ -4705,7 +4705,7 @@
         },
         "load-json-file": {
           "version": "2.0.0",
-          "resolved": "https://registry.npmjs.org/load-json-file/-/load-json-file-2.0.0.tgz",
+          "resolved": "http://registry.npmjs.org/load-json-file/-/load-json-file-2.0.0.tgz",
           "integrity": "sha1-eUfkIUmvgNaWy/eXvKq8/h/inKg=",
           "dev": true,
           "requires": {
@@ -4891,7 +4891,7 @@
     },
     "events": {
       "version": "1.1.1",
-      "resolved": "https://registry.npmjs.org/events/-/events-1.1.1.tgz",
+      "resolved": "http://registry.npmjs.org/events/-/events-1.1.1.tgz",
       "integrity": "sha1-nr23Y1rQmccNzEwqH1AEKI6L2SQ="
     },
     "evp_bytestokey": {
@@ -5202,22 +5202,11 @@
         "randomatic": "^3.0.0",
         "repeat-element": "^1.1.2",
         "repeat-string": "^1.5.2"
-      },
-      "dependencies": {
-        "is-number": {
-          "version": "2.1.0",
-          "resolved": "https://registry.npmjs.org/is-number/-/is-number-2.1.0.tgz",
-          "integrity": "sha1-Afy7s5NGOlSPL0ZszhbezknbkI8=",
-          "dev": true,
-          "requires": {
-            "kind-of": "^3.0.2"
-          }
-        }
       }
     },
     "finalhandler": {
       "version": "1.1.1",
-      "resolved": "https://registry.npmjs.org/finalhandler/-/finalhandler-1.1.1.tgz",
+      "resolved": "http://registry.npmjs.org/finalhandler/-/finalhandler-1.1.1.tgz",
       "integrity": "sha512-Y1GUDo39ez4aHAw7MysnUD5JzYX+WaIj8I57kO3aEPT1fFRL4sr7mjei97FgnwhAyyzRYmQZaTHb2+9uZ1dPtg==",
       "dev": true,
       "requires": {
@@ -5279,11 +5268,6 @@
         "write": "^0.2.1"
       }
     },
-    "flatbuffers": {
-      "version": "1.10.2",
-      "resolved": "https://registry.npmjs.org/flatbuffers/-/flatbuffers-1.10.2.tgz",
-      "integrity": "sha512-VK7lHZF/corkykjXZ0+dqViI8Wk1YpwPCFN2wrnTs+PMCMG5+uHRvkRW14fuA7Smkhkgx+Dj5UdS3YXktJL+qw=="
-    },
     "flatted": {
       "version": "2.0.0",
       "resolved": "https://registry.npmjs.org/flatted/-/flatted-2.0.0.tgz",
@@ -5938,11 +5922,6 @@
       "integrity": "sha1-GwqzvVU7Kg1jmdKcDj6gslIHgyc=",
       "dev": true
     },
-    "fuzzysort": {
-      "version": "1.1.4",
-      "resolved": "https://registry.npmjs.org/fuzzysort/-/fuzzysort-1.1.4.tgz",
-      "integrity": "sha512-JzK/lHjVZ6joAg3OnCjylwYXYVjRiwTY6Yb25LvfpJHK8bjisfnZJ5bY8aVWwTwCXgxPNgLAtmHL+Hs5q1ddLQ=="
-    },
     "get-caller-file": {
       "version": "1.0.3",
       "resolved": "https://registry.npmjs.org/get-caller-file/-/get-caller-file-1.0.3.tgz",
@@ -5957,7 +5936,7 @@
     },
     "get-stream": {
       "version": "3.0.0",
-      "resolved": "https://registry.npmjs.org/get-stream/-/get-stream-3.0.0.tgz",
+      "resolved": "http://registry.npmjs.org/get-stream/-/get-stream-3.0.0.tgz",
       "integrity": "sha1-jpQ9E1jcN1VQVOy+LtsFqhdO3hQ=",
       "dev": true
     },
@@ -6344,7 +6323,7 @@
     },
     "html-webpack-plugin": {
       "version": "3.2.0",
-      "resolved": "https://registry.npmjs.org/html-webpack-plugin/-/html-webpack-plugin-3.2.0.tgz",
+      "resolved": "http://registry.npmjs.org/html-webpack-plugin/-/html-webpack-plugin-3.2.0.tgz",
       "integrity": "sha1-sBq71yOsqqeze2r0SS69oD2d03s=",
       "dev": true,
       "requires": {
@@ -6420,7 +6399,7 @@
     },
     "http-errors": {
       "version": "1.6.3",
-      "resolved": "https://registry.npmjs.org/http-errors/-/http-errors-1.6.3.tgz",
+      "resolved": "http://registry.npmjs.org/http-errors/-/http-errors-1.6.3.tgz",
       "integrity": "sha1-i1VoC7S+KDoLW/TqLjhYC+HZMg0=",
       "dev": true,
       "requires": {
@@ -6643,7 +6622,7 @@
     },
     "is-builtin-module": {
       "version": "1.0.0",
-      "resolved": "https://registry.npmjs.org/is-builtin-module/-/is-builtin-module-1.0.0.tgz",
+      "resolved": "http://registry.npmjs.org/is-builtin-module/-/is-builtin-module-1.0.0.tgz",
       "integrity": "sha1-VAVy0096wxGfj3bDDLwbHgN6/74=",
       "dev": true,
       "requires": {
@@ -6773,9 +6752,13 @@
       "dev": true
     },
     "is-number": {
-      "version": "7.0.0",
-      "resolved": "https://registry.npmjs.org/is-number/-/is-number-7.0.0.tgz",
-      "integrity": "sha512-41Cifkg6e8TylSpdtTpeLVMqvSBEVzTttHvERD741+pnZ8ANv0004MRL43QKPDlK9cGvNp6NZWZUBlbGXYxxng=="
+      "version": "2.1.0",
+      "resolved": "https://registry.npmjs.org/is-number/-/is-number-2.1.0.tgz",
+      "integrity": "sha1-Afy7s5NGOlSPL0ZszhbezknbkI8=",
+      "dev": true,
+      "requires": {
+        "kind-of": "^3.0.2"
+      }
     },
     "is-obj": {
       "version": "1.0.1",
@@ -7646,7 +7629,7 @@
     },
     "json5": {
       "version": "0.5.1",
-      "resolved": "https://registry.npmjs.org/json5/-/json5-0.5.1.tgz",
+      "resolved": "http://registry.npmjs.org/json5/-/json5-0.5.1.tgz",
       "integrity": "sha1-Hq3nrMASA0rYTiOWdn6tn6VJWCE=",
       "dev": true
     },
@@ -7736,7 +7719,7 @@
     },
     "load-json-file": {
       "version": "1.1.0",
-      "resolved": "https://registry.npmjs.org/load-json-file/-/load-json-file-1.1.0.tgz",
+      "resolved": "http://registry.npmjs.org/load-json-file/-/load-json-file-1.1.0.tgz",
       "integrity": "sha1-lWkFcI1YtLq0wiYbBPWfMcmTdMA=",
       "dev": true,
       "requires": {
@@ -8060,7 +8043,7 @@
       "dependencies": {
         "minimist": {
           "version": "1.2.0",
-          "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
+          "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
           "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=",
           "dev": true
         }
@@ -8185,7 +8168,7 @@
     },
     "minimist": {
       "version": "0.0.8",
-      "resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz",
+      "resolved": "http://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz",
       "integrity": "sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=",
       "dev": true
     },
@@ -8230,7 +8213,7 @@
     },
     "mkdirp": {
       "version": "0.5.1",
-      "resolved": "https://registry.npmjs.org/mkdirp/-/mkdirp-0.5.1.tgz",
+      "resolved": "http://registry.npmjs.org/mkdirp/-/mkdirp-0.5.1.tgz",
       "integrity": "sha1-MAV0OOrGz3+MR2fzhkjWaX11yQM=",
       "dev": true,
       "requires": {
@@ -9956,7 +9939,7 @@
     },
     "parse-asn1": {
       "version": "5.1.1",
-      "resolved": "https://registry.npmjs.org/parse-asn1/-/parse-asn1-5.1.1.tgz",
+      "resolved": "http://registry.npmjs.org/parse-asn1/-/parse-asn1-5.1.1.tgz",
       "integrity": "sha512-KPx7flKXg775zZpnp9SxJlz00gTd4BmJ2yJufSc44gMCRrRQ7NSzAcSJQfifuOLgW6bEi+ftrALtsgALeB2Adw==",
       "dev": true,
       "requires": {
@@ -10664,7 +10647,7 @@
     },
     "readable-stream": {
       "version": "2.3.6",
-      "resolved": "https://registry.npmjs.org/readable-stream/-/readable-stream-2.3.6.tgz",
+      "resolved": "http://registry.npmjs.org/readable-stream/-/readable-stream-2.3.6.tgz",
       "integrity": "sha512-tQtKA9WIAhBF3+VLAseyMqZeBjW0AHJoxOtYqSUZNJxauErmLbVm2FW1y+J/YA9dUrAC39ITejlZWhVIwawkKw==",
       "dev": true,
       "requires": {
@@ -11686,7 +11669,7 @@
         },
         "minimist": {
           "version": "1.2.0",
-          "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
+          "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
           "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=",
           "dev": true
         },
@@ -11873,7 +11856,7 @@
     },
     "sha.js": {
       "version": "2.4.11",
-      "resolved": "https://registry.npmjs.org/sha.js/-/sha.js-2.4.11.tgz",
+      "resolved": "http://registry.npmjs.org/sha.js/-/sha.js-2.4.11.tgz",
       "integrity": "sha512-QMEp5B7cftE7APOjk5Y6xgrbWu+WkLVQwk8JNjZ8nKRciZaByEW6MubieAiToS7+dwvrjGhH8jRXz3MVd0AYqQ==",
       "dev": true,
       "requires": {
@@ -12327,7 +12310,7 @@
     },
     "strip-ansi": {
       "version": "3.0.1",
-      "resolved": "https://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz",
+      "resolved": "http://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz",
       "integrity": "sha1-ajhfuIU9lS1f8F0Oiq+UJ43GPc8=",
       "dev": true,
       "requires": {
@@ -12563,7 +12546,7 @@
     },
     "through": {
       "version": "2.3.8",
-      "resolved": "https://registry.npmjs.org/through/-/through-2.3.8.tgz",
+      "resolved": "http://registry.npmjs.org/through/-/through-2.3.8.tgz",
       "integrity": "sha1-DdTJ/6q8NXlgsbckEV1+Doai4fU=",
       "dev": true
     },
@@ -13219,7 +13202,7 @@
       "dependencies": {
         "minimist": {
           "version": "1.2.0",
-          "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
+          "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz",
           "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=",
           "dev": true
         }
@@ -13882,7 +13865,7 @@
     },
     "wrap-ansi": {
       "version": "2.1.0",
-      "resolved": "https://registry.npmjs.org/wrap-ansi/-/wrap-ansi-2.1.0.tgz",
+      "resolved": "http://registry.npmjs.org/wrap-ansi/-/wrap-ansi-2.1.0.tgz",
       "integrity": "sha1-2Pw9KE3QV5T+hJc8rs3Rz4JP3YU=",
       "dev": true,
       "requires": {
@@ -13990,7 +13973,7 @@
     },
     "yargs": {
       "version": "11.1.0",
-      "resolved": "https://registry.npmjs.org/yargs/-/yargs-11.1.0.tgz",
+      "resolved": "http://registry.npmjs.org/yargs/-/yargs-11.1.0.tgz",
       "integrity": "sha512-NwW69J42EsCSanF8kyn5upxvjp5ds+t3+udGBeTbFnERA+lF541DDpMawzo4z6W/QrzNM18D+BPMiOBibnFV5A==",
       "dev": true,
       "requires": {

client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cellxgene",
-  "version": "0.5.0",
+  "version": "0.2.4",
   "license": "MIT",
   "description": "cellxgene is a web application for the interactive exploration of single cell sequence data.",
   "repository": "https://github.com/chanzuckerberg/cellxgene",
@@ -33,12 +33,9 @@
     "canvas-fit": "^1.5.0",
     "d3": "^4.10.0",
     "d3-scale-chromatic": "^1.3.0",
-    "flatbuffers": "^1.10.2",
     "font-color-contrast": "^1.0.3",
-    "fuzzysort": "^1.1.4",
     "gl-mat4": "^1.1.4",
     "gl-matrix": "^2.7.1",
-    "is-number": "^7.0.0",
     "key-pressed": "0.0.1",
     "lodash": "^4.17.4",
     "memoize-one": "^4.0.0",
@@ -112,10 +109,7 @@
     "testMatch": [
       "**/__tests__/**/?(*.)(spec|test).js?(x)"
     ],
-    "testURL": "http://localhost/",
-    "setupFiles": [
-      "./__tests__/setupMissingGlobals.js"
-    ]
+    "testURL": "http://localhost/"
   },
   "babel": {
     "env": {

client/src/actions/index.js

@@ -5,7 +5,6 @@ import { Universe, kvCache } from "../util/stateManager";
 import {
   catchErrorsWrap,
   doJsonRequest,
-  doBinaryRequest,
   rangeEncodeIndices,
   dispatchNetworkErrorMessageToUser
 } from "../util/actionHelpers";
@@ -14,28 +13,24 @@ import {
 Bootstrap application with the initial data loading.
   * /config - application configuration
   * /schema - schema of dataframe
-  * /annotations - all metadata annotation
-  * /layout - all default layout
+  * /annotations/obs - all metadata annotation
 */
 const doInitialDataLoad = () =>
   catchErrorsWrap(async dispatch => {
     dispatch({ type: "initial data load start" });
 
     try {
-      const requestJson = _(["config", "schema"])
-        .map(r => `${globals.API.prefix}${globals.API.version}${r}`)
-        .map(url => doJsonRequest(url))
-        .value();
-      const requestBinary = _([
+      const requests = _([
+        "config",
+        "schema",
         "annotations/obs",
-        "annotations/var?annotation-name=name",
+        "annotations/var",
         "layout/obs"
       ])
         .map(r => `${globals.API.prefix}${globals.API.version}${r}`)
-        .map(url => doBinaryRequest(url))
+        .map(url => doJsonRequest(url))
         .value();
-
-      const results = await Promise.all(_.concat(requestJson, requestBinary));
+      const results = await Promise.all(requests);
 
       /* set config defaults */
       const config = { ...globals.configDefaults, ...results[0].config };
@@ -92,38 +87,6 @@ needs expression data.
 Transparently utilizes cached data if it is already present.
 */
 async function _doRequestExpressionData(dispatch, getState, genes) {
-  /* helper for this function only */
-  const fetchData = async geneNames => {
-    const res = await fetch(
-      `${globals.API.prefix}${globals.API.version}data/var`,
-      {
-        method: "PUT",
-        body: JSON.stringify({
-          filter: {
-            var: {
-              annotation_value: [{ name: "name", values: geneNames }]
-            }
-          }
-        }),
-        headers: new Headers({
-          accept: "application/octet-stream",
-          "Content-Type": "application/json"
-        })
-      }
-    );
-
-    if (
-      !res.ok ||
-      res.headers.get("Content-Type") !== "application/octet-stream"
-    ) {
-      // WILL throw
-      return dispatchExpressionErrors(dispatch, res);
-    }
-
-    const data = await res.arrayBuffer();
-    return Universe.convertDataFBStoObject(universe, data);
-  };
-
   const state = getState();
   const { universe } = state.controls;
   /* preload data already in cache */
@@ -145,10 +108,35 @@ async function _doRequestExpressionData(dispatch, getState, genes) {
   /* Fetch data for any genes not in cache */
   if (genesToFetch.length) {
     try {
-      const newExpressionData = await fetchData(genesToFetch);
+      // XXX: TODO - this could be using /data/var rather than /data/obs,
+      // as that would simplify the transformation in convertExpressionRESTv02ToObject
+      const res = await fetch(
+        `${globals.API.prefix}${globals.API.version}data/obs`,
+        {
+          method: "PUT",
+          body: JSON.stringify({
+            filter: {
+              var: {
+                annotation_value: [{ name: "name", values: genesToFetch }]
+              }
+            }
+          }),
+          headers: new Headers({
+            accept: "application/json",
+            "Content-Type": "application/json"
+          })
+        }
+      );
+
+      if (!res.ok || res.headers.get("Content-Type") !== "application/json") {
+        // WILL throw
+        return dispatchExpressionErrors(dispatch, res);
+      }
+
+      const data = await res.json();
       expressionData = {
         ...expressionData,
-        ...newExpressionData
+        ...Universe.convertExpressionRESTv02ToObject(universe, data)
       };
     } catch (error) {
       dispatch({ type: "expression load error", error });

client/src/components/brushableHistogram/index.js

@@ -13,7 +13,6 @@ import memoize from "memoize-one";
 import { kvCache } from "../../util/stateManager";
 import * as globals from "../../globals";
 import actions from "../../actions";
-import finiteExtent from "../../util/finiteExtent";
 
 @connect(state => ({
   world: state.controls.world,
@@ -27,7 +26,7 @@ import finiteExtent from "../../util/finiteExtent";
   obsAnnotations: _.get(state.controls.world, "obsAnnotations", null)
 }))
 class HistogramBrush extends React.Component {
-  calcHistogramCache = memoize((obsAnnotations, field, rangeMin, rangeMax) => {
+  calcHistogramCache = memoize((obsAnnotations, field, ranges) => {
     const { world } = this.props;
     const histogramCache = {};
 
@@ -41,7 +40,7 @@ class HistogramBrush extends React.Component {
 
       histogramCache.x = d3
         .scaleLinear()
-        .domain([rangeMin, rangeMax])
+        .domain([ranges.min, ranges.max])
         .range([0, this.width]);
 
       histogramCache.bins = d3
@@ -57,7 +56,7 @@ class HistogramBrush extends React.Component {
       histogramCache.x = d3
         .scaleLinear()
         .domain(
-          finiteExtent(varValues)
+          d3.extent(varValues)
         ) /* replace this if we have ranges for genes back from server like we do for annotations on cells */
         .range([0, this.width]);
 
@@ -131,8 +130,7 @@ class HistogramBrush extends React.Component {
     const histogramCache = this.calcHistogramCache(
       obsAnnotations,
       field,
-      ranges.min,
-      ranges.max
+      ranges
     );
 
     const { x, y, bins, numValues } = histogramCache;
@@ -161,13 +159,7 @@ class HistogramBrush extends React.Component {
   }
 
   removeHistogram() {
-    const {
-      dispatch,
-      field,
-      colorAccessor,
-      scatterplotXXaccessor,
-      scatterplotYYaccessor
-    } = this.props;
+    const { dispatch, field, colorAccessor } = this.props;
     dispatch({
       type: "clear user defined gene",
       data: field
@@ -177,18 +169,6 @@ class HistogramBrush extends React.Component {
         type: "reset colorscale"
       });
     }
-    if (field === scatterplotXXaccessor) {
-      dispatch({
-        type: "set scatterplot x",
-        data: null
-      });
-    }
-    if (field === scatterplotYYaccessor) {
-      dispatch({
-        type: "set scatterplot y",
-        data: null
-      });
-    }
   }
 
   handleSetGeneAsScatterplotX() {
@@ -285,7 +265,7 @@ class HistogramBrush extends React.Component {
         }}
       >
         <div style={{ display: "flex", justifyContent: "flex-end" }}>
-          {isDiffExp || isUserDefined ? (
+          {isDiffExp ? (
             <span>
               <span
                 style={{ marginRight: 7 }}

client/src/components/categorical/category.js

@@ -6,7 +6,7 @@ import { Button, Tooltip } from "@blueprintjs/core";
 
 import * as globals from "../../globals";
 import Value from "./value";
-import sortedCategoryValues from "./util";
+import alphabeticallySortedValues from "./util";
 
 @connect(state => ({
   colorAccessor: state.controls.colorAccessor,
@@ -25,22 +25,24 @@ class Category extends React.Component {
     const { categoricalSelectionState, metadataField } = this.props;
     const cat = categoricalSelectionState[metadataField];
     const categoryCount = {
-      // total number of categories in this dimension
-      totalCatCount: cat.numCategories,
+      // total number of options in this category
+      totalOptionCount: cat.numOptions,
       // number of selected options in this category
-      selectedCatCount: _.reduce(
-        cat.categorySelected,
+      selectedOptionCount: _.reduce(
+        cat.optionSelected,
         (res, cond) => (cond ? res + 1 : res),
         0
       )
     };
-    if (categoryCount.selectedCatCount === categoryCount.totalCatCount) {
+    if (categoryCount.selectedOptionCount === categoryCount.totalOptionCount) {
       /* everything is on, so not indeterminate */
       this.checkbox.indeterminate = false;
-    } else if (categoryCount.selectedCatCount === 0) {
+    } else if (categoryCount.selectedOptionCount === 0) {
       /* nothing is on, so no */
       this.checkbox.indeterminate = false;
-    } else if (categoryCount.selectedCatCount < categoryCount.totalCatCount) {
+    } else if (
+      categoryCount.selectedOptionCount < categoryCount.totalOptionCount
+    ) {
       /* to be explicit... */
       this.checkbox.indeterminate = true;
     }
@@ -86,13 +88,12 @@ class Category extends React.Component {
     const { categoricalSelectionState, metadataField } = this.props;
 
     const cat = categoricalSelectionState[metadataField];
-    const optTuples = sortedCategoryValues([...cat.categoryIndices]);
+    const optTuples = alphabeticallySortedValues([...cat.optionIndex]);
     return _.map(optTuples, (tuple, i) => (
       <Value
-        optTuples={optTuples}
         key={tuple[1]}
         metadataField={metadataField}
-        categoryIndex={tuple[1]}
+        optionIndex={tuple[1]}
         i={i}
       />
     ));

client/src/components/categorical/occupancy.js

@@ -1,73 +0,0 @@
-// jshint esversion: 6
-import React from "react";
-import _ from "lodash";
-import { connect } from "react-redux";
-import * as d3 from "d3";
-
-@connect()
-class Occupancy extends React.Component {
-  render() {
-    const {
-      occupancy,
-      colorScale,
-      categoricalSelectionState,
-      colorAccessor,
-      schema
-    } = this.props;
-    const width = 100;
-    const height = 11;
-
-    const categories = _.filter(schema.annotations.obs, {
-      name: colorAccessor
-    })[0].categories;
-
-    const x = d3
-      .scaleLinear()
-      /* get all the keys d[1] as an array, then find the sum */
-      .domain([0, d3.sum(Array.from(occupancy, d => d[1]))])
-      .range([0, width]);
-
-    let currentOffset = 0;
-
-    const stacks = categoricalSelectionState[colorAccessor].categoryValues.map(
-      d => {
-        const o = occupancy.get(d);
-
-        const scaledValue = x(o);
-
-        const stackItem = {
-          key: d,
-          value: o || 0,
-          rectWidth: o ? scaledValue : 0,
-          offset: currentOffset,
-          fill: o ? colorScale(categories.indexOf(d)) : "rgb(255,255,255)"
-        };
-        currentOffset += o ? scaledValue : 0;
-        return stackItem;
-      }
-    );
-
-    return (
-      <svg
-        style={{
-          marginRight: 5,
-          width,
-          height
-        }}
-      >
-        {stacks.map(d => (
-          <rect
-            key={d.key}
-            width={d.rectWidth}
-            height={height}
-            x={d.offset}
-            title={d.metadataField}
-            fill={d.fill}
-          />
-        ))}
-      </svg>
-    );
-  }
-}
-
-export default Occupancy;

client/src/components/categorical/util.js

@@ -3,33 +3,9 @@
 // values is [ [optVal, optIdx], ...]
 // index is range array
 // return sorted index
-
-import isNumber from "is-number";
-import _ from "lodash";
-
-const sortedCategoryValues = values => {
-  /* this sort could be memoized for perf */
-
-  const strings = [];
-  const ints = [];
-
-  _.forEach(values, v => {
-    if (isNumber(v[0])) {
-      ints.push(v);
-    } else {
-      strings.push(v);
-    }
-  });
-
-  strings.sort((a, b) => {
+export default values =>
+  values.sort((a, b) => {
     const textA = String(a[0]).toUpperCase();
     const textB = String(b[0]).toUpperCase();
     return textA < textB ? -1 : textA > textB ? 1 : 0;
   });
-
-  ints.sort((a, b) => +a[0] - +b[0]);
-
-  return ints.concat(strings);
-};
-
-export default sortedCategoryValues;

client/src/components/categorical/value.js

@@ -2,33 +2,29 @@
 import { connect } from "react-redux";
 import React from "react";
 import _ from "lodash";
-import Occupancy from "./occupancy";
-import { countCategoryValues2D } from "../../util/stateManager/worldUtil";
-import * as globals from "../../globals";
 
 @connect(state => ({
   categoricalSelectionState: state.controls.categoricalSelectionState,
   colorScale: state.controls.colorScale,
   colorAccessor: state.controls.colorAccessor,
-  schema: _.get(state.controls.world, "schema", null),
-  world: state.controls.world
+  schema: _.get(state.controls.world, "schema", null)
 }))
 class CategoryValue extends React.Component {
   toggleOff() {
-    const { dispatch, metadataField, categoryIndex } = this.props;
+    const { dispatch, metadataField, optionIndex } = this.props;
     dispatch({
       type: "categorical metadata filter deselect",
       metadataField,
-      categoryIndex
+      optionIndex
     });
   }
 
   toggleOn() {
-    const { dispatch, metadataField, categoryIndex } = this.props;
+    const { dispatch, metadataField, optionIndex } = this.props;
     dispatch({
       type: "categorical metadata filter select",
       metadataField,
-      categoryIndex
+      optionIndex
     });
   }
 
@@ -36,43 +32,31 @@ class CategoryValue extends React.Component {
     const {
       categoricalSelectionState,
       metadataField,
-      categoryIndex,
+      optionIndex,
       colorAccessor,
       colorScale,
       i,
-      schema,
-      world
+      schema
     } = this.props;
 
     if (!categoricalSelectionState) return null;
 
     const category = categoricalSelectionState[metadataField];
-    const selected = category.categorySelected[categoryIndex];
-    const count = category.categoryCounts[categoryIndex];
-    const value = category.categoryValues[categoryIndex];
-    const displayString = String(
-      category.categoryValues[categoryIndex]
-    ).valueOf();
+    const selected = category.optionSelected[optionIndex];
+    const count = category.optionCount[optionIndex];
+    const value = category.optionValue[optionIndex];
+    const displayString = String(category.optionValue[optionIndex]).valueOf();
 
     /* this is the color scale, so add swatches below */
-    const isColorBy = metadataField === colorAccessor;
+    const c = metadataField === colorAccessor;
     let categories = null;
-    let occupancy = null;
 
-    if (isColorBy && schema) {
+    if (c && schema) {
       categories = _.filter(schema.annotations.obs, {
         name: colorAccessor
       })[0].categories;
     }
 
-    if (colorAccessor && !isColorBy) {
-      occupancy = countCategoryValues2D(
-        metadataField,
-        colorAccessor,
-        world.obsAnnotations
-      );
-    }
-
     return (
       <div
         key={i}
@@ -86,10 +70,7 @@ class CategoryValue extends React.Component {
           style={{
             margin: 0,
             padding: 0,
-            userSelect: "none",
-            width: globals.leftSidebarWidth - 130,
-            display: "flex",
-            justifyContent: "space-between"
+            userSelect: "none"
           }}
         >
           <label className="bp3-control bp3-checkbox">
@@ -103,18 +84,6 @@ class CategoryValue extends React.Component {
             <span className="bp3-control-indicator" />
             {displayString}
           </label>
-          <span style={{ flexShrink: 0 }}>
-            {colorAccessor &&
-            !isColorBy &&
-            categoricalSelectionState[colorAccessor] ? (
-              <Occupancy
-                occupancy={occupancy.get(
-                  category.categoryValues[categoryIndex]
-                )}
-                {...this.props}
-              />
-            ) : null}
-          </span>
         </div>
         <span>
           <span>{count}</span>
@@ -124,7 +93,7 @@ class CategoryValue extends React.Component {
               width: 11,
               height: 11,
               backgroundColor:
-                isColorBy && categories
+                c && categories
                   ? colorScale(categories.indexOf(value))
                   : "inherit"
             }}

client/src/components/geneExpression/cellSetButtons.js

@@ -1,7 +1,7 @@
 // jshint esversion: 6
 import React from "react";
 import _ from "lodash";
-import { AnchorButton, Tooltip } from "@blueprintjs/core";
+import { Button, Tooltip } from "@blueprintjs/core";
 import { connect } from "react-redux";
 
 @connect()
@@ -33,10 +33,9 @@ class CellSetButton extends React.Component {
         content="Save current selection for differential expression computation"
         position="top"
       >
-        <AnchorButton
+        <Button
           style={{ marginRight: 10 }}
           type="button"
-          disabled={differential.diffExp}
           onClick={this.set.bind(this)}
         >
           {eitherCellSetOneOrTwo}
@@ -44,7 +43,7 @@ class CellSetButton extends React.Component {
           {differential[cellListName]
             ? `${differential[cellListName].length} cells`
             : "0 cells"}
-        </AnchorButton>
+        </Button>
       </Tooltip>
     );
   }

client/src/components/geneExpression/expressionButtons.js

@@ -68,7 +68,6 @@ class Expression extends React.Component {
               style={{ marginTop: 10 }}
               disabled={!haveBothCellSets}
               intent="primary"
-              loading={differential.loading}
               fill
               type="button"
               onClick={this.computeDiffExp.bind(this)}

client/src/components/geneExpression/index.js

@@ -3,51 +3,14 @@
 
 import React from "react";
 import _ from "lodash";
-import fuzzysort from "fuzzysort";
-
+import * as d3 from "d3";
 import { connect } from "react-redux";
-import { MenuItem, Button } from "@blueprintjs/core";
-import { Suggest } from "@blueprintjs/select";
+import { Button, Tooltip } from "@blueprintjs/core";
 import HistogramBrush from "../brushableHistogram";
 import * as globals from "../../globals";
 import actions from "../../actions";
 import { postUserErrorToast } from "../framework/toasters";
 import ExpressionButtons from "./expressionButtons";
-import finiteExtent from "../../util/finiteExtent";
-
-const renderGene = (fuzzySortResult, { handleClick, modifiers, query }) => {
-  if (!modifiers.matchesPredicate) {
-    return null;
-  }
-  /* the fuzzysort wraps the object with other properties, like a score */
-  const gene = fuzzySortResult.obj;
-  const text = gene.name;
-
-  return (
-    <MenuItem
-      active={modifiers.active}
-      disabled={modifiers.disabled}
-      // Use of annotations in this way is incorrect and dataset specific.
-      // See https://github.com/chanzuckerberg/cellxgene/issues/483
-      // label={gene.n_counts}
-      key={gene.name}
-      onClick={g => {
-        /* this fires when user clicks a menu item */
-        handleClick(g);
-      }}
-      text={text}
-    />
-  );
-};
-
-const filterGenes = (query, genes) => {
-  /* fires on load, once, and then for each character typed into the input */
-  return fuzzysort.go(query, genes, {
-    key: "name",
-    limit: 5,
-    threshold: -10000 // don't return bad results
-  });
-};
 
 @connect(state => {
   const metadata = _.get(state.controls.world, "obsAnnotations", null);
@@ -59,7 +22,6 @@ const filterGenes = (query, genes) => {
     metadata,
     initializeRanges,
     userDefinedGenes: state.controls.userDefinedGenes,
-    userDefinedGenesLoading: state.controls.userDefinedGenesLoading,
     world: state.controls.world,
     colorAccessor: state.controls.colorAccessor,
     allGeneNames: state.controls.allGeneNames,
@@ -67,9 +29,23 @@ const filterGenes = (query, genes) => {
   };
 })
 class GeneExpression extends React.Component {
-  handleClick(g) {
+  constructor(props) {
+    super(props);
+    this.state = {
+      gene: ""
+    };
+  }
+
+  keyPress(e) {
+    if (e.keyCode === 13) {
+      this.handleClick();
+    }
+  }
+
+  handleClick() {
     const { world, dispatch, userDefinedGenes } = this.props;
-    const gene = g.target;
+    const { gene } = this.state;
+
     if (userDefinedGenes.indexOf(gene) !== -1) {
       postUserErrorToast("That gene already exists");
     } else if (userDefinedGenes.length > 15) {
@@ -84,16 +60,13 @@ class GeneExpression extends React.Component {
         type: "user defined gene",
         data: gene
       });
+      this.setState({ gene: "" });
     }
   }
 
   render() {
-    const {
-      world,
-      userDefinedGenes,
-      userDefinedGenesLoading,
-      differential
-    } = this.props;
+    const { world, userDefinedGenes, differential } = this.props;
+    const { gene } = this.state;
 
     return (
       <div>
@@ -114,35 +87,27 @@ class GeneExpression extends React.Component {
             style={{ padding: globals.leftSidebarSectionPadding }}
             className="bp3-control-group"
           >
-            <Suggest
-              disabled={true}
-              closeOnSelect
-              openOnKeyDown
-              resetOnSelect
-              itemDisabled={userDefinedGenesLoading ? () => true : () => false}
-              noResults={<MenuItem disabled text="No matching genes." />}
-              onItemSelect={g => {
-                /* this happens on 'enter' */
-                this.handleClick(g);
-              }}
-              inputValueRenderer={g => {
-                return "";
-              }}
-              itemListPredicate={filterGenes}
-              itemRenderer={renderGene.bind(this)}
-              items={
-                world && world.varAnnotations
-                  ? world.varAnnotations
-                  : [{ name: "No genes", n_counts: "" }]
-              }
-              popoverProps={{ minimal: true }}
-            />
-            <Button
-              className="bp3-button bp3-intent-primary"
-              loading={userDefinedGenesLoading}
+            <div className="bp3-input-group bp3-fill">
+              <input
+                onKeyDown={this.keyPress.bind(this)}
+                onChange={e => {
+                  this.setState({ gene: e.target.value });
+                }}
+                value={gene}
+                type="text"
+                className="bp3-input"
+                placeholder="Enter a gene name"
+                style={{ paddingRight: 94 }}
+              />
+            </div>
+            <Tooltip
+              content="Add a gene to see its expression levels"
+              position="bottom"
             >
-              Add
-            </Button>
+              <Button intent="primary" onClick={this.handleClick.bind(this)}>
+                Add
+              </Button>
+            </Tooltip>
           </div>
           {world && userDefinedGenes.length > 0
             ? _.map(userDefinedGenes, (geneName, index) => {
@@ -155,7 +120,7 @@ class GeneExpression extends React.Component {
                     key={geneName}
                     field={geneName}
                     zebra={index % 2 === 0}
-                    ranges={finiteExtent(values)}
+                    ranges={d3.extent(values)}
                     isUserDefined
                   />
                 );
@@ -185,7 +150,7 @@ class GeneExpression extends React.Component {
                     key={name}
                     field={name}
                     zebra={index % 2 === 0}
-                    ranges={finiteExtent(values)}
+                    ranges={d3.extent(values)}
                     isDiffExp
                     logFoldChange={value[1]}
                     pval={value[2]}

client/src/components/graph/graph.js

@@ -22,8 +22,7 @@ import scaleLinear from "../../util/scaleLinear";
   responsive: state.responsive,
   colorRGB: _.get(state.controls, "colorRGB", null),
   opacityForDeselectedCells: state.controls.opacityForDeselectedCells,
-  selectionUpdate: _.get(state.controls, "crossfilter.updateTime", null),
-  resettingInterface: state.controls.resettingInterface
+  selectionUpdate: _.get(state.controls, "crossfilter.updateTime", null)
 }))
 class Graph extends React.Component {
   constructor(props) {
@@ -340,20 +339,11 @@ class Graph extends React.Component {
 
   resetInterface() {
     const { dispatch } = this.props;
-    dispatch({
-      type: "interface reset started"
-    });
     dispatch(actions.resetInterface());
   }
 
   render() {
-    const {
-      dispatch,
-      responsive,
-      crossfilter,
-      resettingInterface
-    } = this.props;
-
+    const { dispatch, responsive, crossfilter } = this.props;
     const { mode } = this.state;
     return (
       <div id="graphWrapper">
@@ -402,7 +392,6 @@ class Graph extends React.Component {
                   /* world && universe ? worldEqUniverse(world, universe) : false */
                 }
                 type="button"
-                loading={resettingInterface}
                 intent="warning"
                 style={{ marginRight: 10 }}
                 onClick={this.resetInterface.bind(this)}

client/src/components/scatterplot/scatterplot.js

@@ -20,7 +20,6 @@ import scaleLinear from "../../util/scaleLinear";
 
 import { margin, width, height } from "./util";
 import { kvCache } from "../../util/stateManager";
-import finiteExtent from "../../util/finiteExtent";
 
 @connect(state => {
   const {
@@ -228,11 +227,11 @@ class Scatterplot extends React.Component {
   static setupScales(expressionX, expressionY) {
     const xScale = d3
       .scaleLinear()
-      .domain(finiteExtent(expressionX))
+      .domain(d3.extent(expressionX))
       .range([0, width]);
     const yScale = d3
       .scaleLinear()
-      .domain(finiteExtent(expressionY))
+      .domain(d3.extent(expressionY))
       .range([height, 0]);
 
     return {

client/src/globals.js

@@ -57,7 +57,6 @@ export const brightBlue = "#4a90e2";
 export const brightGreen = "#A2D729";
 export const darkGreen = "#448C4D";
 
-export const nonFiniteCellColor = lightGrey;
 export const defaultCellColor = "rgb(0,0,0,1)";
 
 /* typography constants */

client/src/middleware/updateCellColors.js

@@ -1,10 +1,15 @@
 // jshint esversion: 6
 import _ from "lodash";
 import * as d3 from "d3";
-import { interpolateRainbow, interpolateCool } from "d3-scale-chromatic";
+import {
+  interpolateViridis,
+  interpolateSpectral,
+  interpolateRainbow,
+  interpolateBlues,
+  interpolateCool
+} from "d3-scale-chromatic";
 import * as globals from "../globals";
 import parseRGB from "../util/parseRGB";
-import finiteExtent from "../util/finiteExtent";
 
 /*
   https://medium.com/@jacobp100/you-arent-using-redux-middleware-enough-94ffe991e6
@@ -49,89 +54,62 @@ const updateCellColorsMiddleware = store => next => action => {
 
   const { obsAnnotations } = s.controls.world;
   let colorScale;
+  const colorsByName = new Array(obsAnnotations.length);
   const colorsByRGB = new Array(obsAnnotations.length);
 
   /*
   in plain language...
    (a) once the cells have loaded.
    (b) each time a user changes a color control we need to update cellsMetadata colors
-  This is available to all the draw functions as controls.colorRGB[index]
+  This is available to all the draw functions as world.colorName[index] or world.colorRGB[index]
   */
 
   if (action.type === "color by categorical metadata") {
-    const { categories } = _.filter(s.controls.world.schema.annotations.obs, {
+    const categories = _.filter(s.controls.world.schema.annotations.obs, {
       name: action.colorAccessor
-    })[0];
+    })[0].categories;
 
     colorScale = d3
       .scaleSequential(interpolateRainbow)
       .domain([0, categories.length]);
 
-    /* pre-create colors - much faster than doing it for each obs */
-    const colors = _.transform(categories, (acc, cat, idx) => {
-      acc[cat] = parseRGB(colorScale(idx));
-    });
-
-    const key = action.colorAccessor;
-    for (let i = 0, len = obsAnnotations.length; i < len; i += 1) {
+    for (let i = 0; i < obsAnnotations.length; i += 1) {
       const obs = obsAnnotations[i];
-      const cat = obs[key];
-      colorsByRGB[i] = colors[cat];
+      const c = colorScale(categories.indexOf(obs[action.colorAccessor]));
+      colorsByName[i] = c;
+      colorsByRGB[i] = parseRGB(c);
     }
   }
 
   if (action.type === "color by continuous metadata") {
-    const colorBins = 100;
-    const [min, max] = [0, action.rangeMaxForColorAccessor];
     colorScale = d3
-      .scaleQuantile()
-      .domain([min, max])
-      .range(_.range(colorBins - 1, -1, -1));
+      .scaleLinear()
+      .domain([0, action.rangeMaxForColorAccessor])
+      .range([1, 0]);
 
-    /* pre-create colors - much faster than doing it for each obs */
-    const colors = new Array(colorBins);
-    for (let i = 0; i < colorBins; i += 1) {
-      colors[i] = parseRGB(interpolateCool(i / colorBins));
-    }
-
-    const key = action.colorAccessor;
-    const nonFiniteColor = parseRGB(globals.nonFiniteCellColor);
-    for (let i = 0, len = obsAnnotations.length; i < len; i += 1) {
-      const val = obsAnnotations[i][key];
-      if (Number.isFinite(val)) {
-        const c = colorScale(val);
-        colorsByRGB[i] = colors[c];
-      } else {
-        colorsByRGB[i] = nonFiniteColor;
-      }
+    for (let i = 0; i < obsAnnotations.length; i += 1) {
+      const obs = obsAnnotations[i];
+      const c = interpolateCool(colorScale(obs[action.colorAccessor]));
+      colorsByName[i] = c;
+      colorsByRGB[i] = parseRGB(c);
     }
   }
 
   if (action.type === "color by expression") {
     const { gene, data } = action;
     const expression = data[gene]; // Float32Array
-    const colorBins = 100;
-    const [min, max] = finiteExtent(expression);
     colorScale = d3
-      .scaleQuantile()
-      .domain([min, max])
-      .range(_.range(colorBins - 1, -1, -1));
-
-    /* pre-create colors - much faster than doing it for each obs */
-    const colors = new Array(colorBins);
-    for (let i = 0; i < colorBins; i += 1) {
-      colors[i] = parseRGB(interpolateCool(i / colorBins));
-    }
-    const nonFiniteColor = parseRGB(globals.nonFiniteCellColor);
+      .scaleLinear()
+      .domain([_.min(expression), _.max(expression)])
+      .range([
+        1,
+        0
+      ]); /* invert viridis... probably pass this scale through to others */
 
     for (let i = 0, len = expression.length; i < len; i += 1) {
-      const e = expression[i];
-      if (Number.isFinite(e)) {
-        const c = colorScale(e);
-        colorsByRGB[i] = colors[c];
-      } else {
-        colorsByRGB[i] = nonFiniteColor;
-      }
+      const c = interpolateCool(colorScale(expression[i]));
+      colorsByName[i] = c;
+      colorsByRGB[i] = parseRGB(c);
     }
   }
 
@@ -139,7 +117,7 @@ const updateCellColorsMiddleware = store => next => action => {
   append the result of all the filters to the action the user just triggered
   */
   const modifiedAction = Object.assign({}, action, {
-    colors: { rgb: colorsByRGB },
+    colors: { name: colorsByName, rgb: colorsByRGB },
     colorScale
   });
 

client/src/reducers/controls.js

@@ -1,7 +1,7 @@
 // jshint esversion: 6
 
 import _ from "lodash";
-import { World, kvCache, WorldUtil } from "../util/stateManager";
+import { World, kvCache } from "../util/stateManager";
 import parseRGB from "../util/parseRGB";
 import Crossfilter from "../util/typedCrossfilter";
 import * as globals from "../globals";
@@ -24,27 +24,25 @@ Remember that option values can be ANY js type, except undefined/null.
   {
     _category_name_1: {
       // map of option value to index
-      categoryIndices: Map([
-        catval1: index,
+      optionIndex: Map([
+        optval1: index,
         ...
       ])
 
       // index->selection true/false state
-      categorySelected: [ true/false, true/false, ... ]
+      optionSelected: [ true/false, true/false, ... ]
 
       // number of options
-      numCategories: number,
+      numOptions: number,
 
       // isTruncated - true if the options for selection has
       // been truncated (ie, was too large to implement)
     }
   }
 */
-function topNCategories(summary) {
-  const counts = _.map(summary.categories, cat =>
-    summary.categoryCounts.get(cat)
-  );
-  const sortIndex = fillRange(new Array(summary.numCategories)).sort(
+function topNoptions(summary) {
+  const counts = _.map(summary.categories, cat => summary.options[cat]);
+  const sortIndex = fillRange(new Array(summary.numOptions)).sort(
     (a, b) => counts[b] - counts[a]
   );
   const sortedCategories = _.map(sortIndex, i => summary.categories[i]);
@@ -67,18 +65,20 @@ function createCategoricalSelectionState(state, world) {
         key !== "name" &&
         value.categories.length < state.maxCategoryItems;
       if (isSelectableCategory) {
-        const [categoryValues, categoryCounts] = topNCategories(value);
-        const categoryIndices = new Map(categoryValues.map((v, i) => [v, i]));
-        const numCategories = categoryIndices.size;
-        const categorySelected = new Array(numCategories).fill(true);
-        const isTruncated = categoryValues.length < value.numCategories;
+        const [optionValue, optionCount] = topNoptions(value);
+        // const optionCount = Object.values(value.options);
+
+        const optionIndex = new Map(optionValue.map((v, i) => [v, i]));
+        const numOptions = optionIndex.size;
+        const optionSelected = new Array(numOptions).fill(true);
+        const isTruncated = optionValue.length < value.numOptions;
         res[key] = {
-          categoryValues, // array: of natively typed category values
-          categoryIndices, // map: category value (native type) -> category index
-          categorySelected, // array: t/f selection state
-          numCategories, // number: of categories
+          optionValue, // array: of natively typed option values
+          optionIndex, // map: option value (native type) -> option index
+          optionSelected, // array: t/f selection state
+          numOptions, // number: of options
           isTruncated, // bool: true if list was truncated
-          categoryCounts // array: cardinality of each category
+          optionCount // array: cardinality of each option
         };
       }
     }
@@ -87,12 +87,12 @@ function createCategoricalSelectionState(state, world) {
 }
 
 /*
-given a categoricalSelectionState, return the list of all category values
+given a categoricalSelectionState, return the list of all option values
 where selection state is true (ie, they are selected).
 */
 function selectedValuesForCategory(categorySelectionState) {
-  const selectedValues = _([...categorySelectionState.categoryIndices])
-    .filter(tuple => categorySelectionState.categorySelected[tuple[1]])
+  const selectedValues = _([...categorySelectionState.optionIndex])
+    .filter(tuple => categorySelectionState.optionSelected[tuple[1]])
     .map(tuple => tuple[0])
     .value();
   return selectedValues;
@@ -112,17 +112,16 @@ const Controls = (
 
     // all of the data + selection state
     world: null,
+    colorName: null,
     colorRGB: null,
     categoricalSelectionState: null,
     crossfilter: null,
     dimensionMap: null,
     userDefinedGenes: [],
-    userDefinedGenesLoading: false,
     diffexpGenes: [],
 
     colorAccessor: null,
     colorScale: null,
-    resettingInterface: false,
 
     opacityForDeselectedCells: 0.2,
     graphBrushSelection: null,
@@ -168,16 +167,14 @@ const Controls = (
       /* first light - create world & other data-driven defaults */
       const { universe } = action;
       const world = World.createWorldFromEntireUniverse(universe);
-      const colorRGB = new Array(universe.nObs).fill(
-        parseRGB(globals.defaultCellColor)
-      );
+      const colorName = new Array(universe.nObs).fill(globals.defaultCellColor);
+      const colorRGB = _.map(colorName, c => parseRGB(c));
       const categoricalSelectionState = createCategoricalSelectionState(
         state,
         world
       );
       const crossfilter = Crossfilter(world.obsAnnotations);
       const dimensionMap = World.createObsDimensionMap(crossfilter, world);
-      WorldUtil.clearCaches();
 
       const worldVarDataCache = world.varDataCache;
 
@@ -225,12 +222,12 @@ const Controls = (
         error: null,
         universe,
         world,
+        colorName,
         colorRGB,
         categoricalSelectionState,
         crossfilter,
         dimensionMap,
-        colorAccessor: null,
-        resettingInterface: false
+        colorAccessor: null
       };
     }
     case "set World to current selection": {
@@ -242,16 +239,14 @@ const Controls = (
         action.world,
         action.crossfilter
       );
-      const colorRGB = new Array(world.nObs).fill(
-        parseRGB(globals.defaultCellColor)
-      );
+      const colorName = new Array(world.nObs).fill(globals.defaultCellColor);
+      const colorRGB = _.map(colorName, c => parseRGB(c));
       const categoricalSelectionState = createCategoricalSelectionState(
         state,
         world
       );
       const crossfilter = Crossfilter(world.obsAnnotations);
       const dimensionMap = World.createObsDimensionMap(crossfilter, world);
-      WorldUtil.clearCaches();
 
       const worldVarDataCache = world.varDataCache;
       /* var dimensions */
@@ -292,6 +287,7 @@ const Controls = (
         loading: false,
         error: null,
         world,
+        colorName,
         colorRGB,
         categoricalSelectionState,
         crossfilter,
@@ -326,18 +322,6 @@ const Controls = (
         }
       };
     }
-    case "request user defined gene started": {
-      return {
-        ...state,
-        userDefinedGenesLoading: true
-      };
-    }
-    case "request user defined gene error": {
-      return {
-        ...state,
-        userDefinedGenesLoading: false
-      };
-    }
     case "request user defined gene success": {
       const { world, crossfilter, dimensionMap, userDefinedGenes } = state;
       const worldVarDataCache = world.varDataCache;
@@ -355,8 +339,7 @@ const Controls = (
       return {
         ...state,
         dimensionMap,
-        userDefinedGenes: _userDefinedGenes,
-        userDefinedGenesLoading: false
+        userDefinedGenes: _userDefinedGenes
       };
     }
     case "request differential expression success": {
@@ -457,11 +440,11 @@ const Controls = (
     }
     case "reset colorscale": {
       const { world } = state;
-      const colorRGB = new Array(world.nObs).fill(
-        parseRGB(globals.defaultCellColor)
-      );
+      const colorName = new Array(world.nObs).fill(globals.defaultCellColor);
+      const colorRGB = _.map(colorName, c => parseRGB(c));
       return {
         ...state,
+        colorName,
         colorRGB,
         colorAccessor: null
       };
@@ -527,25 +510,19 @@ const Controls = (
         graphRenderCounter: c
       };
     }
-    case "interface reset started": {
-      return {
-        ...state,
-        resettingInterface: true
-      };
-    }
     /*******************************
           Categorical metadata
     *******************************/
     case "categorical metadata filter select": {
-      const newCategorySelected = Array.from(
-        state.categoricalSelectionState[action.metadataField].categorySelected
+      const newOptionSelected = Array.from(
+        state.categoricalSelectionState[action.metadataField].optionSelected
       );
-      newCategorySelected[action.categoryIndex] = true;
+      newOptionSelected[action.optionIndex] = true;
       const newCategoricalSelectionState = {
         ...state.categoricalSelectionState,
         [action.metadataField]: {
           ...state.categoricalSelectionState[action.metadataField],
-          categorySelected: newCategorySelected
+          optionSelected: newOptionSelected
         }
       };
 
@@ -561,15 +538,15 @@ const Controls = (
       };
     }
     case "categorical metadata filter deselect": {
-      const newCategorySelected = Array.from(
-        state.categoricalSelectionState[action.metadataField].categorySelected
+      const newOptionSelected = Array.from(
+        state.categoricalSelectionState[action.metadataField].optionSelected
       );
-      newCategorySelected[action.categoryIndex] = false;
+      newOptionSelected[action.optionIndex] = false;
       const newCategoricalSelectionState = {
         ...state.categoricalSelectionState,
         [action.metadataField]: {
           ...state.categoricalSelectionState[action.metadataField],
-          categorySelected: newCategorySelected
+          optionSelected: newOptionSelected
         }
       };
 
@@ -589,9 +566,8 @@ const Controls = (
         ...state.categoricalSelectionState,
         [action.metadataField]: {
           ...state.categoricalSelectionState[action.metadataField],
-          categorySelected: Array.from(
-            state.categoricalSelectionState[action.metadataField]
-              .categorySelected
+          optionSelected: Array.from(
+            state.categoricalSelectionState[action.metadataField].optionSelected
           ).fill(false)
         }
       };
@@ -608,9 +584,8 @@ const Controls = (
         ...state.categoricalSelectionState,
         [action.metadataField]: {
           ...state.categoricalSelectionState[action.metadataField],
-          categorySelected: Array.from(
-            state.categoricalSelectionState[action.metadataField]
-              .categorySelected
+          optionSelected: Array.from(
+            state.categoricalSelectionState[action.metadataField].optionSelected
           ).fill(true)
         }
       };
@@ -630,6 +605,7 @@ const Controls = (
     case "color by continuous metadata": {
       return {
         ...state,
+        colorName: action.colors.name,
         colorRGB: action.colors.rgb,
         colorAccessor: action.colorAccessor,
         colorScale: action.colorScale
@@ -638,6 +614,7 @@ const Controls = (
     case "color by expression": {
       return {
         ...state,
+        colorName: action.colors.name,
         colorRGB: action.colors.rgb,
         colorAccessor: action.gene,
         colorScale: action.colorScale

client/src/util/actionHelpers.js

@@ -24,44 +24,23 @@ export function catchErrorsWrap(fn, dispatchToUser = false) {
   };
 }
 
-/*
-Wrapper to perform async fetch with some modest error handling
-and decoding.
-*/
-const doFetch = async (url, acceptType) => {
-  const res = await fetch(url, {
-    method: "get",
-    headers: new Headers({
-      Accept: acceptType
-    })
-  });
-  if (res.ok && res.headers.get("Content-Type") === acceptType) {
-    return res;
-  }
-  // else an error
-  let msg = `Unexpected HTTP response ${res.status}, ${res.statusText}`;
-  const body = await res.text();
-  if (body && body.length > 0) {
-    msg = `${msg} -- ${body}`;
-  }
-  dispatchNetworkErrorMessageToUser(msg);
-  throw new Error(msg);
-};
-
 /*
 Wrapper to perform an async fetch and JSON decode response.
 */
 export const doJsonRequest = async url => {
-  const res = await doFetch(url, "application/json");
-  return res.json();
-};
-
-/*
-Wrapper to perform an async fetch for binary data.
-*/
-export const doBinaryRequest = async url => {
-  const res = await doFetch(url, "application/octet-stream");
-  return res.arrayBuffer();
+  const res = await fetch(url, {
+    method: "get",
+    headers: new Headers({
+      "Content-Type": "application/json"
+    })
+  });
+  if (res.ok && res.headers.get("Content-Type") === "application/json") {
+    return res.json();
+  }
+  // else an error
+  const msg = `Unexpected HTTP response ${res.status}, ${res.statusText}`;
+  dispatchNetworkErrorMessageToUser(msg);
+  throw new Error(msg);
 };
 
 /*

client/src/util/finiteExtent.js

@@ -1,33 +0,0 @@
-/*
-Return the [minimum, maximum] extent, of the given typed array, ignoring
-non-finite values (ie, +Infinity, -Infinity).
-
-If undefined or empty array, or array contains only non-finite numbers,
-will return [undefined, undefined]
-*/
-
-function finiteExtent(tarr) {
-  let min;
-  let max;
-  let i;
-
-  for (i = 0; i < tarr.length; i += 1) {
-    const val = tarr[i];
-    if (Number.isFinite(val)) {
-      min = val;
-      max = val;
-      i += 1;
-      break;
-    }
-  }
-  for (; i < tarr.length; i += 1) {
-    const val = tarr[i];
-    if (Number.isFinite(val)) {
-      if (min > val) min = val;
-      if (max < val) max = val;
-    }
-  }
-  return [min, max];
-}
-
-export default finiteExtent;

client/src/util/stateManager/index.js

@@ -3,7 +3,7 @@
 /*
 Model manager providing an abstraction for the use of the reducer code.
 This module provides several buckets of functionality:
-  - schema and config driven tranformation of the wire protocol
+  - schema and config driven tranformation of the dataframe wire protocol
     into a format that is easy for the UI code to use.
   - manage the universe/world abstraction:
     + universe: all of the server-provided, read-only data
@@ -17,4 +17,3 @@ exists to support those concepts.
 export * as Universe from "./universe";
 export * as World from "./world";
 export * as kvCache from "./keyvalcache";
-export * as WorldUtil from "./worldUtil";

client/src/util/stateManager/matrix.js

@@ -1,75 +0,0 @@
-import { flatbuffers } from "flatbuffers";
-import { NetEncoding } from "./matrix_generated";
-
-const utf8Decoder = new TextDecoder("utf-8");
-
-/*
-Matrix flatbuffer decoding support.   See fbs/matrix.fbs
-*/
-
-/*
-Decode NetEncoding.TypedArray
-*/
-function decodeTypedArray(uType, uValF, inplace = false) {
-  if (uType === NetEncoding.TypedArray.NONE) {
-    return null;
-  }
-
-  // Convert to a JS class that supports this type
-  const TypeClass = NetEncoding[NetEncoding.TypedArray[uType]];
-  // Create a TypedArray that references the underlying buffer
-  let arr = uValF(new TypeClass()).dataArray();
-  if (uType === NetEncoding.TypedArray.JSONEncodedArray) {
-    const json = utf8Decoder.decode(arr);
-    arr = JSON.parse(json);
-  } else if (!inplace) {
-    /* force copy to release underlying FBS buffer */
-    arr = new arr.constructor(arr);
-  }
-  return arr;
-}
-
-/*
-Parameter: Uint8Array or ArrayBuffer containing raw flatbuffer Matrix
-Returns: object containing decoded Matrix:
-{
-  nRows: num,
-  nCols: num,
-  columns: [
-    each column, which will be a TypedArray or Array
-  ]
-  colIdx: []|null
-}
-*/
-function decodeMatrixFBS(arrayBuffer, inplace = false) {
-  const bb = new flatbuffers.ByteBuffer(new Uint8Array(arrayBuffer));
-  const df = NetEncoding.Matrix.getRootAsMatrix(bb);
-
-  const nRows = df.nRows();
-  const nCols = df.nCols();
-
-  /* decode columns */
-  const columnsLength = df.columnsLength();
-  const columns = Array(columnsLength).fill(null);
-  for (let c = 0; c < columnsLength; c += 1) {
-    const col = df.columns(c);
-    columns[c] = decodeTypedArray(col.uType(), col.u.bind(col), inplace);
-  }
-
-  /* decode col_idx */
-  const colIdx = decodeTypedArray(
-    df.colIndexType(),
-    df.colIndex.bind(df),
-    inplace
-  );
-
-  return {
-    nRows,
-    nCols,
-    columns,
-    colIdx,
-    rowIdx: null
-  };
-}
-
-export default decodeMatrixFBS;

client/src/util/stateManager/matrix_generated.js

@@ -1,835 +0,0 @@
-// automatically generated by the FlatBuffers compiler, do not modify
-
-/**
- * @const
- * @namespace
- */
-var NetEncoding = NetEncoding || {};
-
-/**
- * @enum
- */
-NetEncoding.TypedArray = {
-  NONE: 0, 0: 'NONE',
-  Float32Array: 1, 1: 'Float32Array',
-  Int32Array: 2, 2: 'Int32Array',
-  Uint32Array: 3, 3: 'Uint32Array',
-  Float64Array: 4, 4: 'Float64Array',
-  JSONEncodedArray: 5, 5: 'JSONEncodedArray'
-};
-
-/**
- * @constructor
- */
-NetEncoding.Float32Array = function() {
-  /**
-   * @type {flatbuffers.ByteBuffer}
-   */
-  this.bb = null;
-
-  /**
-   * @type {number}
-   */
-  this.bb_pos = 0;
-};
-
-/**
- * @param {number} i
- * @param {flatbuffers.ByteBuffer} bb
- * @returns {NetEncoding.Float32Array}
- */
-NetEncoding.Float32Array.prototype.__init = function(i, bb) {
-  this.bb_pos = i;
-  this.bb = bb;
-  return this;
-};
-
-/**
- * @param {flatbuffers.ByteBuffer} bb
- * @param {NetEncoding.Float32Array=} obj
- * @returns {NetEncoding.Float32Array}
- */
-NetEncoding.Float32Array.getRootAsFloat32Array = function(bb, obj) {
-  return (obj || new NetEncoding.Float32Array).__init(bb.readInt32(bb.position()) + bb.position(), bb);
-};
-
-/**
- * @param {number} index
- * @returns {number}
- */
-NetEncoding.Float32Array.prototype.data = function(index) {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.readFloat32(this.bb.__vector(this.bb_pos + offset) + index * 4) : 0;
-};
-
-/**
- * @returns {number}
- */
-NetEncoding.Float32Array.prototype.dataLength = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
-};
-
-/**
- * @returns {Float32Array}
- */
-NetEncoding.Float32Array.prototype.dataArray = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? new Float32Array(this.bb.bytes().buffer, this.bb.bytes().byteOffset + this.bb.__vector(this.bb_pos + offset), this.bb.__vector_len(this.bb_pos + offset)) : null;
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- */
-NetEncoding.Float32Array.startFloat32Array = function(builder) {
-  builder.startObject(1);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} dataOffset
- */
-NetEncoding.Float32Array.addData = function(builder, dataOffset) {
-  builder.addFieldOffset(0, dataOffset, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {Array.<number>} data
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Float32Array.createDataVector = function(builder, data) {
-  builder.startVector(4, data.length, 4);
-  for (var i = data.length - 1; i >= 0; i--) {
-    builder.addFloat32(data[i]);
-  }
-  return builder.endVector();
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {number} numElems
- */
-NetEncoding.Float32Array.startDataVector = function(builder, numElems) {
-  builder.startVector(4, numElems, 4);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Float32Array.endFloat32Array = function(builder) {
-  var offset = builder.endObject();
-  return offset;
-};
-
-/**
- * @constructor
- */
-NetEncoding.Uint32Array = function() {
-  /**
-   * @type {flatbuffers.ByteBuffer}
-   */
-  this.bb = null;
-
-  /**
-   * @type {number}
-   */
-  this.bb_pos = 0;
-};
-
-/**
- * @param {number} i
- * @param {flatbuffers.ByteBuffer} bb
- * @returns {NetEncoding.Uint32Array}
- */
-NetEncoding.Uint32Array.prototype.__init = function(i, bb) {
-  this.bb_pos = i;
-  this.bb = bb;
-  return this;
-};
-
-/**
- * @param {flatbuffers.ByteBuffer} bb
- * @param {NetEncoding.Uint32Array=} obj
- * @returns {NetEncoding.Uint32Array}
- */
-NetEncoding.Uint32Array.getRootAsUint32Array = function(bb, obj) {
-  return (obj || new NetEncoding.Uint32Array).__init(bb.readInt32(bb.position()) + bb.position(), bb);
-};
-
-/**
- * @param {number} index
- * @returns {number}
- */
-NetEncoding.Uint32Array.prototype.data = function(index) {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.readUint32(this.bb.__vector(this.bb_pos + offset) + index * 4) : 0;
-};
-
-/**
- * @returns {number}
- */
-NetEncoding.Uint32Array.prototype.dataLength = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
-};
-
-/**
- * @returns {Uint32Array}
- */
-NetEncoding.Uint32Array.prototype.dataArray = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? new Uint32Array(this.bb.bytes().buffer, this.bb.bytes().byteOffset + this.bb.__vector(this.bb_pos + offset), this.bb.__vector_len(this.bb_pos + offset)) : null;
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- */
-NetEncoding.Uint32Array.startUint32Array = function(builder) {
-  builder.startObject(1);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} dataOffset
- */
-NetEncoding.Uint32Array.addData = function(builder, dataOffset) {
-  builder.addFieldOffset(0, dataOffset, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {Array.<number>} data
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Uint32Array.createDataVector = function(builder, data) {
-  builder.startVector(4, data.length, 4);
-  for (var i = data.length - 1; i >= 0; i--) {
-    builder.addInt32(data[i]);
-  }
-  return builder.endVector();
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {number} numElems
- */
-NetEncoding.Uint32Array.startDataVector = function(builder, numElems) {
-  builder.startVector(4, numElems, 4);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Uint32Array.endUint32Array = function(builder) {
-  var offset = builder.endObject();
-  return offset;
-};
-
-/**
- * @constructor
- */
-NetEncoding.Int32Array = function() {
-  /**
-   * @type {flatbuffers.ByteBuffer}
-   */
-  this.bb = null;
-
-  /**
-   * @type {number}
-   */
-  this.bb_pos = 0;
-};
-
-/**
- * @param {number} i
- * @param {flatbuffers.ByteBuffer} bb
- * @returns {NetEncoding.Int32Array}
- */
-NetEncoding.Int32Array.prototype.__init = function(i, bb) {
-  this.bb_pos = i;
-  this.bb = bb;
-  return this;
-};
-
-/**
- * @param {flatbuffers.ByteBuffer} bb
- * @param {NetEncoding.Int32Array=} obj
- * @returns {NetEncoding.Int32Array}
- */
-NetEncoding.Int32Array.getRootAsInt32Array = function(bb, obj) {
-  return (obj || new NetEncoding.Int32Array).__init(bb.readInt32(bb.position()) + bb.position(), bb);
-};
-
-/**
- * @param {number} index
- * @returns {number}
- */
-NetEncoding.Int32Array.prototype.data = function(index) {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.readInt32(this.bb.__vector(this.bb_pos + offset) + index * 4) : 0;
-};
-
-/**
- * @returns {number}
- */
-NetEncoding.Int32Array.prototype.dataLength = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
-};
-
-/**
- * @returns {Int32Array}
- */
-NetEncoding.Int32Array.prototype.dataArray = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? new Int32Array(this.bb.bytes().buffer, this.bb.bytes().byteOffset + this.bb.__vector(this.bb_pos + offset), this.bb.__vector_len(this.bb_pos + offset)) : null;
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- */
-NetEncoding.Int32Array.startInt32Array = function(builder) {
-  builder.startObject(1);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} dataOffset
- */
-NetEncoding.Int32Array.addData = function(builder, dataOffset) {
-  builder.addFieldOffset(0, dataOffset, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {Array.<number>} data
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Int32Array.createDataVector = function(builder, data) {
-  builder.startVector(4, data.length, 4);
-  for (var i = data.length - 1; i >= 0; i--) {
-    builder.addInt32(data[i]);
-  }
-  return builder.endVector();
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {number} numElems
- */
-NetEncoding.Int32Array.startDataVector = function(builder, numElems) {
-  builder.startVector(4, numElems, 4);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Int32Array.endInt32Array = function(builder) {
-  var offset = builder.endObject();
-  return offset;
-};
-
-/**
- * @constructor
- */
-NetEncoding.Float64Array = function() {
-  /**
-   * @type {flatbuffers.ByteBuffer}
-   */
-  this.bb = null;
-
-  /**
-   * @type {number}
-   */
-  this.bb_pos = 0;
-};
-
-/**
- * @param {number} i
- * @param {flatbuffers.ByteBuffer} bb
- * @returns {NetEncoding.Float64Array}
- */
-NetEncoding.Float64Array.prototype.__init = function(i, bb) {
-  this.bb_pos = i;
-  this.bb = bb;
-  return this;
-};
-
-/**
- * @param {flatbuffers.ByteBuffer} bb
- * @param {NetEncoding.Float64Array=} obj
- * @returns {NetEncoding.Float64Array}
- */
-NetEncoding.Float64Array.getRootAsFloat64Array = function(bb, obj) {
-  return (obj || new NetEncoding.Float64Array).__init(bb.readInt32(bb.position()) + bb.position(), bb);
-};
-
-/**
- * @param {number} index
- * @returns {number}
- */
-NetEncoding.Float64Array.prototype.data = function(index) {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.readFloat64(this.bb.__vector(this.bb_pos + offset) + index * 8) : 0;
-};
-
-/**
- * @returns {number}
- */
-NetEncoding.Float64Array.prototype.dataLength = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
-};
-
-/**
- * @returns {Float64Array}
- */
-NetEncoding.Float64Array.prototype.dataArray = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? new Float64Array(this.bb.bytes().buffer, this.bb.bytes().byteOffset + this.bb.__vector(this.bb_pos + offset), this.bb.__vector_len(this.bb_pos + offset)) : null;
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- */
-NetEncoding.Float64Array.startFloat64Array = function(builder) {
-  builder.startObject(1);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} dataOffset
- */
-NetEncoding.Float64Array.addData = function(builder, dataOffset) {
-  builder.addFieldOffset(0, dataOffset, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {Array.<number>} data
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Float64Array.createDataVector = function(builder, data) {
-  builder.startVector(8, data.length, 8);
-  for (var i = data.length - 1; i >= 0; i--) {
-    builder.addFloat64(data[i]);
-  }
-  return builder.endVector();
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {number} numElems
- */
-NetEncoding.Float64Array.startDataVector = function(builder, numElems) {
-  builder.startVector(8, numElems, 8);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Float64Array.endFloat64Array = function(builder) {
-  var offset = builder.endObject();
-  return offset;
-};
-
-/**
- * @constructor
- */
-NetEncoding.JSONEncodedArray = function() {
-  /**
-   * @type {flatbuffers.ByteBuffer}
-   */
-  this.bb = null;
-
-  /**
-   * @type {number}
-   */
-  this.bb_pos = 0;
-};
-
-/**
- * @param {number} i
- * @param {flatbuffers.ByteBuffer} bb
- * @returns {NetEncoding.JSONEncodedArray}
- */
-NetEncoding.JSONEncodedArray.prototype.__init = function(i, bb) {
-  this.bb_pos = i;
-  this.bb = bb;
-  return this;
-};
-
-/**
- * @param {flatbuffers.ByteBuffer} bb
- * @param {NetEncoding.JSONEncodedArray=} obj
- * @returns {NetEncoding.JSONEncodedArray}
- */
-NetEncoding.JSONEncodedArray.getRootAsJSONEncodedArray = function(bb, obj) {
-  return (obj || new NetEncoding.JSONEncodedArray).__init(bb.readInt32(bb.position()) + bb.position(), bb);
-};
-
-/**
- * @param {number} index
- * @returns {number}
- */
-NetEncoding.JSONEncodedArray.prototype.data = function(index) {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.readUint8(this.bb.__vector(this.bb_pos + offset) + index) : 0;
-};
-
-/**
- * @returns {number}
- */
-NetEncoding.JSONEncodedArray.prototype.dataLength = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
-};
-
-/**
- * @returns {Uint8Array}
- */
-NetEncoding.JSONEncodedArray.prototype.dataArray = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? new Uint8Array(this.bb.bytes().buffer, this.bb.bytes().byteOffset + this.bb.__vector(this.bb_pos + offset), this.bb.__vector_len(this.bb_pos + offset)) : null;
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- */
-NetEncoding.JSONEncodedArray.startJSONEncodedArray = function(builder) {
-  builder.startObject(1);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} dataOffset
- */
-NetEncoding.JSONEncodedArray.addData = function(builder, dataOffset) {
-  builder.addFieldOffset(0, dataOffset, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {Array.<number>} data
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.JSONEncodedArray.createDataVector = function(builder, data) {
-  builder.startVector(1, data.length, 1);
-  for (var i = data.length - 1; i >= 0; i--) {
-    builder.addInt8(data[i]);
-  }
-  return builder.endVector();
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {number} numElems
- */
-NetEncoding.JSONEncodedArray.startDataVector = function(builder, numElems) {
-  builder.startVector(1, numElems, 1);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.JSONEncodedArray.endJSONEncodedArray = function(builder) {
-  var offset = builder.endObject();
-  return offset;
-};
-
-/**
- * @constructor
- */
-NetEncoding.Column = function() {
-  /**
-   * @type {flatbuffers.ByteBuffer}
-   */
-  this.bb = null;
-
-  /**
-   * @type {number}
-   */
-  this.bb_pos = 0;
-};
-
-/**
- * @param {number} i
- * @param {flatbuffers.ByteBuffer} bb
- * @returns {NetEncoding.Column}
- */
-NetEncoding.Column.prototype.__init = function(i, bb) {
-  this.bb_pos = i;
-  this.bb = bb;
-  return this;
-};
-
-/**
- * @param {flatbuffers.ByteBuffer} bb
- * @param {NetEncoding.Column=} obj
- * @returns {NetEncoding.Column}
- */
-NetEncoding.Column.getRootAsColumn = function(bb, obj) {
-  return (obj || new NetEncoding.Column).__init(bb.readInt32(bb.position()) + bb.position(), bb);
-};
-
-/**
- * @returns {NetEncoding.TypedArray}
- */
-NetEncoding.Column.prototype.uType = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? /** @type {NetEncoding.TypedArray} */ (this.bb.readUint8(this.bb_pos + offset)) : NetEncoding.TypedArray.NONE;
-};
-
-/**
- * @param {flatbuffers.Table} obj
- * @returns {?flatbuffers.Table}
- */
-NetEncoding.Column.prototype.u = function(obj) {
-  var offset = this.bb.__offset(this.bb_pos, 6);
-  return offset ? this.bb.__union(obj, this.bb_pos + offset) : null;
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- */
-NetEncoding.Column.startColumn = function(builder) {
-  builder.startObject(2);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {NetEncoding.TypedArray} uType
- */
-NetEncoding.Column.addUType = function(builder, uType) {
-  builder.addFieldInt8(0, uType, NetEncoding.TypedArray.NONE);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} uOffset
- */
-NetEncoding.Column.addU = function(builder, uOffset) {
-  builder.addFieldOffset(1, uOffset, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Column.endColumn = function(builder) {
-  var offset = builder.endObject();
-  return offset;
-};
-
-/**
- * @constructor
- */
-NetEncoding.Matrix = function() {
-  /**
-   * @type {flatbuffers.ByteBuffer}
-   */
-  this.bb = null;
-
-  /**
-   * @type {number}
-   */
-  this.bb_pos = 0;
-};
-
-/**
- * @param {number} i
- * @param {flatbuffers.ByteBuffer} bb
- * @returns {NetEncoding.Matrix}
- */
-NetEncoding.Matrix.prototype.__init = function(i, bb) {
-  this.bb_pos = i;
-  this.bb = bb;
-  return this;
-};
-
-/**
- * @param {flatbuffers.ByteBuffer} bb
- * @param {NetEncoding.Matrix=} obj
- * @returns {NetEncoding.Matrix}
- */
-NetEncoding.Matrix.getRootAsMatrix = function(bb, obj) {
-  return (obj || new NetEncoding.Matrix).__init(bb.readInt32(bb.position()) + bb.position(), bb);
-};
-
-/**
- * @returns {number}
- */
-NetEncoding.Matrix.prototype.nRows = function() {
-  var offset = this.bb.__offset(this.bb_pos, 4);
-  return offset ? this.bb.readUint32(this.bb_pos + offset) : 0;
-};
-
-/**
- * @returns {number}
- */
-NetEncoding.Matrix.prototype.nCols = function() {
-  var offset = this.bb.__offset(this.bb_pos, 6);
-  return offset ? this.bb.readUint32(this.bb_pos + offset) : 0;
-};
-
-/**
- * @param {number} index
- * @param {NetEncoding.Column=} obj
- * @returns {NetEncoding.Column}
- */
-NetEncoding.Matrix.prototype.columns = function(index, obj) {
-  var offset = this.bb.__offset(this.bb_pos, 8);
-  return offset ? (obj || new NetEncoding.Column).__init(this.bb.__indirect(this.bb.__vector(this.bb_pos + offset) + index * 4), this.bb) : null;
-};
-
-/**
- * @returns {number}
- */
-NetEncoding.Matrix.prototype.columnsLength = function() {
-  var offset = this.bb.__offset(this.bb_pos, 8);
-  return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
-};
-
-/**
- * @returns {NetEncoding.TypedArray}
- */
-NetEncoding.Matrix.prototype.colIndexType = function() {
-  var offset = this.bb.__offset(this.bb_pos, 10);
-  return offset ? /** @type {NetEncoding.TypedArray} */ (this.bb.readUint8(this.bb_pos + offset)) : NetEncoding.TypedArray.NONE;
-};
-
-/**
- * @param {flatbuffers.Table} obj
- * @returns {?flatbuffers.Table}
- */
-NetEncoding.Matrix.prototype.colIndex = function(obj) {
-  var offset = this.bb.__offset(this.bb_pos, 12);
-  return offset ? this.bb.__union(obj, this.bb_pos + offset) : null;
-};
-
-/**
- * @returns {NetEncoding.TypedArray}
- */
-NetEncoding.Matrix.prototype.rowIndexType = function() {
-  var offset = this.bb.__offset(this.bb_pos, 14);
-  return offset ? /** @type {NetEncoding.TypedArray} */ (this.bb.readUint8(this.bb_pos + offset)) : NetEncoding.TypedArray.NONE;
-};
-
-/**
- * @param {flatbuffers.Table} obj
- * @returns {?flatbuffers.Table}
- */
-NetEncoding.Matrix.prototype.rowIndex = function(obj) {
-  var offset = this.bb.__offset(this.bb_pos, 16);
-  return offset ? this.bb.__union(obj, this.bb_pos + offset) : null;
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- */
-NetEncoding.Matrix.startMatrix = function(builder) {
-  builder.startObject(7);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {number} nRows
- */
-NetEncoding.Matrix.addNRows = function(builder, nRows) {
-  builder.addFieldInt32(0, nRows, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {number} nCols
- */
-NetEncoding.Matrix.addNCols = function(builder, nCols) {
-  builder.addFieldInt32(1, nCols, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} columnsOffset
- */
-NetEncoding.Matrix.addColumns = function(builder, columnsOffset) {
-  builder.addFieldOffset(2, columnsOffset, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {Array.<flatbuffers.Offset>} data
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Matrix.createColumnsVector = function(builder, data) {
-  builder.startVector(4, data.length, 4);
-  for (var i = data.length - 1; i >= 0; i--) {
-    builder.addOffset(data[i]);
-  }
-  return builder.endVector();
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {number} numElems
- */
-NetEncoding.Matrix.startColumnsVector = function(builder, numElems) {
-  builder.startVector(4, numElems, 4);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {NetEncoding.TypedArray} colIndexType
- */
-NetEncoding.Matrix.addColIndexType = function(builder, colIndexType) {
-  builder.addFieldInt8(3, colIndexType, NetEncoding.TypedArray.NONE);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} colIndexOffset
- */
-NetEncoding.Matrix.addColIndex = function(builder, colIndexOffset) {
-  builder.addFieldOffset(4, colIndexOffset, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {NetEncoding.TypedArray} rowIndexType
- */
-NetEncoding.Matrix.addRowIndexType = function(builder, rowIndexType) {
-  builder.addFieldInt8(5, rowIndexType, NetEncoding.TypedArray.NONE);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} rowIndexOffset
- */
-NetEncoding.Matrix.addRowIndex = function(builder, rowIndexOffset) {
-  builder.addFieldOffset(6, rowIndexOffset, 0);
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @returns {flatbuffers.Offset}
- */
-NetEncoding.Matrix.endMatrix = function(builder) {
-  var offset = builder.endObject();
-  return offset;
-};
-
-/**
- * @param {flatbuffers.Builder} builder
- * @param {flatbuffers.Offset} offset
- */
-NetEncoding.Matrix.finishMatrixBuffer = function(builder, offset) {
-  builder.finish(offset);
-};
-
-// Exports for ECMAScript6 Modules
-export {NetEncoding};

client/src/util/stateManager/summarizeAnnotations.js

@@ -1,5 +1,4 @@
 import _ from "lodash";
-import finiteExtent from "../finiteExtent";
 
 /*
 Build and return obs/var summary using any annotation in the schema
@@ -9,7 +8,6 @@ Value will be an object, containing summary information.
 
 For continuous annotations (int, float, etc):
   <annotation_name>: {
-    categorical: false,
     range {
       min: <number>,
       max: <number>
@@ -17,14 +15,12 @@ For continuous annotations (int, float, etc):
   }
 
 For categorical annotations (boolean, string, category):
-  <annotation_name>: {
-    categorical: true,
-    categories: [ <category1>, <category2>, ... ]
-    categoryCounts: Map {
-      <category1>: <number>,
+  <annotatoin_name>: {
+    options: {
+      <option1>: <number>,
       ...
     },
-    numCategories: <number>
+    numOptions: <number>
   }
 
 Summarize will be returned for BOTH obs and var annotations.
@@ -32,19 +28,19 @@ Summarize will be returned for BOTH obs and var annotations.
 Example:
   {
     "Splice_sites_Annotated": {
-      categorical: false,
-      range: {
+      "range": {
         "min": 26,
         "max": 1075869
       }
     },
     "Selection": {
-      categorical: true,
-      numCategories, 3,
-      categories: [ "Astrocytes(HEPACAM)", "Endothelial(BSC)", "Unpanned" ],
-      categoryCounts: Map {
+      numOptions, 6,
+      "options": {
         "Astrocytes(HEPACAM)": 714,
         "Endothelial(BSC)": 123,
+        "Oligodendrocytes(GC)": 294,
+        "Neurons(Thy1)": 685,
+        "Microglia(CD45)": 1108,
         "Unpanned": 665
       }
     }
@@ -52,62 +48,46 @@ Example:
 
 NOTE: will not summarize the required 'name' annotation, as that is
 specified as unique per element.
+
+TODO: XXX - this data structure coerces all metadata categories into a string
+(ie, stores values as an Object property in the `options` field).   This looses
+information (eg, type) for category types which are not strings.  Consider an
+alterative data structure that does not use the object property for non-string
+data types (and does not use _.countBy to summarize).
 */
-function _summarizeAnnotations(_schema, annotations) {
-  const summary = _(_schema) // lodash wrapping: https://lodash.com/docs/4.17.11#lodash
+function summarizeDimension(schema, annotations) {
+  return _(schema)
     .filter(v => v.name !== "name")
     .keyBy("name")
     .mapValues(anno => {
       const { name, type } = anno;
       const continuous = type === "int32" || type === "float32";
 
-      if (continuous) {
-        let min;
-        let max;
-        let nan = 0;
-        let pinf = 0;
-        let ninf = 0;
-        for (let r = 0; r < annotations.length; r += 1) {
-          const val = Number(annotations[r][name]);
-          if (Number.isFinite(val)) {
-            if (min === undefined) {
-              min = val;
-              max = val;
-            } else {
-              min = val < min ? val : min;
-              max = val > max ? val : max;
-            }
-          } else if (Number.isNaN(val)) {
-            nan += 1;
-          } else if (val > 0) {
-            pinf += 1;
-          } else {
-            ninf += 1;
-          }
-        }
+      if (!continuous) {
+        const categories = _.uniq(_.flatMap(annotations, name));
+        const options = _.countBy(annotations, name);
+        const numOptions = _.size(options);
         return {
-          categorical: false,
-          range: { min, max, nan, pinf, ninf }
+          numOptions,
+          options,
+          categories
         };
       }
 
-      /* else categorical */
-      const categoryCounts = new Map();
-      for (let r = 0; r < annotations.length; r += 1) {
-        const val = annotations[r][name];
-        let curCount = categoryCounts.get(val);
-        if (curCount === undefined) curCount = 0;
-        categoryCounts.set(val, curCount + 1);
+      if (continuous) {
+        let min = Number.POSITIVE_INFINITY;
+        let max = Number.NEGATIVE_INFINITY;
+        _.forEach(annotations, obs => {
+          const val = Number(obs[name]);
+          min = val < min ? val : min;
+          max = val > max ? val : max;
+        });
+        return { range: { min, max } };
       }
-      return {
-        categorical: true,
-        categories: [...categoryCounts.keys()],
-        categoryCounts,
-        numCategories: categoryCounts.size
-      };
+
+      throw new Error("incomprehensible schema");
     })
     .value();
-  return summary;
 }
 
 export default function summarizeAnnotations(
@@ -116,7 +96,7 @@ export default function summarizeAnnotations(
   varAnnotations
 ) {
   return {
-    obs: _summarizeAnnotations(schema.annotations.obs, obsAnnotations),
-    var: _summarizeAnnotations(schema.annotations.var, varAnnotations)
+    obs: summarizeDimension(schema.annotations.obs, obsAnnotations),
+    var: summarizeDimension(schema.annotations.var, varAnnotations)
   };
 }

client/src/util/stateManager/universe.js

@@ -1,10 +1,8 @@
 // jshint esversion: 6
 
 import _ from "lodash";
-
 import * as kvCache from "./keyvalcache";
 import summarizeAnnotations from "./summarizeAnnotations";
-import decodeMatrixFBS from "./matrix";
 
 /*
 Private helper function - create and return a template Universe
@@ -94,40 +92,73 @@ function finalize(universe) {
   return universe;
 }
 
-function RESTv02AnotationsFBSResponseToInternal(arrayBuffer) {
+function RESTv02AnnotationsResponseToInternal(response) {
   /*
-  Convert a Matrix FBS to our internal format -- row-major array of
-  observations/cells, stored as an object.  Each obs has a key for each
-  annotation, plus __index__ containing its obsIndex.
+  Source per the spec:
+  {
+    names: [
+      'tissue_type', 'sex', 'num_reads', 'clusters'
+    ],
+    data: [
+      [ 0, 'lung', 'F', 39844, 99 ],
+      [ 1, 'heart', 'M', 83, 1 ],
+      [ 49, 'spleen', null, 2, "unknown cluster" ],
+      // [ obsOrVarIndex, value, value, value, value ],
+      // ...
+    ]
+  }
 
-  Example:
+  Internal (target) format:
   [
     { __index__: 0, tissue_type: "lung", sex: "F", ... },
     ...
   ]
-
-  XXX TODO: we could make use of the columns in building crossfilter
-  dimensions (they have to be recreated).  Future optimization.
   */
-  const fbs = decodeMatrixFBS(arrayBuffer);
-  const keys = fbs.colIdx;
-  const result = Array(fbs.nRows);
-  for (let row = 0; row < fbs.nRows; row += 1) {
-    const rec = { __index__: row };
-    for (let col = 0; col < fbs.nCols; col += 1) {
-      rec[keys[col]] = fbs.columns[col][row];
-    }
-    result[row] = rec;
-  }
-  return result;
+  const { names, data } = response;
+  const keys = ["__index__", ...names];
+  return _(data)
+    .map(obs => _.zipObject(keys, obs))
+    .value();
 }
 
-function RESTv02LayoutFBSResponseToInternal(arrayBuffer) {
-  const fbs = decodeMatrixFBS(arrayBuffer, true);
-  return {
-    X: fbs.columns[0],
-    Y: fbs.columns[1]
+function RESTv02LayoutResponseToInternal(response) {
+  /*
+  Source per the spec:
+  {
+    layout: {
+      ndims: 2,
+      coordinates: [
+        [ 0, 0.284483, 0.983744 ],
+        [ 1, 0.038844, 0.739444 ],
+        // [ obsOrVarIndex, X_coord, Y_coord ],
+        // ...
+      ]
+    }
+  }
+
+  Target (internal) format:
+  {
+    X: Float32Array(numObs),
+    Y: Float32Array(numObs)
+  }
+  In the same order as obsAnnotations
+  */
+  const { ndims, coordinates } = response.layout;
+  if (ndims !== 2) {
+    throw new Error("Unsupported layout dimensionality");
+  }
+
+  const layout = {
+    X: new Float32Array(coordinates.length),
+    Y: new Float32Array(coordinates.length)
   };
+
+  for (let i = 0; i < coordinates.length; i += 1) {
+    const [idx, x, y] = coordinates[i];
+    layout.X[idx] = x;
+    layout.Y[idx] = y;
+  }
+  return layout;
 }
 
 function reconcileSchemaCategoriesWithSummary(universe) {
@@ -161,7 +192,7 @@ export function createUniverseFromRestV02Response(
   schemaResponse,
   annotationsObsResponse,
   annotationsVarResponse,
-  layoutFBSResponse
+  layoutObsResponse
 ) {
   /*
   build & return universe from a REST 0.2 /config, /schema and /annotations/obs response
@@ -178,15 +209,15 @@ export function createUniverseFromRestV02Response(
   universe.nVar = schema.dataframe.nVar;
 
   /* annotations */
-  universe.obsAnnotations = RESTv02AnotationsFBSResponseToInternal(
+  universe.obsAnnotations = RESTv02AnnotationsResponseToInternal(
     annotationsObsResponse
   );
-  universe.varAnnotations = RESTv02AnotationsFBSResponseToInternal(
+  universe.varAnnotations = RESTv02AnnotationsResponseToInternal(
     annotationsVarResponse
   );
 
   /* layout */
-  universe.obsLayout = RESTv02LayoutFBSResponseToInternal(layoutFBSResponse);
+  universe.obsLayout = RESTv02LayoutResponseToInternal(layoutObsResponse);
 
   universe.summary = summarizeAnnotations(
     universe.schema,
@@ -198,24 +229,32 @@ export function createUniverseFromRestV02Response(
   return finalize(universe);
 }
 
-export function convertDataFBStoObject(universe, arrayBuffer) {
+export function convertExpressionRESTv02ToObject(universe, response) {
   /*
-  /data/var returns a flatbuffer (FBS) as described by cellxgene/fbs/matrix.fbs
-
-  This routine converts the binary wire encoding into a JS object:
-
+  /data/obs response looks like:
   {
-    gene: Float32Array,
-    ...
+    var: [ varIndices fetched ],
+    obs: [
+      [ obsIndex, evalue, ... ],
+      ...
+    ]
   }
-  */
-  const fbs = decodeMatrixFBS(arrayBuffer);
-  const { colIdx, columns } = fbs;
-  const result = {};
 
-  for (let c = 0; c < colIdx.length; c += 1) {
-    const gene = universe.varAnnotations[colIdx[c]].name;
-    result[gene] = columns[c];
+  convert expression toa simple Float32Array, and return
+  { geneName: array, geneName: array, ... }
+  NOTE: geneName, not varIndex
+  */
+  const vars = response.var;
+  const { obs } = response;
+  const result = {};
+  // XXX TODO: could this use _.unzip and have less code?
+  for (let varIdx = 0; varIdx < vars.length; varIdx += 1) {
+    const gene = universe.varAnnotations[vars[varIdx]].name;
+    const data = new Float32Array(universe.nObs);
+    for (let obsIdx = 0; obsIdx < obs.length; obsIdx += 1) {
+      data[obsIdx] = obs[obsIdx][varIdx + 1];
+    }
+    result[gene] = data;
   }
   return result;
 }

client/src/util/stateManager/worldUtil.js

@@ -1,65 +0,0 @@
-/* eslint-disable import/prefer-default-export */
-import _ from "lodash";
-
-/*
-Various utility functions operating on World/Universe
-*/
-
-/*
-Count unique category values, binning first by dim1 then by dim2
-Return:
-
-Map {
-   dim1_val1: Map {
-      dim2_val1: number,
-      dim2_val2: number,
-      ...
-   },
-   ...
-}
-
-*/
-function _countCategoryValues2D(dim1, dim2, rows) {
-  const dimMap = new Map();
-  for (let r = 0; r < rows.length; r += 1) {
-    const row = rows[r];
-    const val1 = row[dim1];
-    const val2 = row[dim2];
-    let d2Map = dimMap.get(val1);
-    if (d2Map === undefined) {
-      d2Map = new Map();
-      dimMap.set(val1, d2Map);
-    }
-    let curCount = d2Map.get(val2);
-    if (curCount === undefined) {
-      curCount = 0;
-    }
-    d2Map.set(val2, curCount + 1);
-  }
-  return dimMap;
-}
-
-let __worldUtilMemoId__ = 0;
-function _memoizedId(x) {
-  if (!x.__worldUtilMemoId__) {
-    __worldUtilMemoId__ += 1;
-    x.__worldUtilMemoId__ = __worldUtilMemoId__;
-  }
-  return x.__worldUtilMemoId__;
-}
-function _countCategoryValues2DResolver(...args) {
-  const id = args[0] + args[1] + _memoizedId(args[2]);
-  return id;
-}
-
-export const countCategoryValues2D = _.memoize(
-  _countCategoryValues2D,
-  _countCategoryValues2DResolver
-);
-
-/*
-Clear any cached data within WorldUtil caches, eg, memoized functions
-*/
-export function clearCaches() {
-  countCategoryValues2D.cache.clear();
-}

dev_docs/pull_request_guidelines.md

@@ -1,35 +0,0 @@
-## Creating PR
-1. Name [username]/branchname 
-    1. Branch name should be all lowercase
-    2. Words separated by “-”
-2. Code should address only one issue ideally, make a separate PR for each task
-3. Description 
-    1. Clear explanation of issues solved
-    2. Describe why and how, when appropriate
-    3. Call out specific areas you want extra attention in review (optional)
-    4. If your PR requires more than one reviewer tag those people in the description or comments and let them know that you specifically require them
-4. Ensure that the PR updates tests and documentation and adds tests where appropriate
-5. Use github’s issue keywords when PR is addressing an issue https://help.github.com/articles/closing-issues-using-keywords/
-6. Tags (add at beginning of title)
-    1. [EASY] - small non-controversial change, easy to review
-    2. [DO NOT MERGE] - PR is in progress, do not merge changes
-
-## Review
-1. Assign at least one reviewer to submitted PRs.   Reviewers should be selected based on expertise in areas affected by the PR (eg, web UI: Colin), and should include Comp Bio and PM as needed.
-2. Reviewers should approve or request changes (not just comment) and put general and line level comments where appropriate
-3. As a PR submitter respond to all comments (eg, comment, commit a change, etc)
-4. External PRs
-    1. For external PRs or PRs not from our core team, core team should assign a reviewer and make initial contact within 1 business day
-    2. Build code on local environment and run smoke tests 
-
-## Required to Merge
-1. Travis CI Build passing
-2. At least one reviewer approved
-    1. Exceptions: 
-        1. Release PRs where version is just bumped should not need review
-        2. Complex PRs which touch multiple parts of the codebase should have reviews from all relevant parties
-3. License and Security checks (SNYK) passing. If their server is down and you didn’t add any new external npm or python packages, merge is OK
-
-## Merging
-1. Use "squash and merge" option when merging
-2. If you resolved conflicts, wait until the build passes to merge

docs/Gemfile

@@ -1,2 +0,0 @@
-source 'https://rubygems.org'
-gem "github-pages", group: :jekyll_plugins

docs/REST_API.md

@@ -1,7 +1,5 @@
 # cellxgene REST API 0.2 specification
 
-_Note:_ this document lacks any information about the binary encoding utilized by various routes. This will be added at a later date.
-
 Items marked as (_future_) are intended for future implementation, and are included in the design to round out the concept, and highlight what we would do when/if we needed more functionality. The (_future_) items are not currently used by the cellxgene web application, and may be omitted from any backend - see [Current Front-End Dependencies](#current-front-end-dependencies) for more details.
 
 _Caveat emptor, partial spec_: this is a sketch for a spec, not a full spec, and some shortcuts have been taken in the authorship. Best practices for a REST API are assumed but not documented here, such as API versioning, reasonable choices for HTTP response codes, etc. In addition, for clarity the JSON examples will not always have all required quoting (eg, on keys) - the actual implementation should use legal JSON/CSV.

docs/_config.yml

@@ -1,10 +0,0 @@
-theme: jekyll-theme-cayman
-show_downloads: false
-
-nav:
-  - title: Home
-    url: /
-  - title: Data
-    url: data.html
-  - title: FAQ
-    url: faq.html

docs/_layouts/default.html

@@ -1,48 +0,0 @@
-<!DOCTYPE html>
-<html lang="{{ site.lang | default: "en-US" }}">
-  <head>
-
-    {% if site.google_analytics %}
-      <script async src="https://www.googletagmanager.com/gtag/js?id={{ site.google_analytics }}"></script>
-      <script>
-        window.dataLayer = window.dataLayer || [];
-        function gtag(){dataLayer.push(arguments);}
-        gtag('js', new Date());
-        gtag('config', '{{ site.google_analytics }}');
-      </script>
-    {% endif %}
-    <meta charset="UTF-8">
-
-{% seo %}
-    <meta name="viewport" content="width=device-width, initial-scale=1">
-    <meta name="theme-color" content="#157878">
-    <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">
-    <link rel="stylesheet" href="{{ '/assets/css/style.css?v=' | append: site.github.build_revision | relative_url }}">
-  </head>
-  <body>
-
-    <header class="page-header" role="banner">
-      <h1 class="project-name">{{ site.title | default: site.github.repository_name }}</h1>
-      <h2 class="project-tagline">{{ site.description | default: site.github.project_tagline }}</h2>
-      {% if site.nav %}
-        {% for item in site.nav %}
-          <a href="{{ item.url }}" class="btn">{{ item.title }}</a>
-        {% endfor %}
-      {% endif %}
-      {% if site.github.is_project_page %}
-        <a href="{{ site.github.repository_url }}" class="btn" target="_blank">Code</a>
-      {% endif %}
-    </header>
-
-    <main id="content" class="main-content" role="main">
-      {{ content }}
-
-      <footer class="site-footer">
-        {% if site.github.is_project_page %}
-          <span class="site-footer-owner"><a href="{{ site.github.repository_url }}">{{ site.github.repository_name }}</a> is maintained by <a href="{{ site.github.owner_url }}">{{ site.github.owner_name }}</a>.</span>
-        {% endif %}
-        <span class="site-footer-credits">This page was generated by <a href="https://pages.github.com">GitHub Pages</a>.</span>
-      </footer>
-    </main>
-  </body>
-</html>

docs/data.md

@@ -1,29 +0,0 @@
----
-layout: default
-title: data
-description: Data
----
-
-
-# data vignette: how to use cellxgene prepare
-
-#### coming soon!
-
-# example datasets to use with cellxgene
-
-### Examination of single cells from primary human pancreas tissue
-cells: 2,544  
-tissue(s): pancreas  
-data: [GEO Series GSE81547](https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GSE81547)  
-paper: [Enge, Martin, et al.](https://www.cell.com/cell/fulltext/S0092-8674(17)31053-X?_returnURL=https%3A%2F%2Flinkinghub.elsevier.com%2Fretrieve%2Fpii%2FS009286741731053X%3Fshowall%3Dtrue)
-
-### Tabula Muris
-cells: 53,800  
-tissue(s): muscle, pancreas, bone, large intestine, heart, brain, fat, mammary gland, tongue , diaphragm, bladder, spleen, thymus, lung , skin, liver, trachea, kidney  
-data: [Tabula Muris Data for Python](https://github.com/czbiohub/tabula-muris-vignettes/tree/master/data)  
-paper: [Tabula Muris Consortium.](https://www.nature.com/articles/s41586-018-0590-4)  
-
-### Transcriptional profiling of 1.3 million brain cells
-cells: 1,330,000  
-tissue(s): brain  
-data: [10x Genomics](https://community.10xgenomics.com/t5/10x-Blog/Our-1-3-million-single-cell-dataset-is-ready-to-download/ba-p/276)  

docs/faq.md

@@ -1,94 +0,0 @@
----
-layout: default
-title: FAQ
-description: Frequently Asked Questions
----
-
-# Data formatting
-
-#### What file formats can I use with _cellxgene_?
-
-Currently, you can go straight into `cellxgene launch` with your own analyzed data in h5ad format, after you have performed dimenstionality reduction (tsne, umap) and clustering (louvain).
-
-If your data is in a different format, and/or you still need to perform dimensionality reduction and clustering, `cellxgene` can do that for you with the `prepare` command. `cellxgene prepare` runs `scanpy` under the hood and can read in any format that is currently supported by `scanpy` (including mtx, loom, and more listed [here](https://scanpy.readthedocs.io/en/latest/api/index.html#reading)).
-
-The output of `cellxgene prepare` is a h5ad file with your computed clusters and tsne/umap projections that can be used in `cellxgene launch`.
-
-#### I have a directory of 10X-Genomics data with _mtx_ files and I've never used _scanpy_, can I use _cellxgene_?
-
-Yep! This should only take a couple steps. We'll assume your data is in a folder called `data/` and you've successfully installed `cellxgene` with the `louvain` packages as described above. Just run
-
-```
-cellxgene prepare data/ --output=data-processed.h5ad --layout=umap
-```
-
-Depending on the size of the dataset, this may take some time. Once it's done, call
-
-```
-cellxgene launch data-processed.h5ad --layout=umap --open
-```
-
-And your web browser should open with an interactive view of your data.
-
-#### I have extra metadata that I want to add to my dataset
-
-Currently this is not supported directly, but you should be able to do this yourself using `scanpy`. For example, this [notebook](https://github.com/falexwolf/fun-analyses/blob/master/tabula_muris/tabula_muris.ipynb) shows adding the contents of a `csv` file with metadata to an `anndata` object. For now, you could do this manually on your data in the same way and then save out the result before loading into `cellxgene`.
-
-#### What part of the _anndata_ objects does cellxgene pull in for visualization?
-
-- `.obs` and `.var` annotations are use to extract metadata for filtering
-- `.X` is used to display expression (histograms, scatterplot & colorscale) and to compute differential expression
-- `.obsm` is used for layout
-
-# Algorithms
-
-#### How are you computing and sorting differential expression results?
-
-We use a [Welch's _t_-test](https://en.wikipedia.org/wiki/Welch%27s_t-test) implementation including the same variance overestimation correction as used in `scanpy`. We sort the `tscore` to identify the top N genes, and then filter to remove any that fall below a cutoff log fold change value, which can help remove spurious test results. The default threshold is `0.01` and can be changed using the option `--diffexp-lfc-cutoff`.
-
-# Problems, errors, & bugs
-
-#### How do I create a Python 3.6 environment for _cellxgene_?
-
-If you use conda and want to create a [conda environment](https://conda.io/docs/user-guide/tasks/manage-environments.html) for _cellxgene_ you can use the following commands
-
-```
-conda create --yes -n cellxgene python=3.6
-conda activate cellxgene
-pip install cellxgene
-```
-
-Or you can create a virtual environment by using
-
-```
-ENV_NAME=cellxgene
-python3.6 -m venv ${ENV_NAME}
-source ${ENV_NAME}/bin/activate
-pip install cellxgene
-```
-
-#### In my _prepare_ command I received the following error `Warning: louvain module is not installed, no clusters will be calculated. To fix this please install cellxgene with the optional feature louvain enabled`
-
-Louvain clustering requires additional dependencies, so we don't include them by default. For now, you need to specify that you want these packages by using
-
-```
-pip install cellxgene[louvain]
-```
-
-#### I ran _prepare_ and I'm getting results that look unexpected
-
-You might want to try running one of the preprocessing recipes included with `scanpy` (read more about them [here](https://scanpy.readthedocs.io/en/latest/api/index.html#recipes)). You can specify this with the `--recipe` option, such as
-
-```
-cellxgene prepare data/ --output=data-processed.h5ad --recipe=zheng17
-```
-
-It should be easy to run `prepare` then call `cellxgene launch` a few times with different settings to explore different behaviors. We may explore adding other preprocessing options in the future.
-
-#### I tried to `pip install cellxgene` and got a weird error I don't understand
-
-This may happen, especially as we work out bugs in our installation process! Please create a new [Github issue](https://github.com/chanzuckerberg/cellxgene/issues), explain what you did, and include all the error messages you saw. It'd also be super helpful if you call `pip freeze` and include the full output alongside your issue.
-
-#### I'm following the developer instructions and get an error about "missing files and directories” when trying to build the client
-
-This is likely because you do not have node and npm installed, we recommend using [nvm](https://github.com/creationix/nvm) if you're new to using these tools.

docs/index.md

@@ -1,37 +0,0 @@
-_cellxgene_ is an interactive data explorer for single-cell transcriptomics data. Whether you need to visualize one thousand cells or one million, _cellxgene_ helps you gain insight into your single-cell data.
-
-## features
-
-#### Flexible selections, coloring, and differential expression of your selected sets of cells
-<img src="diffexp.gif" width="600"/>
-
-#### Single-gene analyses (e.g. expression analysis)
-<img src="customGene.gif" width="600" />
-
-## getting started
-
-_cellxgene_ **only** supports Python 3.6. We recommend [installing _cellxgene_ into a conda or virtual environment.](/faq.html#how-do-i-create-a-python-36-environment-for-cellxgene)
-
-Install the package.
-``` bash
-pip install cellxgene
-```
-
-Download an example [anndata](https://anndata.readthedocs.io/en/latest/) file
-
-``` bash
-curl -o pbmc3k.h5ad https://raw.githubusercontent.com/chanzuckerberg/cellxgene/master/example-dataset/pbmc3k.h5ad
-```
-
-Launch _cellxgene_
-``` bash
-cellxgene launch pbmc3k.h5ad
-```
-
-## getting help
-
-We'd love to hear from you!
-
-For questions, suggestions, or accolades, [join the `#cellxgene-users` channel on the CZI Science Slack](https://join-cziscience-slack.herokuapp.com/) and say "hi!".
-
-For any errors, [report bugs on Github](https://github.com/chanzuckerberg/cellxgene/issues).

docs/release_process.md

@@ -14,40 +14,35 @@ The release process should result in the following side-effects:
 - Tagged github release
 - Publication to PyPi
 
-## Recipe
+## Process
 
 Follow these steps to create a release.
 
 1.  Preparation:
-    - python3.6 environment, and a cellxgene clone
-    - install required tools: `pip install -r requirements-dev.txt`
-    - Define the release version number, using [semantic versioning](https://semver.org/),
-      and specifying all three digits (eg, 0.3.0)
-    - Write the release title and release notes and add to
-      [release notes document](https://docs.google.com/document/d/1KnHwkYfhyWO5H8BDcMu7y3ogjvq5Yi4OwpmZ8DB6w0Y/edit)
+    - Define the release version number, using [semantic versioning](https://semver.org/)
+    - Write the release title and release notes and add to 
+    [release notes document](https://docs.google.com/document/d/1KnHwkYfhyWO5H8BDcMu7y3ogjvq5Yi4OwpmZ8DB6w0Y/edit)
 2.  Create a release branch, eg, `release-version`
 3.  In the release branch:
-    - Run `bumpversion --config-file .bumpversion.cfg [major | minor | patch]`,
-      where you choose major/minor/patch depending on which part of the version
-      is being bumped (eg, 0.2.9->0.3 is minor).
+    - Run `bumpversion --config-file .bumpversion.cfg [major | minor | patch]`
     - Clean up existing environment using `bin/clean`
     - Build the JS asserts using `bin/build-client`
 4.  Commit and push the new branch
 5.  Create a PR for the release.
     - [optional] As needed, conduct PR review.
 6.  Merge to master
-7.  Create Github release using the version number and release notes
-    ([instructions](https://help.github.com/articles/creating-releases/)).
+7.  Create Github release using the version number and release notes 
+([instructions](https://help.github.com/articles/creating-releases/)).
     - Draft new release
     - Type version name matching release version number from (1)
     - Select `master` as release branch (ensure you merged the release PR)
     - Type title `Release {version num}`
     - [optional] Check pre-release if this release is not ready for production
     - Publish Release
-8.  Publish to pypi by performing the following steps (assumes you have `setuptools`
-    and `twine` installed, that you have registered for pypi, and that you have
-    write access to the cellxgene pypi package):
-    - Build the distribution by calling `python setup.py sdist`
+8.  Publish to pypi by performing the following steps (assumes you have `setuptools` and `twine` installed and that you 
+have registered for pypi and have write access to the cellxgene pypi package)
+    - Build the distribution by calling
+    `python setup.py sdist`
       inside the top-level directory
     - [optional] Upload the package to test pypi
       `twine upload --repository-url https://test.pypi.org/legacy/ dist/*`

fbs/matrix.fbs

@@ -1,73 +0,0 @@
-
-/*
-
-  Flatbuffers schema for use in cellxgene wire-format.
-
-  Schema defines a general purpose, polymorphic, 2D matrix.  Data is
-  organized in a columnar layout.   Each column is homomorphic, and
-  several column types are supported:
-    - IEEE 32 and 64 bit floats
-    - signed and unsigned 32 bit integers
-    - JSON/UTF8 encoded array (for other types)
-
-  https://github.com/google/flatbuffers
-  http://google.github.io/flatbuffers/
-
-  NOTE: IF YOU MODIFY THIS FILE, YOU MUST RECOMPILE AND COMMIT
-  RESULTING FILES TO THE REPO:
-  * server/app/util/fbs/NetEncoding/*
-  * client/src/util/stateManager/matrix_generated.js
-
-*/
-
-namespace NetEncoding;
-
-table Float32Array {
-  data: [float32];
-}
-
-table Uint32Array {
-  data: [uint32];
-}
-
-table Int32Array {
-  data: [int32];
-}
-
-table Float64Array {
-  data: [float64];
-}
-
-table JSONEncodedArray {
-  // contains a UTF-8/JSON encoded array.  Used to store other
-  // types (or polymorphic arrays)
-  data: [uint8];
-}
-
-union TypedArray {
-  Float32Array,
-  Int32Array,
-  Uint32Array,
-  Float64Array,
-  JSONEncodedArray
-}
-
-// Extra level of indirection required because vector of union not yet supported
-table Column {
-  u: TypedArray;
-}
-
-// 2D matrix stored in columnar layout
-//
-table Matrix {
-  n_rows: uint32;     // all columns have this length
-  n_cols: uint32;     // same as columns.length
-  columns: [Column];  // length n_cols
-
-  // optional row and column index, with same length as corresponding dimension.
-  // If null, defaults to numeric index, ie, [0, n_rows) or [0, n_cols)
-  col_index: TypedArray;
-  row_index: TypedArray;
-}
-
-root_type Matrix;

server/__main__.py

@@ -2,14 +2,11 @@
 if __package__ is None:
     import sys
     from pathlib import Path
-
     PKG_PATH = Path(__file__).parent
     sys.path.insert(0, str(PKG_PATH.parent))
-    import server # noqa F401
-
+    import server
     __package__ = PKG_PATH.name
 
 # Main thing
-from .cli.cli import cli # noqa F402
-
+from .cli.cli import cli
 cli()

server/app/app.py

@@ -14,14 +14,16 @@ REACTIVE_LIMIT = 1_000_000
 
 app = Flask(__name__, static_folder="web/static")
 app.json_encoder = Float32JSONEncoder
-cache = Cache(app, config={"CACHE_TYPE": "simple", "CACHE_DEFAULT_TIMEOUT": 860_000})
+cache = Cache(app, config={"CACHE_TYPE": "simple", "CACHE_DEFAULT_TIMEOUT": 860000})
 Compress(app)
 CORS(app)
 
 # Config
 SECRET_KEY = os.environ.get("CXG_SECRET_KEY", default="SparkleAndShine")
 
-app.config.update(SECRET_KEY=SECRET_KEY)
+app.config.update(
+    SECRET_KEY=SECRET_KEY,
+)
 
 # Application Data
 data = None
@@ -34,13 +36,7 @@ docs.append(resources.get_swagger_doc())
 app.register_blueprint(webapp.bp)
 app.register_blueprint(resources.blueprint)
 app.register_blueprint(
-    get_swagger_blueprint(
-        docs,
-        "/api/swagger",
-        produces=["application/json"],
-        title="cellxgene rest api",
-        description="An API connecting ExpressionMatrix2 clustering algorithm to cellxgene",
-    )
-)
+    get_swagger_blueprint(docs, "/api/swagger", produces=["application/json"], title="cellxgene rest api",
+                          description="An API connecting ExpressionMatrix2 clustering algorithm to cellxgene"))
 
 app.add_url_rule("/", endpoint="index")

server/app/driver/driver.py

@@ -11,6 +11,7 @@ Sort order for methods
 
 
 class CXGDriver(metaclass=ABCMeta):
+
     def __init__(self, data, args):
         self.data = self._load_data(data)
         self.layout_method = args["layout"]
@@ -23,8 +24,11 @@ class CXGDriver(metaclass=ABCMeta):
     def features(self):
         features = {
             "cluster": {"available": False},
-            "layout": {"obs": {"available": False}, "var": {"available": False}},
-            "diffexp": {"available": False},
+            "layout": {
+                "obs": {"available": False},
+                "var": {"available": False},
+            },
+            "diffexp": {"available": False}
         }
         # TODO - Interactive limit should be generated from the actual available methods see GH issue #94
         if self.layout_method:
@@ -66,11 +70,6 @@ class CXGDriver(metaclass=ABCMeta):
         """
         pass
 
-    @abstractmethod
-    def annotation_to_fbs_matrix(self, axis, field=None):
-        """ Same as annotation(), except returns a flatbuffer, and does not support filtering. """
-        pass
-
     @abstractmethod
     def data_frame(self, filter, axis):
         """
@@ -84,10 +83,6 @@ class CXGDriver(metaclass=ABCMeta):
         """
         pass
 
-    @abstractmethod
-    def data_frame_to_fbs_matrix(self, filter, axis):
-        pass
-
     @abstractmethod
     def diffexp_topN(self, obsFilter1, obsFilter2, top_n=None, interactive_limit=None):
         """
@@ -113,8 +108,3 @@ class CXGDriver(metaclass=ABCMeta):
         :return:  [cellid, x, y, ...]
         """
         pass
-
-    @abstractmethod
-    def layout_to_fbs_matrix(self, filter):
-        """ same as layout, except returns a flatbuffer """
-        pass

server/app/scanpy_engine/diffexp.py

@@ -1,3 +1,4 @@
+
 import numpy as np
 from scipy import sparse, stats
 
@@ -9,31 +10,18 @@ def _mean_var_n(X):
     than naive methods (and same method used by numpy.var())
     https://en.wikipedia.org/wiki/Algorithms_for_calculating_variance#Two-pass
     """
-    # fp_err_occurred is a flag indicating that a floating point error
-    # occured somewhere in our compute.  Used to trigger non-finite
-    # number handling.
-    fp_err_occurred = False
+    n = X.shape[0]
+    if sparse.issparse(X):
+        mean = X.mean(axis=0).A1
+        dfm = X - mean
+        sumsq = np.sum(np.multiply(dfm, dfm), axis=0).A1
+        v = sumsq / (n - 1)
+    else:
+        mean = X.mean(axis=0)
+        dfm = X - mean
+        sumsq = np.sum(np.multiply(dfm, dfm), axis=0)
+        v = sumsq / (n - 1)
 
-    def fp_err_set(err, flag):
-        nonlocal fp_err_occurred
-        fp_err_occurred = True
-
-    with np.errstate(divide="call", invalid="call", call=fp_err_set):
-        n = X.shape[0]
-        if sparse.issparse(X):
-            mean = X.mean(axis=0).A1
-            dfm = X - mean
-            sumsq = np.sum(np.multiply(dfm, dfm), axis=0).A1
-            v = sumsq / (n - 1)
-        else:
-            mean = X.mean(axis=0)
-            dfm = X - mean
-            sumsq = np.sum(np.multiply(dfm, dfm), axis=0)
-            v = sumsq / (n - 1)
-
-    if fp_err_occurred:
-        mean[np.isfinite(mean) == False] = 0    # noqa: E712
-        v[np.isfinite(v) == False] = 0          # noqa: E712
     return mean, v, n
 
 
@@ -76,19 +64,19 @@ def diffexp_ttest(adata, maskA, maskB, top_n=8, diffexp_lfc_cutoff=0.01):
     sum_vn = vnA + vnB
 
     # degrees of freedom for Welch's t-test
-    with np.errstate(divide="ignore", invalid="ignore"):
-        dof = sum_vn ** 2 / (vnA ** 2 / (nA - 1) + vnB ** 2 / (nB - 1))
+    with np.errstate(divide='ignore', invalid='ignore'):
+        dof = sum_vn**2 / (vnA**2 / (nA - 1) + vnB**2 / (nB - 1))
     dof[np.isnan(dof)] = 1
 
     # Welch's t-test score calculation
-    with np.errstate(divide="ignore", invalid="ignore"):
+    with np.errstate(divide='ignore', invalid='ignore'):
         tscores = (meanA - meanB) / np.sqrt(sum_vn)
     tscores[np.isnan(tscores)] = 0
 
     # p-value
     pvals = stats.t.sf(np.abs(tscores), dof) * 2
     pvals_adj = pvals * adata._X.shape[1]
-    pvals_adj[pvals_adj > 1] = 1  # cap adjusted p-value at 1
+    pvals_adj[pvals_adj > 1] = 1        # cap adjusted p-value at 1
 
     # logfoldchanges: log2(meanA / meanB)
     logfoldchanges = np.log2(np.abs((meanA + 1e-9) / (meanB + 1e-9)))
@@ -118,5 +106,8 @@ def diffexp_ttest(adata, maskA, maskB, top_n=8, diffexp_lfc_cutoff=0.01):
     pvals_adj_top_n = pvals_adj[sort_order]
 
     # varIndex, logfoldchange, pval, pval_adj
-    result = [[sort_order[i], logfoldchanges_top_n[i], pvals_top_n[i], pvals_adj_top_n[i]] for i in range(top_n)]
+    result = [[sort_order[i],
+               logfoldchanges_top_n[i],
+               pvals_top_n[i],
+               pvals_adj_top_n[i]] for i in range(top_n)]
     return result

server/app/scanpy_engine/scanpy_engine.py

@@ -8,16 +8,8 @@ from scipy import sparse
 
 from server.app.driver.driver import CXGDriver
 from server.app.util.constants import Axis, DEFAULT_TOP_N
-from server.app.util.errors import (
-    FilterError,
-    InteractiveError,
-    JSONEncodingValueError,
-    PrepareError,
-    ScanpyFileError,
-)
-from server.app.util.utils import jsonify_scanpy
+from server.app.util.errors import FilterError, InteractiveError, PrepareError, ScanpyFileError
 from server.app.scanpy_engine.diffexp import diffexp_ttest
-from server.app.util.fbs.matrix import encode_matrix_fbs
 
 """
 Sort order for methods
@@ -30,6 +22,7 @@ Sort order for methods
 
 
 class ScanpyEngine(CXGDriver):
+
     def __init__(self, data, args):
         super().__init__(data, args)
         self._alias_annotation_names(Axis.OBS, args["obs_names"])
@@ -62,29 +55,21 @@ class ScanpyEngine(CXGDriver):
             df_axis.rename(inplace=True, columns={"index": "name"})
         elif name in df_axis.columns:
             if name not in df_axis.columns:
-                raise KeyError(
-                    f"Annotation name {name}, specified in --{ax_name}-name does not exist."
-                )
+                raise KeyError(f"Annotation name {name}, specified in --{ax_name}-name does not exist.")
             if not df_axis[name].is_unique:
-                raise KeyError(
-                    f"Values in -{ax_name}-name must be unique. "
-                    "Please prepare data to contain unique values."
-                )
+                raise KeyError(f"Values in -{ax_name}-name must be unique. "
+                               "Please prepare data to contain unique values.")
             # reset index to simple range; alias user-specified annotation to "name"
             df_axis.reset_index(drop=True, inplace=True)
             df_axis.rename(inplace=True, columns={name: "name"})
         else:
-            raise KeyError(
-                f"Annotation name {name}, specified in --{ax_name}_name does not exist."
-            )
+            raise KeyError(f"Annotation name {name}, specified in --{ax_name}_name does not exist.")
 
     @staticmethod
     def _can_cast_to_float32(ann):
         if ann.dtype.kind == "f":
             if not np.can_cast(ann.dtype, np.float32):
-                warnings.warn(
-                    f"Annotation {ann.name} will be converted to 32 bit float and may lose precision."
-                )
+                warnings.warn(f"Annotation {ann.name} will be converted to 32 bit float and may loose precision.")
             return True
         return False
 
@@ -103,9 +88,12 @@ class ScanpyEngine(CXGDriver):
             "dataframe": {
                 "nObs": self.cell_count,
                 "nVar": self.gene_count,
-                "type": str(self.data.X.dtype),
+                "type": str(self.data.X.dtype)
             },
-            "annotations": {"obs": [], "var": []},
+            "annotations": {
+                "obs": [],
+                "var": []
+            }
         }
         for ax in Axis:
             curr_axis = getattr(self.data, str(ax))
@@ -126,9 +114,7 @@ class ScanpyEngine(CXGDriver):
                     ann_schema["type"] = "categorical"
                     ann_schema["categories"] = curr_axis[ann].dtype.categories.tolist()
                 else:
-                    raise TypeError(
-                        f"Annotations of type {curr_axis[ann].dtype} are unsupported by cellxgene."
-                    )
+                    raise TypeError(f"Annotations of type {curr_axis[ann].dtype} are unsupported by cellxgene.")
                 self.schema["annotations"][ax].append(ann_schema)
 
     @staticmethod
@@ -139,41 +125,32 @@ class ScanpyEngine(CXGDriver):
         try:
             result = sc.read(data, cache=True)
         except ValueError:
-            raise ScanpyFileError(
-                "File must be in the .h5ad format. Please read "
-                "https://github.com/theislab/scanpy_usage/blob/master/170505_seurat/info_h5ad.md to "
-                "learn more about this format. You may be able to convert your file into this format "
-                "using `cellxgene prepare`, please run `cellxgene prepare --help` for more "
-                "information."
-            )
+            raise ScanpyFileError("File must be in the .h5ad format. Please read "
+                                  "https://github.com/theislab/scanpy_usage/blob/master/170505_seurat/info_h5ad.md to "
+                                  "learn more about this format. You may be able to convert your file into this format "
+                                  "using `cellxgene prepare`, please run `cellxgene prepare --help` for more "
+                                  "information.")
         except Exception as e:
-            raise ScanpyFileError(
-                f"Error while loading file: {e}, File must be in the .h5ad format, please check "
-                f"that your input and try again."
-            )
+            raise ScanpyFileError(f"Error while loading file: {e}, File must be in the .h5ad format, please check "
+                                  f"that your input and try again.")
         return result
 
     def _validate_data_types(self):
         if self.data.X.dtype != "float32":
-            warnings.warn(
-                f"Scanpy data matrix is in {self.data.X.dtype} format not float32. "
-                f"Precision may be truncated."
-            )
+            warnings.warn(f"Scanpy data matrix is in {self.data.X.dtype} format not float32. "
+                          f"Precision may be truncated.")
         for ax in Axis:
             curr_axis = getattr(self.data, str(ax))
             for ann in curr_axis:
                 datatype = curr_axis[ann].dtype
-                downcast_map = {
-                    "int64": "int32",
-                    "uint32": "int32",
-                    "uint64": "int32",
-                    "float64": "float32",
-                }
+                downcast_map = {"int64": "int32",
+                                "uint32": "int32",
+                                "uint64": "int32",
+                                "float64": "float32",
+                                }
                 if datatype in downcast_map:
-                    warnings.warn(
-                        f"Scanpy annotation {ax}:{ann} is in unsupported format: {datatype}. "
-                        f"Data will be downcast to {downcast_map[datatype]}."
-                    )
+                    warnings.warn(f"Scanpy annotation {ax}:{ann} is in unsupported format: {datatype}. "
+                                  f"Data will be downcast to {downcast_map[datatype]}.")
                 if isinstance(datatype, CategoricalDtype):
                     category_num = len(curr_axis[ann].dtype.categories)
                     if category_num > 500 and category_num > self.max_category_items:
@@ -181,8 +158,7 @@ class ScanpyEngine(CXGDriver):
                             f"{str(ax).title()} annotation '{ann}' has {category_num} categories, this may be "
                             f"cumbersome or slow to display. We recommend setting the "
                             f"--max-category-items option to 500, this will hide categorical "
-                            f"annotations with more than 500 categories in the UI"
-                        )
+                            f"annotations with more than 500 categories in the UI")
 
     def _validate_data_calculations(self):
         layout_key = f"X_{self.layout_method}"
@@ -194,8 +170,7 @@ class ScanpyEngine(CXGDriver):
                 f" layout may have been computed. The requested layout must be pre-calculated and saved "
                 f"back in the h5ad file. You can run "
                 f"`cellxgene prepare --layout {self.layout_method} <datafile>` "
-                f"to solve this problem. "
-            )
+                f"to solve this problem. ")
 
     def filter_dataframe(self, filter):
         """
@@ -216,7 +191,7 @@ class ScanpyEngine(CXGDriver):
 
     @staticmethod
     def _annotation_filter_to_mask(filter, d_axis, count):
-        mask = np.ones((count,), dtype=bool)
+        mask = np.ones((count, ), dtype=bool)
         for v in filter:
             if d_axis[v["name"]].dtype.name in ["boolean", "category", "object"]:
                 key_idx = np.in1d(getattr(d_axis, v["name"]), v["values"])
@@ -234,28 +209,24 @@ class ScanpyEngine(CXGDriver):
 
     @staticmethod
     def _index_filter_to_mask(filter, count):
-        mask = np.zeros((count,), dtype=bool)
+        mask = np.zeros((count, ), dtype=bool)
         for i in filter:
             if type(i) == list:
-                mask[i[0] : i[1]] = True
+                mask[i[0]:i[1]] = True
             else:
                 mask[i] = True
         return mask
 
     @staticmethod
     def _axis_filter_to_mask(filter, d_axis, count):
-        mask = np.ones((count,), dtype=bool)
+        mask = np.ones((count, ), dtype=bool)
         if "index" in filter:
-            mask = np.logical_and(
-                mask, ScanpyEngine._index_filter_to_mask(filter["index"], count)
-            )
+            mask = np.logical_and(mask, ScanpyEngine._index_filter_to_mask(filter["index"], count))
         if "annotation_value" in filter:
-            mask = np.logical_and(
-                mask,
-                ScanpyEngine._annotation_filter_to_mask(
-                    filter["annotation_value"], d_axis, count
-                ),
-            )
+            mask = np.logical_and(mask,
+                                  ScanpyEngine._annotation_filter_to_mask(filter["annotation_value"],
+                                                                          d_axis,
+                                                                          count))
         return mask
 
     def _filter_to_mask(self, filter, use_slices=True):
@@ -268,13 +239,9 @@ class ScanpyEngine(CXGDriver):
 
         if filter is not None:
             if Axis.OBS in filter:
-                obs_selector = self._axis_filter_to_mask(
-                    filter["obs"], self.data.obs, self.data.n_obs
-                )
+                obs_selector = self._axis_filter_to_mask(filter["obs"], self.data.obs, self.data.n_obs)
             if Axis.VAR in filter:
-                var_selector = self._axis_filter_to_mask(
-                    filter["var"], self.data.var, self.data.n_vars
-                )
+                var_selector = self._axis_filter_to_mask(filter["var"], self.data.var, self.data.n_vars)
         return obs_selector, var_selector
 
     @staticmethod
@@ -289,11 +256,8 @@ class ScanpyEngine(CXGDriver):
 
         https://docs.scipy.org/doc/scipy/reference/sparse.html
         """
-        prefer_row_access = (
-            sparse.isspmatrix_csr(data._X)
-            or sparse.isspmatrix_lil(data._X)
+        prefer_row_access = sparse.isspmatrix_csr(data._X) or sparse.isspmatrix_lil(data._X) \
             or sparse.isspmatrix_bsr(data._X)
-        )
         if prefer_row_access:
             # Row-major slicing
             if obs_selector is not None:
@@ -328,7 +292,7 @@ class ScanpyEngine(CXGDriver):
                 fields = obs.columns.tolist()
             result = {
                 "names": fields,
-                "data": DataFrame(obs[fields]).to_records(index=True).tolist(),
+                "data": DataFrame(obs[fields]).to_records(index=True).tolist()
             }
         else:
             var = self.data.var[var_selector]
@@ -336,21 +300,9 @@ class ScanpyEngine(CXGDriver):
                 fields = var.columns.tolist()
             result = {
                 "names": fields,
-                "data": DataFrame(var[fields]).to_records(index=True).tolist(),
+                "data": DataFrame(var[fields]).to_records(index=True).tolist()
             }
-        try:
-            return jsonify_scanpy(result)
-        except ValueError:
-            raise JSONEncodingValueError("Error encoding annotations to JSON")
-
-    def annotation_to_fbs_matrix(self, axis, fields=None):
-        if axis == Axis.OBS:
-            df = self.data.obs
-        else:
-            df = self.data.var
-        if fields is not None and len(fields) > 0:
-            df = df[fields]
-        return encode_matrix_fbs(df, col_idx=df.columns)
+        return result
 
     def data_frame(self, filter, axis):
         """
@@ -374,71 +326,27 @@ class ScanpyEngine(CXGDriver):
         if axis == Axis.OBS:
             result = {
                 "var": var_index_sliced.tolist(),
-                "obs": DataFrame(_X, index=obs_index_sliced)
-                .to_records(index=True)
-                .tolist(),
+                "obs": DataFrame(_X, index=obs_index_sliced).to_records(index=True).tolist()
             }
         else:
             result = {
                 "obs": obs_index_sliced.tolist(),
-                "var": DataFrame(_X.T, index=var_index_sliced)
-                .to_records(index=True)
-                .tolist(),
+                "var": DataFrame(_X.T, index=var_index_sliced).to_records(index=True).tolist()
             }
-        try:
-            return jsonify_scanpy(result)
-        except ValueError:
-            raise JSONEncodingValueError("Error encoding dataframe to JSON")
-
-    def data_frame_to_fbs_matrix(self, filter, axis):
-        """
-        Retrieves data 'X' and returns in a flatbuffer Matrix.
-        :param filter: filter: dictionary with filter params
-        :param axis: string obs or var
-        :return: flatbuffer Matrix
-
-        Caveats:
-        * currently only supports access on VAR axis
-        * currently only supports filtering on VAR axis
-        """
-        if axis != Axis.VAR:
-            raise ValueError("Only VAR dimension access is supported")
-        try:
-            obs_selector, var_selector = self._filter_to_mask(filter, use_slices=False)
-        except (KeyError, IndexError) as e:
-            raise FilterError(f"Error parsing filter: {e}") from e
-        if obs_selector is not None:
-            raise FilterError("filtering on obs unsupported")
-
-        # Currently only handles VAR dimension
-        X = self.data._X
-        if var_selector is not None:
-            X = X[:, var_selector]
-        return encode_matrix_fbs(X, col_idx=np.nonzero(var_selector)[0], row_idx=None)
+        return result
 
     def diffexp_topN(self, obsFilterA, obsFilterB, top_n=None, interactive_limit=None):
         if Axis.VAR in obsFilterA or Axis.VAR in obsFilterB:
             raise FilterError("Observation filters may not contain vaiable conditions")
         try:
-            obs_mask_A = self._axis_filter_to_mask(
-                obsFilterA["obs"], self.data.obs, self.data.n_obs
-            )
-            obs_mask_B = self._axis_filter_to_mask(
-                obsFilterB["obs"], self.data.obs, self.data.n_obs
-            )
+            obs_mask_A = self._axis_filter_to_mask(obsFilterA["obs"], self.data.obs, self.data.n_obs)
+            obs_mask_B = self._axis_filter_to_mask(obsFilterB["obs"], self.data.obs, self.data.n_obs)
         except (KeyError, IndexError) as e:
             raise FilterError(f"Error parsing filter: {e}") from e
         if top_n is None:
             top_n = DEFAULT_TOP_N
-        result = diffexp_ttest(
-            self.data, obs_mask_A, obs_mask_B, top_n, self.diffexp_lfc_cutoff
-        )
-        try:
-            return jsonify_scanpy(result)
-        except ValueError:
-            raise JSONEncodingValueError(
-                "Error encoding differential expression to JSON"
-            )
+        result = diffexp_ttest(self.data, obs_mask_A, obs_mask_B, top_n, self.diffexp_lfc_cutoff)
+        return result
 
     def layout(self, filter, interactive_limit=None):
         """
@@ -462,41 +370,11 @@ class ScanpyEngine(CXGDriver):
         try:
             df_layout = df.obsm[f"X_{self.layout_method}"]
         except ValueError as e:
-            raise PrepareError(
-                f"Layout has not been calculated using {self.layout_method}, "
-                f"please prepare your datafile and relaunch cellxgene"
-            ) from e
-        normalized_layout = DataFrame(
-            (df_layout - df_layout.min()) / (df_layout.max() - df_layout.min()),
-            index=df.obs.index,
-        )
-        try:
-            return jsonify_scanpy(
-                {
-                    "layout": {
-                        "ndims": normalized_layout.shape[1],
-                        "coordinates": normalized_layout.to_records(
-                            index=True
-                        ).tolist(),
-                    }
-                }
-            )
-        except ValueError:
-            raise JSONEncodingValueError("Error encoding layout to JSON")
-
-    def layout_to_fbs_matrix(self):
-        """
-        Return the default 2-D layout for cells as a FBS Matrix.
-
-        Caveats:
-        * does not support filtering
-        * only returns Matrix in columnar layout
-        """
-        try:
-            df_layout = self.data.obsm[f"X_{self.layout_method}"]
-        except ValueError as e:
-            raise PrepareError(
-                f"Layout has not been calculated using {self.layout_method}, "
-                f"please prepare your datafile and relaunch cellxgene") from e
-        normalized_layout = (df_layout - df_layout.min()) / (df_layout.max() - df_layout.min())
-        return encode_matrix_fbs(normalized_layout.astype(dtype=np.float32), col_idx=None, row_idx=None)
+            raise PrepareError(f"Layout has not been calculated using {self.layout_method}, "
+                               f"please prepare your datafile and relaunch cellxgene") from e
+        normalized_layout = DataFrame((df_layout - df_layout.min()) / (df_layout.max() - df_layout.min()),
+                                      index=df.obs.index)
+        return {
+            "ndims": normalized_layout.shape[1],
+            "coordinates": normalized_layout.to_records(index=True).tolist()
+        }

server/app/util/constants.py

@@ -25,8 +25,3 @@ class Axis(AugmentedEnum):
 class DiffExpMode(AugmentedEnum):
     TOP_N = "topN"
     VAR_FILTER = "varFilter"
-
-
-JSON_NaN_to_num_warning_msg = (
-    "JSON encoding failure - please verify all data are finite values (no NaN or Infinities)"
-)

server/app/util/errors.py

@@ -16,15 +16,6 @@ class InteractiveError(Exception):
         self.message = message
 
 
-class JSONEncodingValueError(Exception):
-    """
-    Raised when file loaded into scanpy is misformatted
-    """
-
-    def __init__(self, message):
-        self.message = message
-
-
 class MimeTypeError(Exception):
     """
     Raised when incompatible MIME type selected

server/app/util/fbs/NetEncoding/Column.py

@@ -1,41 +0,0 @@
-# automatically generated by the FlatBuffers compiler, do not modify
-
-# namespace: NetEncoding
-
-import flatbuffers
-
-class Column(object):
-    __slots__ = ['_tab']
-
-    @classmethod
-    def GetRootAsColumn(cls, buf, offset):
-        n = flatbuffers.encode.Get(flatbuffers.packer.uoffset, buf, offset)
-        x = Column()
-        x.Init(buf, n + offset)
-        return x
-
-    # Column
-    def Init(self, buf, pos):
-        self._tab = flatbuffers.table.Table(buf, pos)
-
-    # Column
-    def UType(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.Get(flatbuffers.number_types.Uint8Flags, o + self._tab.Pos)
-        return 0
-
-    # Column
-    def U(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(6))
-        if o != 0:
-            from flatbuffers.table import Table
-            obj = Table(bytearray(), 0)
-            self._tab.Union(obj, o)
-            return obj
-        return None
-
-def ColumnStart(builder): builder.StartObject(2)
-def ColumnAddUType(builder, uType): builder.PrependUint8Slot(0, uType, 0)
-def ColumnAddU(builder, u): builder.PrependUOffsetTRelativeSlot(1, flatbuffers.number_types.UOffsetTFlags.py_type(u), 0)
-def ColumnEnd(builder): return builder.EndObject()

server/app/util/fbs/NetEncoding/Float32Array.py

@@ -1,46 +0,0 @@
-# automatically generated by the FlatBuffers compiler, do not modify
-
-# namespace: NetEncoding
-
-import flatbuffers
-
-class Float32Array(object):
-    __slots__ = ['_tab']
-
-    @classmethod
-    def GetRootAsFloat32Array(cls, buf, offset):
-        n = flatbuffers.encode.Get(flatbuffers.packer.uoffset, buf, offset)
-        x = Float32Array()
-        x.Init(buf, n + offset)
-        return x
-
-    # Float32Array
-    def Init(self, buf, pos):
-        self._tab = flatbuffers.table.Table(buf, pos)
-
-    # Float32Array
-    def Data(self, j):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            a = self._tab.Vector(o)
-            return self._tab.Get(flatbuffers.number_types.Float32Flags, a + flatbuffers.number_types.UOffsetTFlags.py_type(j * 4))
-        return 0
-
-    # Float32Array
-    def DataAsNumpy(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.GetVectorAsNumpy(flatbuffers.number_types.Float32Flags, o)
-        return 0
-
-    # Float32Array
-    def DataLength(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.VectorLen(o)
-        return 0
-
-def Float32ArrayStart(builder): builder.StartObject(1)
-def Float32ArrayAddData(builder, data): builder.PrependUOffsetTRelativeSlot(0, flatbuffers.number_types.UOffsetTFlags.py_type(data), 0)
-def Float32ArrayStartDataVector(builder, numElems): return builder.StartVector(4, numElems, 4)
-def Float32ArrayEnd(builder): return builder.EndObject()

server/app/util/fbs/NetEncoding/Float64Array.py

@@ -1,46 +0,0 @@
-# automatically generated by the FlatBuffers compiler, do not modify
-
-# namespace: NetEncoding
-
-import flatbuffers
-
-class Float64Array(object):
-    __slots__ = ['_tab']
-
-    @classmethod
-    def GetRootAsFloat64Array(cls, buf, offset):
-        n = flatbuffers.encode.Get(flatbuffers.packer.uoffset, buf, offset)
-        x = Float64Array()
-        x.Init(buf, n + offset)
-        return x
-
-    # Float64Array
-    def Init(self, buf, pos):
-        self._tab = flatbuffers.table.Table(buf, pos)
-
-    # Float64Array
-    def Data(self, j):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            a = self._tab.Vector(o)
-            return self._tab.Get(flatbuffers.number_types.Float64Flags, a + flatbuffers.number_types.UOffsetTFlags.py_type(j * 8))
-        return 0
-
-    # Float64Array
-    def DataAsNumpy(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.GetVectorAsNumpy(flatbuffers.number_types.Float64Flags, o)
-        return 0
-
-    # Float64Array
-    def DataLength(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.VectorLen(o)
-        return 0
-
-def Float64ArrayStart(builder): builder.StartObject(1)
-def Float64ArrayAddData(builder, data): builder.PrependUOffsetTRelativeSlot(0, flatbuffers.number_types.UOffsetTFlags.py_type(data), 0)
-def Float64ArrayStartDataVector(builder, numElems): return builder.StartVector(8, numElems, 8)
-def Float64ArrayEnd(builder): return builder.EndObject()

server/app/util/fbs/NetEncoding/Int32Array.py

@@ -1,46 +0,0 @@
-# automatically generated by the FlatBuffers compiler, do not modify
-
-# namespace: NetEncoding
-
-import flatbuffers
-
-class Int32Array(object):
-    __slots__ = ['_tab']
-
-    @classmethod
-    def GetRootAsInt32Array(cls, buf, offset):
-        n = flatbuffers.encode.Get(flatbuffers.packer.uoffset, buf, offset)
-        x = Int32Array()
-        x.Init(buf, n + offset)
-        return x
-
-    # Int32Array
-    def Init(self, buf, pos):
-        self._tab = flatbuffers.table.Table(buf, pos)
-
-    # Int32Array
-    def Data(self, j):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            a = self._tab.Vector(o)
-            return self._tab.Get(flatbuffers.number_types.Int32Flags, a + flatbuffers.number_types.UOffsetTFlags.py_type(j * 4))
-        return 0
-
-    # Int32Array
-    def DataAsNumpy(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.GetVectorAsNumpy(flatbuffers.number_types.Int32Flags, o)
-        return 0
-
-    # Int32Array
-    def DataLength(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.VectorLen(o)
-        return 0
-
-def Int32ArrayStart(builder): builder.StartObject(1)
-def Int32ArrayAddData(builder, data): builder.PrependUOffsetTRelativeSlot(0, flatbuffers.number_types.UOffsetTFlags.py_type(data), 0)
-def Int32ArrayStartDataVector(builder, numElems): return builder.StartVector(4, numElems, 4)
-def Int32ArrayEnd(builder): return builder.EndObject()

server/app/util/fbs/NetEncoding/JSONEncodedArray.py

@@ -1,46 +0,0 @@
-# automatically generated by the FlatBuffers compiler, do not modify
-
-# namespace: NetEncoding
-
-import flatbuffers
-
-class JSONEncodedArray(object):
-    __slots__ = ['_tab']
-
-    @classmethod
-    def GetRootAsJSONEncodedArray(cls, buf, offset):
-        n = flatbuffers.encode.Get(flatbuffers.packer.uoffset, buf, offset)
-        x = JSONEncodedArray()
-        x.Init(buf, n + offset)
-        return x
-
-    # JSONEncodedArray
-    def Init(self, buf, pos):
-        self._tab = flatbuffers.table.Table(buf, pos)
-
-    # JSONEncodedArray
-    def Data(self, j):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            a = self._tab.Vector(o)
-            return self._tab.Get(flatbuffers.number_types.Uint8Flags, a + flatbuffers.number_types.UOffsetTFlags.py_type(j * 1))
-        return 0
-
-    # JSONEncodedArray
-    def DataAsNumpy(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.GetVectorAsNumpy(flatbuffers.number_types.Uint8Flags, o)
-        return 0
-
-    # JSONEncodedArray
-    def DataLength(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.VectorLen(o)
-        return 0
-
-def JSONEncodedArrayStart(builder): builder.StartObject(1)
-def JSONEncodedArrayAddData(builder, data): builder.PrependUOffsetTRelativeSlot(0, flatbuffers.number_types.UOffsetTFlags.py_type(data), 0)
-def JSONEncodedArrayStartDataVector(builder, numElems): return builder.StartVector(1, numElems, 1)
-def JSONEncodedArrayEnd(builder): return builder.EndObject()

server/app/util/fbs/NetEncoding/Matrix.py

@@ -1,98 +0,0 @@
-# automatically generated by the FlatBuffers compiler, do not modify
-
-# namespace: NetEncoding
-
-import flatbuffers
-
-class Matrix(object):
-    __slots__ = ['_tab']
-
-    @classmethod
-    def GetRootAsMatrix(cls, buf, offset):
-        n = flatbuffers.encode.Get(flatbuffers.packer.uoffset, buf, offset)
-        x = Matrix()
-        x.Init(buf, n + offset)
-        return x
-
-    # Matrix
-    def Init(self, buf, pos):
-        self._tab = flatbuffers.table.Table(buf, pos)
-
-    # Matrix
-    def NRows(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.Get(flatbuffers.number_types.Uint32Flags, o + self._tab.Pos)
-        return 0
-
-    # Matrix
-    def NCols(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(6))
-        if o != 0:
-            return self._tab.Get(flatbuffers.number_types.Uint32Flags, o + self._tab.Pos)
-        return 0
-
-    # Matrix
-    def Columns(self, j):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(8))
-        if o != 0:
-            x = self._tab.Vector(o)
-            x += flatbuffers.number_types.UOffsetTFlags.py_type(j) * 4
-            x = self._tab.Indirect(x)
-            from .Column import Column
-            obj = Column()
-            obj.Init(self._tab.Bytes, x)
-            return obj
-        return None
-
-    # Matrix
-    def ColumnsLength(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(8))
-        if o != 0:
-            return self._tab.VectorLen(o)
-        return 0
-
-    # Matrix
-    def ColIndexType(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(10))
-        if o != 0:
-            return self._tab.Get(flatbuffers.number_types.Uint8Flags, o + self._tab.Pos)
-        return 0
-
-    # Matrix
-    def ColIndex(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(12))
-        if o != 0:
-            from flatbuffers.table import Table
-            obj = Table(bytearray(), 0)
-            self._tab.Union(obj, o)
-            return obj
-        return None
-
-    # Matrix
-    def RowIndexType(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(14))
-        if o != 0:
-            return self._tab.Get(flatbuffers.number_types.Uint8Flags, o + self._tab.Pos)
-        return 0
-
-    # Matrix
-    def RowIndex(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(16))
-        if o != 0:
-            from flatbuffers.table import Table
-            obj = Table(bytearray(), 0)
-            self._tab.Union(obj, o)
-            return obj
-        return None
-
-def MatrixStart(builder): builder.StartObject(7)
-def MatrixAddNRows(builder, nRows): builder.PrependUint32Slot(0, nRows, 0)
-def MatrixAddNCols(builder, nCols): builder.PrependUint32Slot(1, nCols, 0)
-def MatrixAddColumns(builder, columns): builder.PrependUOffsetTRelativeSlot(2, flatbuffers.number_types.UOffsetTFlags.py_type(columns), 0)
-def MatrixStartColumnsVector(builder, numElems): return builder.StartVector(4, numElems, 4)
-def MatrixAddColIndexType(builder, colIndexType): builder.PrependUint8Slot(3, colIndexType, 0)
-def MatrixAddColIndex(builder, colIndex): builder.PrependUOffsetTRelativeSlot(4, flatbuffers.number_types.UOffsetTFlags.py_type(colIndex), 0)
-def MatrixAddRowIndexType(builder, rowIndexType): builder.PrependUint8Slot(5, rowIndexType, 0)
-def MatrixAddRowIndex(builder, rowIndex): builder.PrependUOffsetTRelativeSlot(6, flatbuffers.number_types.UOffsetTFlags.py_type(rowIndex), 0)
-def MatrixEnd(builder): return builder.EndObject()

server/app/util/fbs/NetEncoding/TypedArray.py

@@ -1,12 +0,0 @@
-# automatically generated by the FlatBuffers compiler, do not modify
-
-# namespace: NetEncoding
-
-class TypedArray(object):
-    NONE = 0
-    Float32Array = 1
-    Int32Array = 2
-    Uint32Array = 3
-    Float64Array = 4
-    JSONEncodedArray = 5
-

server/app/util/fbs/NetEncoding/Uint32Array.py

@@ -1,46 +0,0 @@
-# automatically generated by the FlatBuffers compiler, do not modify
-
-# namespace: NetEncoding
-
-import flatbuffers
-
-class Uint32Array(object):
-    __slots__ = ['_tab']
-
-    @classmethod
-    def GetRootAsUint32Array(cls, buf, offset):
-        n = flatbuffers.encode.Get(flatbuffers.packer.uoffset, buf, offset)
-        x = Uint32Array()
-        x.Init(buf, n + offset)
-        return x
-
-    # Uint32Array
-    def Init(self, buf, pos):
-        self._tab = flatbuffers.table.Table(buf, pos)
-
-    # Uint32Array
-    def Data(self, j):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            a = self._tab.Vector(o)
-            return self._tab.Get(flatbuffers.number_types.Uint32Flags, a + flatbuffers.number_types.UOffsetTFlags.py_type(j * 4))
-        return 0
-
-    # Uint32Array
-    def DataAsNumpy(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.GetVectorAsNumpy(flatbuffers.number_types.Uint32Flags, o)
-        return 0
-
-    # Uint32Array
-    def DataLength(self):
-        o = flatbuffers.number_types.UOffsetTFlags.py_type(self._tab.Offset(4))
-        if o != 0:
-            return self._tab.VectorLen(o)
-        return 0
-
-def Uint32ArrayStart(builder): builder.StartObject(1)
-def Uint32ArrayAddData(builder, data): builder.PrependUOffsetTRelativeSlot(0, flatbuffers.number_types.UOffsetTFlags.py_type(data), 0)
-def Uint32ArrayStartDataVector(builder, numElems): return builder.StartVector(4, numElems, 4)
-def Uint32ArrayEnd(builder): return builder.EndObject()

server/app/util/fbs/matrix.py

@@ -1,207 +0,0 @@
-import flatbuffers
-import numpy as np
-from scipy import sparse
-import pandas as pd
-
-import server.app.util.fbs.NetEncoding.Column as Column
-import server.app.util.fbs.NetEncoding.TypedArray as TypedArray
-import server.app.util.fbs.NetEncoding.Matrix as Matrix
-
-
-# Placeholder until recent enhancements to flatbuffers Python
-# runtime are released, at which point we can use the default
-# version.  This code is a port of the head.  See:
-#
-#       https://github.com/google/flatbuffers/pull/4829
-#
-def CreateNumpyVector(builder, x):
-    """CreateNumpyVector writes a numpy array into the buffer."""
-
-    if not isinstance(x, np.ndarray):
-        raise TypeError("non-numpy-ndarray passed to CreateNumpyVector")
-
-    if x.dtype.kind not in ['b', 'i', 'u', 'f']:
-        raise TypeError("numpy-ndarray holds elements of unsupported datatype")
-
-    if x.ndim > 1:
-        raise TypeError("multidimensional-ndarray passed to CreateNumpyVector")
-
-    builder.StartVector(x.itemsize, x.size, x.dtype.alignment)
-
-    # Ensure little endian byte ordering
-    if x.dtype.str[0] == "<":
-        x_little_endian = x
-    else:
-        x_little_endian = x.byteswap(inplace=False)
-
-    # Calculate total length
-    len = int(x_little_endian.itemsize * x_little_endian.size)
-    builder.head = int(builder.Head() - len)
-
-    # tobytes ensures c_contiguous ordering
-    builder.Bytes[builder.Head():builder.Head() + len] = x_little_endian.tobytes(order='C')
-
-    return builder.EndVector(x.size)
-
-
-# Serialization helper
-def serialize_column(builder, typed_arr):
-    """ Serialize NetEncoding.Column """
-    (u_type, u_value) = typed_arr
-    Column.ColumnStart(builder)
-    Column.ColumnAddUType(builder, u_type)
-    Column.ColumnAddU(builder, u_value)
-    return Column.ColumnEnd(builder)
-
-
-# Serialization helper
-def serialize_matrix(builder, n_rows, n_cols, columns, col_idx):
-    """ Serialize NetEncoding.Matrix """
-    Matrix.MatrixStart(builder)
-    Matrix.MatrixAddNRows(builder, n_rows)
-    Matrix.MatrixAddNCols(builder, n_cols)
-    Matrix.MatrixAddColumns(builder, columns)
-    if col_idx is not None:
-        (u_type, u_val) = col_idx
-        Matrix.MatrixAddColIndexType(builder, u_type)
-        Matrix.MatrixAddColIndex(builder, u_val)
-    return Matrix.MatrixEnd(builder)
-
-
-# Serialization helper
-def serialize_typed_array(builder, source_array, encoding_info):
-    """
-    Serialize any of the various typed arrays, eg, Float32Array.   Specific
-    means of serialization and type conversion are provided by type_info.
-    """
-    arr = source_array
-    (array_type, as_type) = encoding_info(source_array)
-
-    if isinstance(arr, pd.Index):
-        arr = arr.to_series()
-
-    # convert to a simple ndarray
-    if as_type == 'json':
-        as_json = arr.to_json(orient='records')
-        arr = np.array(bytearray(as_json, 'utf-8'))
-    else:
-        if sparse.issparse(arr):
-            arr = arr.toarray()
-        elif isinstance(arr, pd.Series):
-            arr = arr.get_values()
-        if arr.dtype != as_type:
-            arr = arr.astype(as_type)
-
-    # serialize the ndarray into a vector
-    if arr.ndim == 2 and arr.shape[0] == 1:
-        arr = arr[0]
-    vec = CreateNumpyVector(builder, arr)
-
-    # serialize the typed array table
-    builder.StartObject(1)
-    builder.PrependUOffsetTRelativeSlot(0, vec, 0)
-    array_value = builder.EndObject()
-    return (array_type, array_value)
-
-
-def column_encoding(arr):
-    type_map = {
-        # dtype:  ( array_type, as_type )
-        np.float64: (TypedArray.TypedArray.Float32Array, np.float32),
-        np.float32: (TypedArray.TypedArray.Float32Array, np.float32),
-        np.float16: (TypedArray.TypedArray.Float32Array, np.float32),
-
-        np.int8: (TypedArray.TypedArray.Int32Array, np.int32),
-        np.int16: (TypedArray.TypedArray.Int32Array, np.int32),
-        np.int32: (TypedArray.TypedArray.Int32Array, np.int32),
-        np.int64: (TypedArray.TypedArray.Int32Array, np.int32),
-
-        np.uint8: (TypedArray.TypedArray.Uint32Array, np.uint32),
-        np.uint16: (TypedArray.TypedArray.Uint32Array, np.uint32),
-        np.uint32: (TypedArray.TypedArray.Uint32Array, np.uint32),
-        np.uint64: (TypedArray.TypedArray.Uint32Array, np.uint32)
-    }
-    type_map_default = (TypedArray.TypedArray.JSONEncodedArray, 'json')
-    return type_map.get(arr.dtype.type, type_map_default)
-
-
-def index_encoding(arr):
-    type_map = {
-        # dtype:  ( array_type, as_type )
-        np.int32: (TypedArray.TypedArray.Int32Array, np.int32),
-        np.int64: (TypedArray.TypedArray.Int32Array, np.int32),
-
-        np.uint32: (TypedArray.TypedArray.Uint32Array, np.uint32),
-        np.uint64: (TypedArray.TypedArray.Uint32Array, np.uint32)
-    }
-    type_map_default = (TypedArray.TypedArray.JSONEncodedArray, 'json')
-    return type_map.get(arr.dtype.type, type_map_default)
-
-
-def guess_at_mem_needed(matrix):
-    (n_rows, n_cols) = matrix.shape
-    if isinstance(matrix, np.ndarray) or sparse.issparse(matrix):
-        guess = (n_rows * n_cols * matrix.dtype.itemsize) + 1024
-    elif isinstance(matrix, pd.DataFrame):
-        # XXX TODO - DataFrame type estimate
-        guess = 1
-    else:
-        guess = 1
-
-    # round up to nearest 1024 bytes
-    guess = (guess + 0x400) & (~0x3ff)
-    return guess
-
-
-def encode_matrix_fbs(matrix, row_idx=None, col_idx=None):
-    """
-    Given a 2D DataFrame, ndarray or sparse equivalent, create and return a
-    Matrix flatbuffer.
-
-    :param matrix: 2D DataFrame, ndarray or sparse equivalent
-    :param row_idx: index for row dimension, Index or ndarray
-    :param col_idx: index for col dimension, Index or ndarray
-
-    NOTE: row indices are (currently) unsupported and must be None
-    """
-
-    if row_idx is not None:
-        raise ValueError("row indexing not supported for FBS Matrix")
-    if matrix.ndim != 2:
-        raise ValueError("FBS Matrix must be 2D")
-
-    (n_rows, n_cols) = matrix.shape
-
-    # estimate size needed, so we don't unnecessarily realloc.
-    builder = flatbuffers.Builder(guess_at_mem_needed(matrix))
-
-    if isinstance(matrix, pd.DataFrame):
-        matrix_columns = reversed(tuple(matrix[name] for name in matrix))
-    else:
-        matrix_columns = reversed(tuple(c for c in matrix.T))
-
-    columns = []
-    # for idx in reversed(np.arange(n_cols)):
-    for c in matrix_columns:
-        # serialize the typed array
-        typed_arr = serialize_typed_array(builder, c, column_encoding)
-
-        # serialize the Column union
-        columns.append(serialize_column(builder, typed_arr))
-
-    # Serialize Matrix.columns[]
-    Matrix.MatrixStartColumnsVector(builder, n_cols)
-    for c in columns:
-        builder.PrependUOffsetTRelative(c)
-    matrix_column_vec = builder.EndVector(n_cols)
-
-    # serialize the colIndex if provided
-    cidx = None
-    if col_idx is not None:
-        cidx = serialize_typed_array(builder, col_idx, index_encoding)
-
-    # Serialize Matrix
-    matrix = serialize_matrix(builder, n_rows, n_cols, matrix_column_vec, cidx)
-
-    builder.Finish(matrix)
-    return builder.Output()

server/app/util/filter.py

@@ -7,6 +7,7 @@ from server.app.util.constants import Axis
 
 
 class QueryStringError(Exception):
+
     def __init__(self, key, message):
         self.key = key
         self.message = message

server/app/util/models.py

@@ -5,13 +5,24 @@ class AnnotationModel(Schema):
     type = "object"
     description = "Filter by annotation key: value"
     properties = {
-        "name": {"type": "string"},
+        "name": {
+            "type": "string"
+        },
         # TODO update to OpenAPI v3.0 when a library is available that supports it
         # Unfortunately 2.0 doesn't have a way to have a schema that accepts multiple types
         # Overloading the type key with a list seems to work ok and makes it to the page
-        "values": {"type": "array", "items": {"type": ["float32", "string", "int32", "bool"]}},
-        "min": {"type": ["int32", "float32"]},
-        "max": {"type": ["int32", "float32"]},
+        "values": {
+            "type": "array",
+            "items": {
+                "type": ["float32", "string", "int32", "bool"]
+            }
+        },
+        "min": {
+            "type": ["int32", "float32"],
+        },
+        "max": {
+            "type": ["int32", "float32"],
+        }
     }
     required = ["name"]
 
@@ -19,16 +30,36 @@ class AnnotationModel(Schema):
 class IndexModel(Schema):
     type = "object"
     description = "Filter by index of observation/variable ex. [0, 5, 15]"
-    properties = {"index": {"type": "array", "items": {"format": "int32", "type": "integer"}}}
+    properties = {
+        "index": {
+            "type": "array",
+            "items": {
+                "format": "int32",
+                "type": "integer"
+            }
+
+        }
+    }
 
 
 class AxisModel(Schema):
     type = "object"
     description = "Axis of data -- obs or var"
-    properties = {"index": IndexModel, "annotation_value": AnnotationModel.array()}
+    properties = {
+        "index": IndexModel,
+        "annotation_value": AnnotationModel.array()
+    }
 
 
 class FilterModel(Schema):
     type = "object"
     description = "Complex filter"
-    properties = {"filter": {"type": "object", "properties": {"obs": AxisModel, "var": AxisModel}}}
+    properties = {
+        "filter": {
+            "type": "object",
+            "properties": {
+                "obs": AxisModel,
+                "var": AxisModel
+            }
+        }
+    }

server/app/util/utils.py

@@ -7,17 +7,6 @@ from server.app.util.errors import MimeTypeError
 
 
 class Float32JSONEncoder(json.JSONEncoder):
-    def __init__(self, *args, **kwargs):
-        """
-        NaN/Infinities are illegal in standard JSON.  Python extends JSON with
-        non-standard symbols that most JavaScript JSON parsers do not understand.
-        The `allow_nan` parameter will force Python simplejson to throw an ValueError
-        if it runs into non-finite floating point values which are unsupported by
-        standard JSON.
-        """
-        kwargs["allow_nan"] = False
-        super().__init__(*args, **kwargs)
-
     def default(self, obj):
         if isinstance(obj, float32):
             return float(obj)
@@ -26,13 +15,8 @@ class Float32JSONEncoder(json.JSONEncoder):
         return json.JSONEncoder.default(self, obj)
 
 
-def custom_format_warning(msg, *args, **kwargs):
-    return f"[cellxgene] Warning: {msg} \n"
-
-
-def get_mime_type(
-    default="application/json", acceptable_types=["application/json", "text/csv"], query_param=None, header=None
-):
+def get_mime_type(default="application/json", acceptable_types=["application/json", "text/csv"], query_param=None,
+                  header=None):
     mime_type = default
     if query_param:
         if query_param in acceptable_types:
@@ -54,7 +38,3 @@ def whole_number(value):
     if value < 0:
         raise ArgumentTypeError(f"{value} is not >= 0")
     return value
-
-
-def jsonify_scanpy(data):
-    return json.dumps(data, cls=Float32JSONEncoder, allow_nan=False)

server/app/web/webapp.py

@@ -1,5 +1,7 @@
 import os
-from flask import Blueprint, render_template, send_from_directory, current_app, request
+from flask import (
+    Blueprint, render_template, send_from_directory, current_app
+)
 
 
 bp = Blueprint("webapp", __name__, template_folder="templates")
@@ -7,7 +9,7 @@ bp = Blueprint("webapp", __name__, template_folder="templates")
 
 @bp.route("/")
 def index():
-    url_base = request.url_root + "api/"
+    url_base = current_app.config["CXG_API_BASE"]
     dataset_title = current_app.config["DATASET_TITLE"]
     return render_template("index.html", prefix=url_base, datasetTitle=dataset_title)
 

server/cli/cli.py

@@ -5,7 +5,7 @@ from .prepare import prepare
 
 
 @click.group(name="cellxgene", context_settings=dict(max_content_width=85))
-@click.version_option(version="0.5.0", prog_name="cellxgene", message="[%(prog)s] Version %(version)s")
+@click.version_option(version="0.2.4", prog_name="cellxgene", message="[%(prog)s] Version %(version)s")
 def cli():
     pass
 

server/cli/launch.py

@@ -1,80 +1,37 @@
+import sys
+import click
 import logging
 from os import devnull
 from os.path import splitext, basename
-import sys
-import warnings
 import webbrowser
 
-import click
-
 from server.app.util.errors import ScanpyFileError
-from server.app.util.utils import custom_format_warning
 
 
 @click.command()
 @click.argument("data", metavar="<data file>", type=click.Path(exists=True, file_okay=True, dir_okay=False))
-@click.option(
-    "--layout", "-l", type=click.Choice(["umap", "tsne"]), default="umap", show_default=True, help="Method for layout."
-)
-@click.option(
-    "--diffexp",
-    "-d",
-    type=click.Choice(["ttest"]),
-    default="ttest",
-    show_default=True,
-    help="Method for differential expression.",
-)
+@click.option("--layout", "-l", type=click.Choice(["umap", "tsne"]), default="umap", show_default=True,
+              help="Method for layout.")
+@click.option("--diffexp", "-d", type=click.Choice(["ttest"]), default="ttest", show_default=True,
+              help="Method for differential expression.")
 @click.option("--title", "-t", help="Title to display (if omitted will use file name).", metavar="")
-@click.option(
-    "--verbose",
-    "-v",
-    is_flag=True,
-    default=False,
-    show_default=True,
-    help="Provide verbose output, including warnings and all server requests.",
-)
-@click.option("--debug", "-d", is_flag=True, default=False, show_default=True, help="Run in debug mode.")
-@click.option(
-    "--open",
-    "-o",
-    "open_browser",
-    is_flag=True,
-    default=False,
-    show_default=True,
-    help="Open the web browser after launch.",
-)
+@click.option("--verbose", "-v", is_flag=True, default=False, show_default=True,
+              help="Provide verbose output, including warnings and all server requests.")
+@click.option("--debug", "-d", is_flag=True, default=False, show_default=True,
+              help="Run in debug mode.")
+@click.option("--open", "-o", "open_browser", is_flag=True, default=False, show_default=True,
+              help="Open the web browser after launch.")
 @click.option("--port", "-p", help="Port to run server on.", metavar="", default=5005, show_default=True)
 @click.option("--obs-names", default=None, metavar="", help="Name of annotation field to use for observations.")
 @click.option("--var-names", default=None, metavar="", help="Name of annotation to use for variables.")
-@click.option("--host", default="127.0.0.1", help="Host IP address")
-@click.option(
-    "--max-category-items",
-    default=100,
-    metavar="",
-    show_default=True,
-    help="Limits the number of categorical annotation items displayed.",
-)
-@click.option(
-    "--diffexp-lfc-cutoff",
-    default=0.01,
-    show_default=True,
-    help="Relative expression cutoff used when selecting top N differentially expressed genes",
-)
-def launch(
-    data,
-    layout,
-    diffexp,
-    title,
-    verbose,
-    debug,
-    obs_names,
-    var_names,
-    open_browser,
-    port,
-    host,
-    max_category_items,
-    diffexp_lfc_cutoff,
-):
+@click.option("--listen-all", is_flag=True, default=False, show_default=True,
+              help="Bind to all interfaces (this makes the server accessible beyond this computer).")
+@click.option("--max-category-items", default=100, metavar="", show_default=True,
+              help="Limits the number of categorical annotation items displayed.")
+@click.option("--diffexp-lfc-cutoff", default=0.01, show_default=True,
+              help="Relative expression cutoff used when selecting top N differentially expressed genes")
+def launch(data, layout, diffexp, title, verbose, debug, obs_names, var_names,
+           open_browser, port, listen_all, max_category_items, diffexp_lfc_cutoff):
     """Launch the cellxgene data viewer.
     This web app lets you explore single-cell expression data.
     Data must be in a format that cellxgene expects, read the
@@ -89,6 +46,9 @@ def launch(
     # Startup message
     click.echo("[cellxgene] Starting the CLI...")
 
+    # Import Flask app
+    from server.app.app import app
+
     # Argument checking
     name, extension = splitext(data)
     if extension != ".h5ad":
@@ -97,8 +57,6 @@ def launch(
     if debug:
         verbose = True
         open_browser = False
-    else:
-        warnings.formatwarning = custom_format_warning
 
     if not verbose:
         sys.tracebacklimit = 0
@@ -107,13 +65,19 @@ def launch(
         file_parts = splitext(basename(data))
         title = file_parts[0]
 
+    if listen_all:
+        host = "0.0.0.0"
+    else:
+        host = "127.0.0.1"
+
     # Setup app
     cellxgene_url = f"http://{host}:{port}"
+    api_base = f"{cellxgene_url}/api/"
 
-    # Import Flask app
-    from server.app.app import app
-
-    app.config.update(DATASET_TITLE=title)
+    app.config.update(
+        DATASET_TITLE=title,
+        CXG_API_BASE=api_base
+    )
 
     if not verbose:
         log = logging.getLogger("werkzeug")
@@ -124,8 +88,7 @@ def launch(
     # Fix for anaconda python. matplotlib typically expects python to be installed as a framework TKAgg is usually
     # available and fixes this issue. See https://matplotlib.org/faq/virtualenv_faq.html
     import matplotlib as mpl
-
-    mpl.use("TkAgg")
+    mpl.use('TkAgg')
     from server.app.scanpy_engine.scanpy_engine import ScanpyEngine
 
     args = {
@@ -134,7 +97,7 @@ def launch(
         "max_category_items": max_category_items,
         "diffexp_lfc_cutoff": diffexp_lfc_cutoff,
         "obs_names": obs_names,
-        "var_names": var_names,
+        "var_names": var_names
     }
 
     try:
@@ -151,7 +114,7 @@ def launch(
     click.echo("[cellxgene] Type CTRL-C at any time to exit.")
 
     if not verbose:
-        f = open(devnull, "w")
+        f = open(devnull, 'w')
         sys.stdout = f
 
     app.run(host=host, debug=debug, port=port, threaded=True)

server/cli/prepare.py

@@ -7,48 +7,22 @@ from scipy.sparse.csc import csc_matrix
 
 @click.command()
 @click.argument("data", nargs=1, metavar="<dataset: file or path to data>", required=True)
-@click.option(
-    "--layout",
-    "-l",
-    default=["umap", "tsne"],
-    multiple=True,
-    type=click.Choice(["umap", "tsne"]),
-    help="Layout algorithm",
-    show_default=True,
-)
-@click.option(
-    "--recipe",
-    "-r",
-    default="none",
-    type=click.Choice(["none", "seurat", "zheng17"]),
-    help="Preprocessing to run.",
-    show_default=True,
-)
+@click.option("--layout", "-l", default=["umap", "tsne"], multiple=True, type=click.Choice(["umap", "tsne"]),
+              help="Layout algorithm", show_default=True)
+@click.option("--recipe", "-r", default="none", type=click.Choice(["none", "seurat", "zheng17"]),
+              help="Preprocessing to run.", show_default=True)
 @click.option("--output", "-o", default="", help="Save a new file to filename.", metavar="<filename>")
 @click.option("--plotting", "-p", default=False, is_flag=True, help="Whether to generate plots.", show_default=True)
 @click.option("--sparse", default=False, is_flag=True, help="Whether to force sparsity.", show_default=True)
 @click.option("--overwrite", default=False, is_flag=True, help="Allow file overwriting.", show_default=True)
 @click.option("--set-obs-names", default="", help="Named field to set as index for obs.", metavar="<name>")
 @click.option("--set-var-names", default="", help="Named field to set as index for var.", metavar="<name>")
-@click.option(
-    "--make-obs-names-unique", default=True, is_flag=True, help="Ensure obs index is unique.", show_default=True
-)
-@click.option(
-    "--make-var-names-unique", default=True, is_flag=True, help="Ensure var index is unique.", show_default=True
-)
-def prepare(
-    data,
-    layout,
-    recipe,
-    output,
-    plotting,
-    sparse,
-    overwrite,
-    set_obs_names,
-    set_var_names,
-    make_obs_names_unique,
-    make_var_names_unique,
-):
+@click.option("--make-obs-names-unique", default=True, is_flag=True,
+              help="Ensure obs index is unique.", show_default=True)
+@click.option("--make-var-names-unique", default=True, is_flag=True,
+              help="Ensure var index is unique.", show_default=True)
+def prepare(data, layout, recipe, output, plotting, sparse, overwrite,
+            set_obs_names, set_var_names, make_obs_names_unique, make_var_names_unique):
     """Preprocesses data for use with cellxgene.
 
     This tool runs a series of scanpy routines for preparing a dataset
@@ -61,7 +35,6 @@ def prepare(
     # collect slow imports here to make CLI startup more responsive
     click.echo("[cellxgene] Starting CLI...")
     import matplotlib
-
     matplotlib.use("Agg")
     import scanpy.api as sc
 
@@ -76,10 +49,8 @@ def prepare(
     output = expanduser(output)
 
     if not output:
-        click.echo(
-            "Warning: No file will be saved, to save the results of cellxgene prepare include "
-            "--output <filename> to save output to a new file"
-        )
+        click.echo("Warning: No file will be saved, to save the results of cellxgene prepare include "
+                   "--output <filename> to save output to a new file")
     if isfile(output) and not overwrite:
         raise click.UsageError(f"Cannot overwrite existing file {output}, try using the flag --overwrite")
 
@@ -148,11 +119,9 @@ def prepare(
         try:
             sc.tl.louvain(adata)
         except ModuleNotFoundError:
-            click.echo(
-                "\nWarning: louvain module is not installed, no clusters will be calculated. "
-                "To fix this please install cellxgene with the optional feature louvain enabled: "
-                "`pip install cellxgene[louvain]`"
-            )
+            click.echo("\nWarning: louvain module is not installed, no clusters will be calculated. "
+                       "To fix this please install cellxgene with the optional feature louvain enabled: "
+                       "`pip install cellxgene[louvain]`")
 
     def run_layout(adata):
         if len(unique(adata.obs["louvain"].values)) < 10:
@@ -173,11 +142,11 @@ def prepare(
     def show_step(item):
         names = {
             "make_sparse": "Ensuring sparsity",
-            "run_recipe": f'Running preprocessing recipe "{recipe}"',
+            "run_recipe": f"Running preprocessing recipe \"{recipe}\"",
             "run_pca": "Running PCA",
             "run_neighbors": "Calculating neighbors",
             "run_louvain": "Calculating clusters",
-            "run_layout": "Computing layout",
+            "run_layout": "Computing layout"
         }
         if item is not None:
             return names[item.__name__]

server/requirements-dev.txt

@@ -1,6 +1,5 @@
-black
-bumpversion>=0.5
 pytest>=3.6.3
 requests>=2.18.4
 twine>=1.12.1
+bumpversion>=0.5
 -r requirements.txt

server/requirements.txt

@@ -6,10 +6,9 @@ Flask-Compress>=1.4.0
 Flask-Cors>=3.0.6
 Flask-RESTful>=0.3.6
 flask-restful-swagger-2>=0.35
-flatbuffers>=1.10.0
 matplotlib>=2.2
 numpy>=1.14.5
 pandas>=0.23.1
 scanpy>=1.3.2
 scipy>=1.1.0
-scikit-learn>=0.19.1,!=0.20.0
+scikit-learn>=0.20.1

server/test/decode_fbs.py

@@ -1,69 +0,0 @@
-
-"""
-Code to decode, for testing purposes, the flatbuffer encoded blobs.
-This code will need to be updated if fbs/matrix.fbs changes.
-
-For more information, see fbs/matrix.fbs and server/app/util/fbs/
-"""
-import json
-
-import server.app.util.fbs.NetEncoding.TypedArray as TypedArray
-import server.app.util.fbs.NetEncoding.Matrix as Matrix
-import server.app.util.fbs.NetEncoding.Int32Array as Int32Array
-import server.app.util.fbs.NetEncoding.Uint32Array as Uint32Array
-import server.app.util.fbs.NetEncoding.Float32Array as Float32Array
-import server.app.util.fbs.NetEncoding.Float64Array as Float64Array
-import server.app.util.fbs.NetEncoding.JSONEncodedArray as JSONEncodedArray
-
-
-def decode_typed_array(tarr):
-    type_map = {
-        TypedArray.TypedArray.Uint32Array: Uint32Array.Uint32Array,
-        TypedArray.TypedArray.Int32Array: Int32Array.Int32Array,
-        TypedArray.TypedArray.Float32Array: Float32Array.Float32Array,
-        TypedArray.TypedArray.Float64Array: Float64Array.Float64Array,
-        TypedArray.TypedArray.JSONEncodedArray: JSONEncodedArray.JSONEncodedArray
-    }
-    (u_type, u) = tarr
-    if u_type == TypedArray.TypedArray.NONE:
-        return None
-
-    TarType = type_map.get(u_type, None)
-    assert(TarType is not None)
-
-    arr = TarType()
-    arr.Init(u.Bytes, u.Pos)
-    narr = arr.DataAsNumpy()
-    if u_type == TypedArray.TypedArray.JSONEncodedArray:
-        narr = json.loads(narr.tostring().decode('utf-8'))
-    return narr
-
-
-def decode_matrix_FBS(buf):
-    """
-    Given a FBS Matrix, return an decoded Python dict containing
-    same info in native format.
-
-    NOTE / TODO: row_idx not currently implemented
-    """
-    df = Matrix.Matrix.GetRootAsMatrix(buf, 0)
-    n_rows = df.NRows()
-    n_cols = df.NCols()
-
-    columns_length = df.ColumnsLength()
-
-    decoded_columns = []
-    for col_idx in range(0, columns_length):
-        col = df.Columns(col_idx)
-        tarr = (col.UType(), col.U())
-        decoded_columns.append(decode_typed_array(tarr))
-
-    cidx = decode_typed_array((df.ColIndexType(), df.ColIndex()))
-
-    return {
-        "n_rows": n_rows,
-        "n_cols": n_cols,
-        "columns": decoded_columns,
-        "col_idx": cidx,
-        "row_idx": None
-    }

server/test/test_api.py

@@ -5,13 +5,19 @@ import time
 
 import requests
 
-import decode_fbs
-
 LOCAL_URL = "http://127.0.0.1:5005/"
 VERSION = "v0.2"
 URL_BASE = f"{LOCAL_URL}api/{VERSION}/"
 
-BAD_FILTER = {"filter": {"obs": {"annotation_value": [{"name": "xyz"}]}}}
+BAD_FILTER = {
+            "filter": {
+                "obs": {
+                    "annotation_value": [
+                        {"name": "xyz"},
+                    ],
+                }
+            }
+        }
 
 
 class EndPoints(unittest.TestCase):
@@ -42,7 +48,6 @@ class EndPoints(unittest.TestCase):
         url = f"{URL_BASE}{endpoint}"
         result = self.session.get(url)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["schema"]["dataframe"]["nObs"], 2638)
         self.assertEqual(len(result_data["schema"]["annotations"]["obs"]), 5)
@@ -52,7 +57,6 @@ class EndPoints(unittest.TestCase):
         url = f"{URL_BASE}{endpoint}"
         result = self.session.get(url)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["config"]["displayNames"]["dataset"], "pbmc3k")
         self.assertEqual(len(result_data["config"]["features"]), 4)
@@ -62,26 +66,10 @@ class EndPoints(unittest.TestCase):
         url = f"{URL_BASE}{endpoint}"
         result = self.session.get(url)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["layout"]["ndims"], 2)
         self.assertEqual(len(result_data["layout"]["coordinates"]), 2638)
 
-    def test_get_layout_fbs(self):
-        endpoint = "layout/obs"
-        url = f"{URL_BASE}{endpoint}"
-        header = {"Accept": "application/octet-stream"}
-        result = self.session.get(url, headers=header)
-        self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/octet-stream")
-        df = decode_fbs.decode_matrix_FBS(result.content)
-        self.assertEqual(df['n_rows'], 2638)
-        self.assertEqual(df['n_cols'], 2)
-        self.assertIsNotNone(df['columns'])
-        self.assertIsNone(df['col_idx'])
-        self.assertIsNone(df['row_idx'])
-        self.assertEqual(len(df['columns']), df['n_cols'])
-
     # def test_put_layout(self):
     #     endpoint = "layout/obs"
     #     url = f"{URL_BASE}{endpoint}"
@@ -113,7 +101,6 @@ class EndPoints(unittest.TestCase):
         url = f"{URL_BASE}{endpoint}"
         result = self.session.get(url)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["names"], ["name", "n_genes", "percent_mito", "n_counts", "louvain"])
         self.assertEqual(len(result_data["data"]), 2638)
@@ -124,28 +111,11 @@ class EndPoints(unittest.TestCase):
         query = "annotation-name=n_genes&annotation-name=percent_mito"
         url = f"{URL_BASE}{endpoint}?{query}"
         result = self.session.get(url)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         self.assertEqual(result.status_code, HTTPStatus.OK)
         result_data = result.json()
         self.assertEqual(result_data["names"], ["n_genes", "percent_mito"])
         self.assertEqual(len(result_data["data"][0]), 3)
 
-    def test_get_annotations_obs_fbs(self):
-        endpoint = "annotations/obs"
-        url = f"{URL_BASE}{endpoint}"
-        header = {"Accept": "application/octet-stream"}
-        result = self.session.get(url, headers=header)
-        self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/octet-stream")
-        df = decode_fbs.decode_matrix_FBS(result.content)
-        self.assertEqual(df['n_rows'], 2638)
-        self.assertEqual(df['n_cols'], 5)
-        self.assertIsNotNone(df['columns'])
-        self.assertIsNotNone(df['col_idx'])
-        self.assertIsNone(df['row_idx'])
-        self.assertEqual(len(df['columns']), df['n_cols'])
-        self.assertListEqual(df['col_idx'], ['name', 'n_genes', 'percent_mito', 'n_counts', 'louvain'])
-
     def test_get_annotations_obs_error(self):
         endpoint = "annotations/obs"
         query = "annotation-name=notakey"
@@ -163,13 +133,12 @@ class EndPoints(unittest.TestCase):
                         {"name": "louvain", "values": ["NK cells", "CD8 T cells"]},
                         {"name": "n_counts", "min": 3000},
                     ],
-                    "index": [1, 99, [1000, 2000]],
+                    "index": [1, 99, [1000, 2000]]
                 }
             }
         }
         result = self.session.put(url, json=obs_filter)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["names"], ["name", "n_genes", "percent_mito", "n_counts", "louvain"])
         self.assertEqual(len(result_data["data"]), 15)
@@ -185,13 +154,12 @@ class EndPoints(unittest.TestCase):
                         {"name": "louvain", "values": ["NK cells", "CD8 T cells"]},
                         {"name": "n_counts", "min": 3000},
                     ],
-                    "index": [1, 99, [1000, 2000]],
+                    "index": [1, 99, [1000, 2000]]
                 }
             }
         }
         result = self.session.put(url, json=obs_filter)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["names"], ["n_genes", "percent_mito"])
         self.assertEqual(len(result_data["data"][0]), 3)
@@ -202,13 +170,26 @@ class EndPoints(unittest.TestCase):
         url = f"{URL_BASE}{endpoint}"
         params = {
             "mode": "topN",
-            "set1": {"filter": {"obs": {"annotation_value": [{"name": "louvain", "values": ["NK cells"]}]}}},
-            "set2": {"filter": {"obs": {"annotation_value": [{"name": "louvain", "values": ["CD8 T cells"]}]}}},
-            "count": 7,
+            "set1": {
+                "filter": {
+                    "obs": {"annotation_value": [
+                        {"name": "louvain", "values": ["NK cells"]}
+                    ]
+                    }
+                }
+            },
+            "set2": {
+                "filter": {
+                    "obs": {"annotation_value": [
+                        {"name": "louvain", "values": ["CD8 T cells"]}
+                    ]
+                    }
+                }
+            },
+            "count": 7
         }
         result = self.session.post(url, json=params)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(len(result_data), 7)
 
@@ -218,12 +199,23 @@ class EndPoints(unittest.TestCase):
         params = {
             "mode": "topN",
             "count": 10,
-            "set1": {"filter": {"obs": {"index": [[0, 500]]}}},
-            "set2": {"filter": {"obs": {"index": [[500, 1000]]}}},
+            "set1": {
+                "filter": {
+                    "obs": {
+                        "index": [[0, 500]]
+                    }
+                }
+            },
+            "set2": {
+                "filter": {
+                    "obs": {
+                        "index": [[500, 1000]]
+                    }
+                }
+            }
         }
         result = self.session.post(url, json=params)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(len(result_data), 10)
 
@@ -232,7 +224,6 @@ class EndPoints(unittest.TestCase):
         url = f"{URL_BASE}{endpoint}"
         result = self.session.get(url)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["names"], ["name", "n_cells"])
         self.assertEqual(len(result_data["data"]), 1838)
@@ -244,27 +235,10 @@ class EndPoints(unittest.TestCase):
         url = f"{URL_BASE}{endpoint}?{query}"
         result = self.session.get(url)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["names"], ["n_cells"])
         self.assertEqual(len(result_data["data"][0]), 2)
 
-    def test_get_annotations_var_fbs(self):
-        endpoint = "annotations/var"
-        url = f"{URL_BASE}{endpoint}"
-        header = {"Accept": "application/octet-stream"}
-        result = self.session.get(url, headers=header)
-        self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/octet-stream")
-        df = decode_fbs.decode_matrix_FBS(result.content)
-        self.assertEqual(df['n_rows'], 1838)
-        self.assertEqual(df['n_cols'], 2)
-        self.assertIsNotNone(df['columns'])
-        self.assertIsNotNone(df['col_idx'])
-        self.assertIsNone(df['row_idx'])
-        self.assertEqual(len(df['columns']), df['n_cols'])
-        self.assertListEqual(df['col_idx'], ['name', 'n_cells'])
-
     def test_get_annotations_var_error(self):
         endpoint = "annotations/var"
         query = "annotation-name=notakey"
@@ -275,10 +249,17 @@ class EndPoints(unittest.TestCase):
     def test_put_annotations_var(self):
         endpoint = "annotations/var"
         url = f"{URL_BASE}{endpoint}"
-        var_filter = {"filter": {"var": {"annotation_value": [{"name": "name", "values": ["ATAD3C", "RER1"]}]}}}
+        var_filter = {
+            "filter": {
+                "var": {
+                    "annotation_value": [
+                        {"name": "name", "values": ["ATAD3C", "RER1"]},
+                    ]
+                }
+            }
+        }
         result = self.session.put(url, json=var_filter)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["names"], ["name", "n_cells"])
         self.assertEqual(len(result_data["data"]), 2)
@@ -287,10 +268,17 @@ class EndPoints(unittest.TestCase):
         endpoint = "annotations/var"
         query = "annotation-name=n_cells"
         url = f"{URL_BASE}{endpoint}?{query}"
-        var_filter = {"filter": {"var": {"annotation_value": [{"name": "name", "values": ["ATAD3C", "RER1"]}]}}}
+        var_filter = {
+            "filter": {
+                "var": {
+                    "annotation_value": [
+                        {"name": "name", "values": ["ATAD3C", "RER1"]},
+                    ]
+                }
+            }
+        }
         result = self.session.put(url, json=var_filter)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data = result.json()
         self.assertEqual(result_data["names"], ["n_cells"])
         self.assertEqual(len(result_data["data"][0]), 2)
@@ -303,7 +291,6 @@ class EndPoints(unittest.TestCase):
             url = f"{URL_BASE}{endpoint}?{query}"
             result = self.session.get(url)
             self.assertEqual(result.status_code, HTTPStatus.OK)
-            self.assertEqual(result.headers["Content-Type"], "application/json")
             result_data = result.json()
             self.assertEqual(len(result_data["obs"]), 2638)
 
@@ -325,7 +312,6 @@ class EndPoints(unittest.TestCase):
             url = f"{URL_BASE}{endpoint}"
             result = self.session.get(url)
             self.assertEqual(result.status_code, HTTPStatus.OK)
-            self.assertEqual(result.headers["Content-Type"], "application/json")
 
     def test_data_filter(self):
         for axis in ["obs", "var"]:
@@ -334,11 +320,10 @@ class EndPoints(unittest.TestCase):
             url = f"{URL_BASE}{endpoint}?{query}"
             result = self.session.get(url)
             self.assertEqual(result.status_code, HTTPStatus.OK)
-            self.assertEqual(result.headers["Content-Type"], "application/json")
             result_data = result.json()
             self.assertEqual(len(result_data["obs"]), 38)
 
-    def test_data_json_put(self):
+    def test_data_put(self):
         for axis in ["obs", "var"]:
             endpoint = f"data/{axis}"
             url = f"{URL_BASE}{endpoint}"
@@ -350,48 +335,31 @@ class EndPoints(unittest.TestCase):
                             {"name": "louvain", "values": ["NK cells", "CD8 T cells"]},
                             {"name": "n_counts", "min": 3000},
                         ],
-                        "index": [1, 99, [1000, 2000]],
+                        "index": [1, 99, [1000, 2000]]
                     }
                 }
             }
             result = self.session.put(url, headers=header, json=obs_filter)
             self.assertEqual(result.status_code, HTTPStatus.OK)
-            self.assertEqual(result.headers["Content-Type"], "application/json")
             result_data = result.json()
             self.assertEqual(len(result_data["obs"]), 15)
 
-    def test_data_put_fbs(self):
-        endpoint = f"data/var"
-        url = f"{URL_BASE}{endpoint}"
-        header = {"Accept": "application/octet-stream"}
-        filter = {
-            "filter": {
-                "var": {
-                    "index": [0, 1, 4]
-                }
-            }
-        }
-        result = self.session.put(url, headers=header, json=filter)
-        self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/octet-stream")
-        df = decode_fbs.decode_matrix_FBS(result.content)
-        self.assertEqual(df['n_rows'], 2638)
-        self.assertEqual(df['n_cols'], 3)
-        self.assertIsNotNone(df['columns'])
-        self.assertIsNotNone(df['col_idx'])
-        self.assertIsNone(df['row_idx'])
-        self.assertEqual(len(df['columns']), df['n_cols'])
-        self.assertListEqual(df['col_idx'].tolist(), [0, 1, 4])
-
     def test_data_put_single_var(self):
         for axis in ["obs", "var"]:
             endpoint = f"data/{axis}"
             url = f"{URL_BASE}{endpoint}"
             header = {"Accept": "application/json"}
-            var_filter = {"filter": {"var": {"annotation_value": [{"name": "name", "values": ["RER1"]}]}}}
+            var_filter = {
+                "filter": {
+                    "var": {
+                        "annotation_value": [
+                            {"name": "name", "values": ["RER1"]},
+                        ]
+                    }
+                }
+            }
             result = self.session.put(url, headers=header, json=var_filter)
             self.assertEqual(result.status_code, HTTPStatus.OK)
-            self.assertEqual(result.headers["Content-Type"], "application/json")
             result_data = result.json()
             if axis == "obs":
                 self.assertEqual(len(result_data["obs"][0]), 2)
@@ -403,48 +371,18 @@ class EndPoints(unittest.TestCase):
     def test_cache(self):
         endpoint = "annotations/var"
         url = f"{URL_BASE}{endpoint}"
-        f1 = {
-            "filter": {
-                "var": {
-                    "annotation_value": [
-                        {
-                            "name": "name",
-                            "values": [
-                                "HLA-DRB1",
-                                "HLA-DQA1",
-                                "HLA-DQB1",
-                                "HLA-DPA1",
-                                "HLA-DPB1",
-                                "MS4A1",
-                                "IL32",
-                                "CCL5",
-                                "CD79B",
-                                "CD79A",
-                            ],
-                        }
-                    ]
-                }
-            }
-        }
+        f1 = {"filter": {"var": {"annotation_value": [{"name": "name",
+                                                       "values": ["HLA-DRB1", "HLA-DQA1", "HLA-DQB1", "HLA-DPA1",
+                                                                  "HLA-DPB1", "MS4A1", "IL32", "CCL5", "CD79B",
+                                                                  "CD79A"]}]}}}
         result = self.session.put(url, json=f1)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data1 = result.json()
-        f2 = {
-            "filter": {
-                "var": {
-                    "annotation_value": [
-                        {
-                            "name": "name",
-                            "values": ["FGFBP2", "GZMA", "LTB", "PRF1", "CTSW", "GZMH", "CCL5", "CCL4", "CST7", "NKG7"],
-                        }
-                    ]
-                }
-            }
-        }
+        f2 = {"filter": {"var": {"annotation_value": [{"name": "name",
+                                                       "values": ["FGFBP2", "GZMA", "LTB", "PRF1", "CTSW", "GZMH",
+                                                                  "CCL5", "CCL4", "CST7", "NKG7"]}]}}}
         result = self.session.put(url, json=f2)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data2 = result.json()
         self.assertNotEqual(result_data1, result_data2)
 
@@ -455,21 +393,11 @@ class EndPoints(unittest.TestCase):
         result = self.session.put(url, json=f1)
         self.assertEqual(result.status_code, HTTPStatus.OK)
         result_data1 = result.json()
-        f2 = {
-            "filter": {
-                "var": {
-                    "annotation_value": [
-                        {
-                            "name": "name",
-                            "values": ["FGFBP2", "GZMA", "LTB", "PRF1", "CTSW", "GZMH", "CCL5", "CCL4", "CST7", "NKG7"],
-                        }
-                    ]
-                }
-            }
-        }
+        f2 = {"filter": {"var": {"annotation_value": [{"name": "name",
+                                                       "values": ["FGFBP2", "GZMA", "LTB", "PRF1", "CTSW", "GZMH",
+                                                                  "CCL5", "CCL4", "CST7", "NKG7"]}]}}}
         result = self.session.put(url, json=f2)
         self.assertEqual(result.status_code, HTTPStatus.OK)
-        self.assertEqual(result.headers["Content-Type"], "application/json")
         result_data2 = result.json()
         self.assertNotEqual(result_data1, result_data2)
 

server/test/test_filter.py

@@ -54,17 +54,13 @@ class UtilTest(unittest.TestCase):
 
     def test_complex_filter(self):
         filter_dict = ImmutableMultiDict(
-            [("obs:louvain", "NK cells"), ("obs:louvain", "CD8 T cells"), ("obs:n_counts", "3000,*")]
-        )
+            [("obs:louvain", "NK cells"), ("obs:louvain", "CD8 T cells"), ("obs:n_counts", "3000,*")])
         filter_ = parse_filter(filter_dict, self.schema)
         self.assertIn("obs", filter_)
-        self.assertEqual(
-            filter_["obs"]["annotation_value"],
-            [
-                {"name": "louvain", "values": ["NK cells", "CD8 T cells"]},
-                {"name": "n_counts", "max": None, "min": 3000.0},
-            ],
-        )
+        self.assertEqual(filter_["obs"]["annotation_value"], [{"name": "louvain",
+                                                               "values": ["NK cells", "CD8 T cells"]},
+                                                              {"name": "n_counts",
+                                                               "max": None, "min": 3000.0}])
 
     def test_bad_filter(self):
         bad_annotation_type = ImmutableMultiDict([("obs:tissue", "lung")])
@@ -75,7 +71,9 @@ class UtilTest(unittest.TestCase):
             parse_filter(bad_axis, self.schema)
 
     def test_boolean_filter(self):
-        schema = {"obs": [{"name": "bool_filter", "type": "boolean"}]}
+        schema = {
+            "obs": [{"name": "bool_filter", "type": "boolean"}]
+        }
         filter_dict = ImmutableMultiDict([("obs:bool_filter", "false")])
         filter_ = parse_filter(filter_dict, schema)
         self.assertIn("obs", filter_)

server/test/test_nan_rest.py

@@ -1,51 +0,0 @@
-from http import HTTPStatus
-from subprocess import Popen
-import unittest
-import time
-
-import requests
-
-LOCAL_URL = "http://127.0.0.1:5005/"
-VERSION = "v0.2"
-URL_BASE = f"{LOCAL_URL}api/{VERSION}/"
-
-BAD_FILTER = {"filter": {"obs": {"annotation_value": [{"name": "xyz"}]}}}
-
-
-class WithNaNs(unittest.TestCase):
-    """Test Case for endpoints"""
-
-    @classmethod
-    def setUpClass(cls):
-        cls.ps = Popen(
-            ["cellxgene", "launch", "server/test/test_datasets/nan.h5ad", "--debug"]
-        )
-        session = requests.Session()
-        for i in range(90):
-            try:
-                session.get(f"{URL_BASE}schema")
-            except requests.exceptions.ConnectionError:
-                time.sleep(1)
-
-    @classmethod
-    def tearDownClass(cls):
-        try:
-            cls.ps.terminate()
-        except ProcessLookupError:
-            pass
-
-    def setUp(self):
-        self.session = requests.Session()
-
-    def test_initialize(self):
-        endpoint = "schema"
-        url = f"{URL_BASE}{endpoint}"
-        result = self.session.get(url)
-        self.assertEqual(result.status_code, HTTPStatus.OK)
-
-    def test_errors(self):
-        endpoints = ["annotations/obs", "annotations/var", "data/obs", "data/var"]
-        for endpoint in endpoints:
-            url = f"{URL_BASE}{endpoint}"
-            result = self.session.get(url)
-            self.assertEqual(result.status_code, HTTPStatus.INTERNAL_SERVER_ERROR)

server/test/test_nan_scanpy_engine.py

@@ -1,72 +0,0 @@
-import json
-import pytest
-import unittest
-import warnings
-import math
-
-import decode_fbs
-
-from server.app.scanpy_engine.scanpy_engine import ScanpyEngine
-from server.app.util.errors import JSONEncodingValueError
-
-
-class NaNTest(unittest.TestCase):
-    def setUp(self):
-        self.args = {
-            "layout": "umap",
-            "diffexp": "ttest",
-            "max_category_items": 100,
-            "obs_names": None,
-            "var_names": None,
-            "diffexp_lfc_cutoff": 0.01,
-        }
-        with warnings.catch_warnings():
-            warnings.simplefilter("ignore", category=UserWarning)
-            self.data = ScanpyEngine("server/test/test_datasets/nan.h5ad", self.args)
-            self.data._create_schema()
-
-    def test_load(self):
-        with self.assertWarns(UserWarning):
-            ScanpyEngine("server/test/test_datasets/nan.h5ad", self.args)
-
-    def test_init(self):
-        self.assertEqual(self.data.cell_count, 100)
-        self.assertEqual(self.data.gene_count, 100)
-        epsilon = 0.000_005
-        self.assertTrue(self.data.data.X[0, 0] - -0.171_469_51 < epsilon)
-
-    def test_dataframe(self):
-        data_frame_var = decode_fbs.decode_matrix_FBS(self.data.data_frame_to_fbs_matrix(None, "var"))
-        self.assertIsNotNone(data_frame_var)
-        self.assertEqual(data_frame_var["n_rows"], 100)
-        self.assertEqual(data_frame_var["n_cols"], 100)
-        self.assertTrue(math.isnan(data_frame_var["columns"][3][3]))
-
-        with pytest.raises(JSONEncodingValueError):
-            json.loads(self.data.data_frame(None, "obs"))
-        with pytest.raises(JSONEncodingValueError):
-            json.loads(self.data.data_frame(None, "var"))
-
-    def test_dataframe_obs_not_implemented(self):
-        with self.assertRaises(ValueError) as cm:
-            decode_fbs.decode_matrix_FBS(self.data.data_frame_to_fbs_matrix(None, "obs"))
-        self.assertIsNotNone(cm.exception)
-
-    def test_annotation(self):
-        annotations = decode_fbs.decode_matrix_FBS(self.data.annotation_to_fbs_matrix("obs"))
-        self.assertEqual(
-            annotations["col_idx"],
-            ["name", "n_genes", "percent_mito", "n_counts", "louvain"]
-        )
-        self.assertEqual(annotations["n_rows"], 100)
-        self.assertTrue(math.isnan(annotations["columns"][2][0]))
-
-        annotations = decode_fbs.decode_matrix_FBS(self.data.annotation_to_fbs_matrix("var"))
-        self.assertEqual(annotations["col_idx"], ["name", "n_cells", "var_with_nans"])
-        self.assertEqual(annotations["n_rows"], 100)
-        self.assertTrue(math.isnan(annotations["columns"][2][0]))
-
-        with pytest.raises(JSONEncodingValueError):
-            json.loads(self.data.annotation(None, "obs"))
-        with pytest.raises(JSONEncodingValueError):
-            json.loads(self.data.annotation(None, "var"))

server/test/test_scanpy_engine.py

@@ -3,6 +3,7 @@ from os import path
 import pytest
 import time
 import unittest
+import argparse
 
 import numpy as np
 from pandas import Series
@@ -12,14 +13,8 @@ from server.app.scanpy_engine.scanpy_engine import ScanpyEngine
 
 class UtilTest(unittest.TestCase):
     def setUp(self):
-        args = {
-            "layout": "umap",
-            "diffexp": "ttest",
-            "max_category_items": 100,
-            "obs_names": None,
-            "var_names": None,
-            "diffexp_lfc_cutoff": 0.01,
-        }
+        args = {'layout': 'umap', 'diffexp': 'ttest', 'max_category_items': 100,
+                'obs_names': None, 'var_names': None, 'diffexp_lfc_cutoff': 0.01}
 
         self.data = ScanpyEngine("example-dataset/pbmc3k.h5ad", args)
         self.data._create_schema()
@@ -27,8 +22,8 @@ class UtilTest(unittest.TestCase):
     def test_init(self):
         self.assertEqual(self.data.cell_count, 2638)
         self.assertEqual(self.data.gene_count, 1838)
-        epsilon = 0.000_005
-        self.assertTrue(self.data.data.X[0, 0] - -0.171_469_51 < epsilon)
+        epsilon = 0.000005
+        self.assertTrue(self.data.data.X[0, 0] - -0.17146951 < epsilon)
 
     def test_mandatory_annotations(self):
         self.assertIn("name", self.data.data.obs)
@@ -45,8 +40,12 @@ class UtilTest(unittest.TestCase):
     def test_filter_idx(self):
         filter_ = {
             "filter": {
-                "var": {"index": [1, 99, [200, 300]]},
-                "obs": {"index": [1, 99, [1000, 2000]]},
+                "var": {
+                    "index": [1, 99, [200, 300]]
+                },
+                "obs": {
+                    "index": [1, 99, [1000, 2000]]
+                }
             }
         }
         data = self.data.filter_dataframe(filter_["filter"])
@@ -57,7 +56,7 @@ class UtilTest(unittest.TestCase):
             "filter": {
                 "obs": {
                     "annotation_value": [
-                        {"name": "louvain", "values": ["NK cells", "CD8 T cells"]}
+                        {"name": "louvain", "values": ["NK cells", "CD8 T cells"]},
                     ]
                 }
             }
@@ -65,7 +64,13 @@ class UtilTest(unittest.TestCase):
         data = self.data.filter_dataframe(filter_["filter"])
         self.assertEqual(data.shape, (470, 1838))
         filter_ = {
-            "filter": {"obs": {"annotation_value": [{"name": "n_counts", "min": 3000}]}}
+            "filter": {
+                "obs": {
+                    "annotation_value": [
+                        {"name": "n_counts", "min": 3000},
+                    ]
+                }
+            }
         }
         data = self.data.filter_dataframe(filter_["filter"])
         self.assertEqual(data.shape, (497, 1838))
@@ -73,7 +78,11 @@ class UtilTest(unittest.TestCase):
     def test_filter_annotation_no_uns(self):
         filter_ = {
             "filter": {
-                "var": {"annotation_value": [{"name": "name", "values": ["RER1"]}]}
+                "var": {
+                    "annotation_value": [
+                        {"name": "name", "values": ["RER1"]},
+                    ]
+                }
             }
         }
         data = self.data.filter_dataframe(filter_["filter"])
@@ -82,14 +91,16 @@ class UtilTest(unittest.TestCase):
     def test_filter_complex(self):
         filter_ = {
             "filter": {
-                "var": {"index": [1, 99, [200, 300]]},
+                "var": {
+                    "index": [1, 99, [200, 300]]
+                },
                 "obs": {
                     "annotation_value": [
                         {"name": "louvain", "values": ["NK cells", "CD8 T cells"]},
                         {"name": "n_counts", "min": 3000},
                     ],
-                    "index": [1, 99, [1000, 2000]],
-                },
+                    "index": [1, 99, [1000, 2000]]
+                }
             }
         }
         data = self.data.filter_dataframe(filter_["filter"])
@@ -105,101 +116,118 @@ class UtilTest(unittest.TestCase):
             self.assertEqual(self.data.schema, schema)
 
     def test_schema_produces_error(self):
-        self.data.data.obs["time"] = Series(
-            list([time.time() for i in range(self.data.cell_count)]),
-            dtype="datetime64[ns]",
-        )
+        self.data.data.obs["time"] = Series(list([time.time() for i in range(self.data.cell_count)]),
+                                            dtype="datetime64[ns]")
         with pytest.raises(TypeError):
             self.data._create_schema()
 
     def test_config(self):
-        self.assertEqual(
-            self.data.features["layout"]["obs"],
-            {"available": True, "interactiveLimit": 50000},
-        )
+        self.assertEqual(self.data.features["layout"]["obs"], {'available': True, 'interactiveLimit': 50000})
 
     def test_layout(self):
-        layout = json.loads(self.data.layout(None))
-        self.assertEqual(layout["layout"]["ndims"], 2)
-        self.assertEqual(len(layout["layout"]["coordinates"]), 2638)
-        self.assertEqual(layout["layout"]["coordinates"][0][0], 0)
-        for idx, val in enumerate(layout["layout"]["coordinates"]):
+        layout = self.data.layout(None)
+        self.assertEqual(layout["ndims"], 2)
+        self.assertEqual(len(layout["coordinates"]), 2638)
+        self.assertEqual(layout["coordinates"][0][0], 0)
+        for idx, val in enumerate(layout["coordinates"]):
             self.assertLessEqual(val[1], 1)
             self.assertLessEqual(val[2], 1)
 
     def test_annotations(self):
-        annotations = json.loads(self.data.annotation(None, "obs"))
-        self.assertEqual(
-            annotations["names"],
-            ["name", "n_genes", "percent_mito", "n_counts", "louvain"],
-        )
+        annotations = self.data.annotation(None, "obs")
+        self.assertEqual(annotations["names"], ["name", "n_genes", "percent_mito", "n_counts", "louvain"])
         self.assertEqual(len(annotations["data"]), 2638)
-        annotations = json.loads(self.data.annotation(None, "var"))
+        annotations = self.data.annotation(None, "var")
         self.assertEqual(annotations["names"], ["name", "n_cells"])
         self.assertEqual(len(annotations["data"]), 1838)
 
     def test_annotation_fields(self):
-        annotations = json.loads(
-            self.data.annotation(None, "obs", ["n_genes", "n_counts"])
-        )
+        annotations = self.data.annotation(None, "obs", ["n_genes", "n_counts"])
         self.assertEqual(annotations["names"], ["n_genes", "n_counts"])
         self.assertEqual(len(annotations["data"]), 2638)
-        annotations = json.loads(self.data.annotation(None, "var", ["name"]))
+        annotations = self.data.annotation(None, "var", ["name"])
         self.assertEqual(annotations["names"], ["name"])
         self.assertEqual(len(annotations["data"]), 1838)
 
     def test_filtered_annotation(self):
         filter_ = {
             "filter": {
-                "obs": {"annotation_value": [{"name": "n_counts", "min": 3000}]},
-                "var": {
-                    "annotation_value": [{"name": "name", "values": ["ATAD3C", "RER1"]}]
+                "obs": {
+                    "annotation_value": [
+                        {"name": "n_counts", "min": 3000},
+                    ]
                 },
+                "var": {
+                    "annotation_value": [
+                        {"name": "name", "values": ["ATAD3C", "RER1"]},
+                    ]
+                }
             }
         }
-        annotations = json.loads(self.data.annotation(filter_["filter"], "obs"))
-        self.assertEqual(
-            annotations["names"],
-            ["name", "n_genes", "percent_mito", "n_counts", "louvain"],
-        )
+        annotations = self.data.annotation(filter_["filter"], "obs")
+        self.assertEqual(annotations["names"], ["name", "n_genes", "percent_mito", "n_counts", "louvain"])
         self.assertEqual(len(annotations["data"]), 497)
-        annotations = json.loads(self.data.annotation(filter_["filter"], "var"))
+        annotations = self.data.annotation(filter_["filter"], "var")
         self.assertEqual(annotations["names"], ["name", "n_cells"])
         self.assertEqual(len(annotations["data"]), 2)
 
     def test_filtered_layout(self):
         filter_ = {
-            "filter": {"obs": {"annotation_value": [{"name": "n_counts", "min": 3000}]}}
+            "filter": {
+                "obs": {
+                    "annotation_value": [
+                        {"name": "n_counts", "min": 3000},
+                    ]
+                }
+            }
         }
-        layout = json.loads(self.data.layout(filter_["filter"]))
-        self.assertEqual(len(layout["layout"]["coordinates"]), 497)
+        layout = self.data.layout(filter_["filter"])
+        self.assertEqual(len(layout["coordinates"]), 497)
 
     def test_diffexp_topN(self):
-        f1 = {"filter": {"obs": {"index": [[0, 500]]}}}
-        f2 = {"filter": {"obs": {"index": [[500, 1000]]}}}
-        result = json.loads(self.data.diffexp_topN(f1["filter"], f2["filter"]))
+        f1 = {
+            "filter": {
+                "obs": {
+                    "index": [[0, 500]]
+                }
+            }
+        }
+        f2 = {
+            "filter": {
+                "obs": {
+                    "index": [[500, 1000]]
+                }
+            }
+        }
+        result = self.data.diffexp_topN(f1["filter"], f2["filter"])
         self.assertEqual(len(result), 10)
-        result = json.loads(self.data.diffexp_topN(f1["filter"], f2["filter"], 20))
+        result = self.data.diffexp_topN(f1["filter"], f2["filter"], 20)
         self.assertEqual(len(result), 20)
 
     def test_data_frame(self):
-        data_frame_obs = json.loads(self.data.data_frame(None, "obs"))
+        data_frame_obs = self.data.data_frame(None, "obs")
         self.assertEqual(len(data_frame_obs["var"]), 1838)
         self.assertEqual(len(data_frame_obs["obs"]), 2638)
-        data_frame_var = json.loads(self.data.data_frame(None, "var"))
+        data_frame_var = self.data.data_frame(None, "var")
         self.assertEqual(len(data_frame_var["var"]), 1838)
         self.assertEqual(len(data_frame_var["obs"]), 2638)
 
     def test_filtered_data_frame(self):
         filter_ = {
-            "filter": {"obs": {"annotation_value": [{"name": "n_counts", "min": 3000}]}}
+            "filter": {
+                "obs": {
+                    "annotation_value": [
+                        {"name": "n_counts", "min": 3000},
+                    ]
+                }
+            }
         }
-        data_frame_obs = json.loads(self.data.data_frame(filter_["filter"], "obs"))
+        data_frame_obs = self.data.data_frame(filter_["filter"], "obs")
         self.assertEqual(len(data_frame_obs["var"]), 1838)
         self.assertEqual(len(data_frame_obs["obs"]), 497)
         self.assertIsInstance(data_frame_obs["obs"][0], (list, tuple))
         self.assertEqual(type(data_frame_obs["var"][0]), int)
-        data_frame_var = json.loads(self.data.data_frame(filter_["filter"], "var"))
+        data_frame_var = self.data.data_frame(filter_["filter"], "var")
         self.assertEqual(len(data_frame_var["var"]), 1838)
         self.assertEqual(len(data_frame_var["obs"]), 497)
         self.assertIsInstance(data_frame_var["var"][0], (list, tuple))
@@ -209,10 +237,14 @@ class UtilTest(unittest.TestCase):
         for axis in ["obs", "var"]:
             filter_ = {
                 "filter": {
-                    "var": {"annotation_value": [{"name": "name", "values": ["RER1"]}]}
+                    "var": {
+                        "annotation_value": [
+                            {"name": "name", "values": ["RER1"]},
+                        ]
+                    }
                 }
             }
-            data_frame_var = json.loads(self.data.data_frame(filter_["filter"], axis))
+            data_frame_var = self.data.data_frame(filter_["filter"], axis)
             if axis == "obs":
                 self.assertEqual(type(data_frame_var["var"][0]), int)
                 self.assertIsInstance(data_frame_var["obs"][0], (list, tuple))
@@ -220,5 +252,5 @@ class UtilTest(unittest.TestCase):
                 self.assertEqual(type(data_frame_var["obs"][0]), int)
                 self.assertIsInstance(data_frame_var["var"][0], (list, tuple))
 
-    if __name__ == "__main__":
+    if __name__ == '__main__':
         unittest.main()

setup.cfg

@@ -1,4 +1,2 @@
 [flake8]
 max-line-length = 120
-ignore = E203, W503
-exclude = server/app/util/fbs/NetEncoding/

setup.py

@@ -1,13 +1,4 @@
 from setuptools import setup, find_packages
-import sys
-
-if sys.version_info[0:2] != (3, 6):
-    raise ImportError(
-        "cellxgene currently only supports python 3.6. Python 3.7 is known to fail; we will look at supporting "
-        "versions other than 3.6 in the future."
-        "See https://github.com/chanzuckerberg/cellxgene#conda-and-virtual-environments "
-        "for more help with installation."
-    )
 
 with open("README.md", "rb") as fh:
     long_description = fh.read().decode()
@@ -17,7 +8,7 @@ with open("server/requirements.txt") as fh:
 
 setup(
     name="cellxgene",
-    version="0.5.0",
+    version="0.2.4",
     packages=find_packages(),
     url="https://github.com/chanzuckerberg/cellxgene",
     license="MIT",
@@ -25,24 +16,19 @@ setup(
     author_email="cweaver@chanzuckerberg.com",
     description="Web application for exploration of large scale scRNA-seq datasets",
     long_description=long_description,
-    long_description_content_type="text/markdown",
+    long_description_content_type='text/markdown',
     install_requires=requirements,
     include_package_data=True,
     zip_safe=False,
-    classifiers=[
-        "Framework :: Flask",
-        "Intended Audience :: Science/Research",
-        "License :: OSI Approved :: MIT License",
-        "Natural Language :: English",
-        "Operating System :: POSIX",
-        "Operating System :: Unix",
-        "Operating System :: MacOS :: MacOS X",
-        "Programming Language :: JavaScript",
+    classifiers=(
         "Programming Language :: Python :: 3",
-        "Programming Language :: Python :: 3.6",
-        "Programming Language :: Python :: 3 :: Only",
-        "Topic :: Scientific/Engineering :: Bio-Informatics",
-    ],
-    entry_points={"console_scripts": ["cellxgene = server.cli.cli:cli"]},
-    extras_require=dict(louvain=["python-igraph", "louvain>=0.6"]),
+        "License :: OSI Approved :: MIT License",
+    ),
+    entry_points={
+        "console_scripts":
+            ["cellxgene = server.cli.cli:cli"]
+    },
+    extras_require=dict(
+        louvain=['python-igraph', 'louvain>=0.6'],
+    ),
 )