Commit Graph

175 Commits

Author SHA1 Message Date
Heng Li
7a540c37ca r1278: reduced --min-dp-len to 20 for splice:sr
30% reduced time at 0.01% more junction errors
2025-04-16 21:55:59 -04:00
Heng Li
c19e3ccb86 r1277: don't apply rescored filtering with -P
Since v2.19-ish, minimap2 rescores base alignment based on the best alignment
of a read. This heuristic sometimes improve the mapping accuracy of the best
alignment but may too aggressively filter weaker hits.

Resolve #969
2025-04-14 22:26:47 -04:00
Heng Li
94d171b01e r1276: skip unnecessary reverse spliced alignment
for short-read RNA-seq only
2025-04-14 14:57:23 -04:00
Heng Li
9c3c4b1ce8 r1267: penalize introns without signals 2025-04-07 09:51:33 -04:00
Heng Li
75619c7b51 r1265: prefer spliced alignment
mapq needs to be elevated
2025-04-07 00:31:04 -04:00
Heng Li
af094640e5 r1263: ~5-10% performance improvement
Via larger batches and more short-read heuristics. Identical alignment on 2
million reads. Short DNA-seq read alignment may be improved in corner cases.
2025-04-06 20:48:55 -04:00
Heng Li
9ede5c4255 backup 2025-04-06 00:07:15 -04:00
Heng Li
9d06cef13e r1248: support --end-bonus in splice mode
but this is not enabled by default for now
2025-04-02 21:39:41 -04:00
Heng Li
8efe83b744 fill the junction array
modifying ksw will be the next
2024-10-11 23:22:23 -04:00
Heng Li
042c8d4d71 added --junc-pen; it does nothing for now 2024-10-11 21:27:25 -04:00
Heng Li
89d4d219cd r1206: enabled RMQ for lr:hqae
Also fixed a bug in determining inner_dist for RMQ. It should have no effect on
previous presets.
2024-03-20 15:29:54 -04:00
Heng Li
fcd4df2a73 r1190: output unadjusted dp_max to ms:i
This was an oversight affecting v2.22+. The latest minimap2 ranks hits and
estimates mapping quality with an adjusted alignment score (see the minimap2
update paper). This score however is not calculated when there is only one hit.
As a result, the ms:i tag varies depends on other sequences in the reference
genome, which is confusing. This change lets minimap2 to output the unadjusted
score at ms:i. At present, the adjusted score is not outputted.

Resolves #1146
2024-03-11 17:19:13 -04:00
Heng Li
8140259974 r1183: added lr:hq; fixed transition
* Added the lr:hq preset suggested by Nanopore developers (#1127)
 * Fixed transition scoring. It did not work with presets.
 * Cleaned up preset documentation
2024-03-10 13:47:34 -04:00
Aaron Darling
ace990c381 Illumina Complete Long Read presets (#1069)
* Implements a transition-aware alignment scoring scheme and configuration presets for ICLR

* Fix to enable use of general scoring matrix in ksw as suggested by lh3

---------

Co-authored-by: koadman <>
2023-06-04 11:06:15 -04:00
Heng Li
5e7242303c r1164: changed the syntax of -J 2023-04-07 22:54:33 -04:00
Heng Li
6c2cbf7903 miniprot-like splice model
slightly worse on iso-seq and slightly better on direct-RNA
2022-10-06 09:10:17 -04:00
Heng Li
8a1d52bcbe r1094: for --split-prefix update max_dp at the end 2021-08-06 21:40:43 -04:00
Heng Li
1a8373bb84 dev-r1080: fixed negative dp_max 2021-07-18 21:07:14 -04:00
Heng Li
161ae7ff73 dev-r1079: per-read error rate
more tuning needed
2021-07-18 20:38:53 -04:00
Heng Li
8a6edab847 dev-r1078: decoupling ranking penalty 2021-07-18 16:22:48 -04:00
Heng Li
2546999639 dev-r1076: log gap penalty 2021-07-17 18:23:59 -04:00
Heng Li
5f449c5cae fixed potential integer overflows 2021-07-16 17:20:05 -04:00
Heng Li
b046052d82 Merge branch 'master' into utec 2021-07-16 13:32:47 -04:00
John Marshall
260a68d232 Use #defines for CIGAR operators in C code
Give the CIGAR constants names to clarify the code. So that ksw2.h
remains self-contained, define KSW_* versions of the CIGAR operators
it needs for use within ksw2.h. Other code should in general use the
full set of MM_CIGAR_* constants in minimap.h.
2021-07-02 13:03:03 -04:00
John Marshall
177eef259d Use the full MIDNSHP=X string whenever printing CIGAR strings
Define MM_CIGAR_STR to the full string of CIGAR operators (including
the 'B' operator as well) and use it throughout the C code.

It would be possible to use it from the Cython code too, but it's easier
to keep that as a Cython string literal to avoid adding extra runtime
code to handle locale conversion.
2021-07-02 13:03:03 -04:00
Heng Li
4f91558160 r1048: rescue long gaps 2021-05-24 16:09:09 -04:00
Heng Li
827ca4b461 r1012: fixed an off-by-one bug; resolves #489 2021-04-07 23:31:31 -04:00
Armin Töpfer
c9874e2dc5 Initialize r->p if ez->zdropped 2020-06-12 09:22:18 -04:00
Heng Li
da7109fd29 r985: optionally report cs/cg on the query strand
PAF only; not well tested
2020-04-21 12:37:35 -04:00
Heng Li
a7a01fe5bd r973: fixed compiling errors caused 2020-01-21 10:43:31 -05:00
Heng Li
eb3ed6993d support ALT mapping 2020-01-21 09:17:50 -05:00
Heng Li
69af86657e r935: fixed a cigar like 5I6D7I; resolved #392 2019-04-30 21:35:24 -04:00
Heng Li
be171aa2dc implemented in exts; testing is the next 2019-04-28 16:47:12 -04:00
Heng Li
cf2bae6e9b r904: fixed a corner-case segfault. Resolves #307. 2019-01-10 09:57:05 -05:00
Heng Li
83a8ee7038 r888: fixed incorrect CIGAR when --eqx in use
This was caused by mm_fix_cigar() which may change query/target offset in very
rare cases. Generating EQX has to beware of this change.

Resolves #266
2018-11-18 14:22:29 -05:00
Heng Li
88c421e8de r881: a recent change reduces sr accuracy 2018-11-05 22:03:59 -05:00
Heng Li
13981404e2 r876: skip DP if taking too much RAM (#259) 2018-11-05 11:43:10 -05:00
Heng Li
377c7099a8 r858: fixed a bug; resolves #254 2018-10-22 22:47:11 -04:00
Heng Li
d04ac068fd r852: a minor when large --end-bonus is in use
We may use a large --end-bonus to mimic end-to-end alignment. In the short-read
mode, the candidate alignment region may be out of the band, which leads to
truncated alignment.
2018-10-15 21:28:27 -04:00
Heng Li
5ab6538757 r822: added option --no-end-flt 2018-08-05 19:42:12 -04:00
Heng Li
4b707aac92 working with toy examples 2018-07-15 10:55:00 -04:00
Heng Li
951c0d1d35 apparently mm_append_cigar() wastes some memory 2018-07-14 23:47:44 -04:00
Heng Li
66674afd09 r794: fixed a bug in seed filtering 2018-06-20 10:26:29 -04:00
Heng Li
7e6e8ca73f r792: fixed -Wextra warnings and resolved #184 2018-06-19 15:26:58 -04:00
Aaron Wenger
3d3bcc29a8 Fix CIGAR reallocation with --eqx
Fix the logic that calculates the number of CIGAR entries when
match "M" entries are expanded into "=" and "X".  The number
of entries depends not on the number of mismatches but rather
on the number of transitions between "=" to "X".
2018-06-19 14:37:41 -04:00
Heng Li
154d2caf5b r784: support the =/X CIGAR operators (#156) 2018-05-30 16:11:22 -04:00
Heng Li
a3afeec0b2 r783: reverted to r781 (#155) 2018-05-30 15:25:34 -04:00
Heng Li
9f4309c376 r777: avoid skipping too many seeds 2018-05-11 10:25:18 -04:00
Heng Li
881b4ca3a2 r774: Merge branch 'hot-fix' into fix-long-gap 2018-05-11 10:02:17 -04:00
Heng Li
e61812ee55 reduced gap len to trigger bad seed filtering 2018-05-01 16:17:21 -04:00