Commit Graph

994 Commits

Author SHA1 Message Date
Bruce Martin
8b329630f8 fix for issue 1112 - all user annotation category names must be unique across all obs annotatoins (#1114) 2020-01-16 09:28:29 -08:00
Bruce Martin
30f3ce49e4 update JS dependencies (#1106) 2020-01-15 17:11:51 -08:00
Matt Weiden
ddbfc458d7 Remove d3 dependency in crossfilter (#1108)
* Remove d3 dependency in crossfilter

Fixes https://github.com/chanzuckerberg/cellxgene/issues/648

* Revert "Remove d3 dependency in crossfilter"

This reverts commit 03b478f7dc.

* Remove d3 dependency in crossfilter

Fixes https://github.com/chanzuckerberg/cellxgene/issues/648

* Fix typo in docstring
2020-01-14 13:46:53 -08:00
Sidney Bell
124254d5ed typo 2020-01-13 10:55:53 -08:00
Bruce Martin
677433bbf5 Fix label sorting bugs (#1102)
* move category label sort to utils

* refactor cat label sort

* fix category label sort and color assignment

* convert whitespace from tabs to spaces
2020-01-09 13:34:25 -08:00
Matt Weiden
e1ff800980 Rename Makefile target build-server to build-cli (#1103)
The `build-server` makefile target does not actually build the server
module, rather it builds the CLI. Rename this target to make it less
confusing.
2020-01-09 07:52:20 -08:00
Bruce Martin
2d39cb3b30 sort the embedding names for the UI (#1098) 2020-01-09 06:33:14 -08:00
Bruce Martin
18177b108f fix 1090 - add unassigned label to the new category, not the source category (#1094) 2020-01-09 06:32:38 -08:00
Matt Weiden
be54d583f1 Only copy versioned files to the package (#1096)
Fixes https://github.com/chanzuckerberg/cellxgene/issues/582
2020-01-08 08:12:51 -08:00
Matt Weiden
4c1ecf9e52 Specify histogram thresholds in fixed-length array (#1086)
* Specify histogram thresholds in fixed-length array

Fixes https://github.com/chanzuckerberg/cellxgene/issues/1082

For background, see the following:
* https://github.com/d3/d3-array/issues/46
* https://stackoverflow.com/questions/15880058/d3-js-ticks-function-giving-more-elements-than-needed

* Oops, off by one!
2020-01-06 11:13:02 -08:00
Matt Weiden
b172ff7f15 Add margins to histogram SVGs (#1085)
* Add a left margin to histogram SVGs

Fixes https://github.com/chanzuckerberg/cellxgene/issues/1042

1. Added "margins" to the SVG as in https://bl.ocks.org/mbostock/3019563
2. Tailored the brushable area to be just where the data is and locked
   puppeteerUtils to use that in e2e testing.

* Dial in margins to avoid y-axis clipping
2020-01-06 10:46:06 -08:00
Matt Weiden
327d005a1f Add requests 2.22.0 as a server dependency (#1089) 2020-01-03 10:59:46 -08:00
Matt Weiden
0d2cb14796 Fix smoke test instructions (#1087) 2020-01-02 16:32:00 -08:00
Sidney Bell
97738e5c2d Remove FAQ link from info menu (#1084) 2020-01-02 16:04:38 -08:00
Bruce Martin
dfaf0d0603 allow hyphen in annotation file name (#1074)
* remove old detritus

* allow hyphen in label file name
2020-01-02 15:44:40 -08:00
Matt Weiden
0b1bdca022 Use npm ci instead of npm install during build (#1080)
Currently the client build is not reproducible since, each time you run
`make build-client` the package lockfile is updated. This should be
handled separately by `make gen-package-lock` when developers actually
want to update the dependencies.

`npm ci` installs dependencies directly from the lockfile without
updating them, making builds reproducible.
2020-01-02 10:21:14 -08:00
Bruce Martin
6370025caf update all JS package deps (#1076)
* update dependencies - minor revisions

* update min node_js version to 10

* major npm package dep updates

* a few more updates
2020-01-02 09:14:09 -08:00
Matt Weiden
53a6d01fa3 Notify users of new versions of cellxgene (#1078)
* Notify users of new versions of cellxgene

Fixes https://github.com/chanzuckerberg/cellxgene/issues/683

* Do not use PyGithub client

* Protect against AttributeError

* Document that all version tags must follow SemVer

* Release tags `should -> MUST` follow semantic versioning
2019-12-31 17:43:11 -08:00
Matt Weiden
29947e25c3 Serve Roboto Condensed font from the app directly (#1077)
* Serve Roboto Condensed font from the app directly

Fixes https://github.com/chanzuckerberg/cellxgene/issues/344

* Remove second google fonts reference
2019-12-31 17:07:16 -08:00
Matt Weiden
f3015cb9df Makefile modularity, test targets, and auto-formatting (#1070)
* Fix Makefile whitespace and .PHONY use

* Fix Makefile filename

* Modularize Makefile into client and server Makefiles

Part of the reason that the Makefile in the root directory is a bit
complicated is that it tries to handle tasks that can be handled
separately in the client and server modules.

This commit pushes some of the make logic specific to each module into
their own makefiles and calls out to those makefiles from that in the
project root.

* Add auto-formatting to client and server modules

One thing that can make linting faster is auto-formatting. This commit
adds the yapf auto-formatting tool to the server module and uses
eslint's "fix" functionality to speed up the linting/formatting process.

* Add yapf for automatic code formatting

* Add a root test target that calls sub-tests

* Apply yapf to python files

* Do not duplicate npm commands, simply pass through

* Update documentation

* Do not shadow reserved word len

* Add general test target

* Fix make call in dev-env

* Use black instead of yapf

* Run flake8 from the root directory

* Revert "Apply yapf to python files"

This reverts commit cdca128a01.

* Apply black to python code

* Resolve lint errors resulting from black format

* Add explanation of server unit tests in dev guidelines
2019-12-27 14:43:37 -08:00
Sidney Bell
ec79995be8 Reorganize annotations docs to emphasize hosted vs single-user modes (#1067) 2019-12-03 17:02:35 -08:00
Sidney Bell
517e0f3826 [docs] Fix annotations command 2019-12-02 09:26:07 -08:00
Sidney Bell
5812e00e01 Merge remote-tracking branch 'origin/master' 2019-11-27 08:49:56 -08:00
Sidney Bell
1ed68261d4 Add sceasy package to docs 2019-11-27 08:49:21 -08:00
Sidney Bell
9c09ee6329 Update readme and other repo MD files (#1063)
* Update readme

* Move roadmap to main docs site

* Avoid duplication by just putting a pointer to the actual docs
0.13.0
2019-11-26 16:09:59 -08:00
Bruce Martin
c9b6044c4f release 0.13.0 (#1064) 2019-11-26 15:45:13 -08:00
Bruce Martin
fa89a5a375 create annotations output dir if it does not exist (#1062)
* create annotations output dir if it doees not exist

* lint
2019-11-26 13:35:20 -08:00
Bruce Martin
f8cef71eed help text changes (#1061)
* requested CLI help changes for launch sub-command

* update file name prose

* more wording changes

* more PR requests
2019-11-26 13:35:01 -08:00
Sidney Bell
bb3032ea2f Update getting started docs w/ direct url launch 2019-11-26 12:57:50 -08:00
Sidney Bell
5e471349e7 Cleanup docs files 2019-11-26 08:44:23 -08:00
Sidney Bell
0aee4b89e0 Fix docs font 2019-11-26 08:43:57 -08:00
Bruce Martin
d2171b9a2f fix perf regression introduced by user anno changes (#1060) 2019-11-25 18:16:49 -08:00
Bruce Martin
a593e95ab3 annotations CLI and file UX rework (#1049)
* rename config param label-file

* annotations rework - CLI params, file naming and backups

* lint

* improve cli option error checks

* enable session cookies

* enable session cookies

* add session id

* name annotations file in multi-dataset and multi-user safe manner

* pass data user hash to front-end

* add annotation collection name support to front-end

* add constant for annotation data collection name

* parameterize annotation collection name; make it sticky in the session

* clarify comments

* hard wire a temporary data collection name for testing

* prettier

* test comment

* package command

* set annotations  filename dialog

* name  and hash are visible

* wire up data collection capture
2019-11-25 15:28:28 -08:00
Sidney Bell
575f71aaee Fix base url 2019-11-22 18:17:43 -08:00
Sidney Bell
04aa6f8fe9 Merge branch 'sidneymbell/docs-overhaul' 2019-11-22 15:00:24 -08:00
Sidney Bell
298ded6e2d Add site files 2019-11-22 14:59:40 -08:00
Sidney Bell
9bcafeb7c1 [WIP] Overhaul the documentation site (#1030)
Overhaul the whole documentation site
2019-11-22 14:54:20 -08:00
Sidney Bell
85c1b6957e Final annotations notes 2019-11-22 14:53:35 -08:00
Sidney Bell
2f99b317a2 Update annotations docs 2019-11-22 13:57:50 -08:00
Sidney Bell
8535664e9c Typo 2019-11-22 11:26:55 -08:00
Sidney Bell
5ed9f5126b Switch demo datasets to launch directly from URL 2019-11-22 11:26:51 -08:00
Bruce Martin
5713aa8792 category and label name validation updates (#1056)
* update label validation with new schema

* add new error messages for new label errors; general cleanup
2019-11-22 10:32:00 -08:00
Severiano Badajoz
9aaaad6709 tweak allotted width for value name + occupancy and tweak truncating (#1051) 2019-11-21 20:14:11 -08:00
Sidney Bell
621b88bff4 Simplify demo data download 2019-11-21 18:51:30 -08:00
Sidney Bell
ecedf666c7 Bold current page in nav 2019-11-21 18:51:13 -08:00
Sidney Bell
afff2ceec7 Update logo 2019-11-21 18:50:55 -08:00
Sidney Bell
be9a415a4a Typo 2019-11-21 17:02:59 -08:00
Sidney Bell
0295041972 Fix typos, etc in prepare 2019-11-21 17:02:50 -08:00
Sidney Bell
8fe7ee75e8 Minor text edits to launch 2019-11-21 17:02:30 -08:00
Sidney Bell
a3d96aae0a Minor text edits to hosted (i.e., typos) 2019-11-21 17:02:01 -08:00